From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C75C433E3 for ; Mon, 29 Jun 2020 18:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75FD620656 for ; Mon, 29 Jun 2020 18:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EOEH+B4Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729843AbgF2SxY (ORCPT ); Mon, 29 Jun 2020 14:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729816AbgF2Sww (ORCPT ); Mon, 29 Jun 2020 14:52:52 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1449C00F819 for ; Mon, 29 Jun 2020 05:32:24 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z15so5092936wrl.8 for ; Mon, 29 Jun 2020 05:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gy5XGROE42zu/OtGr1HVd4C1Erola+sMm0BAiQi5EAg=; b=EOEH+B4YAdFOH+2/KoijG8knN+YekUDS5ypT4nuQN27G/Jo02pRILBXHZJ5OmgwIYl UXsWDmJqnNK01epEhCxiKDeVnprl7cvBLEDFzU4upD4QbgxddQsrVIua0JmkNof+T46p K4zlsTPn6Bij6eu47CcKTpCxVL9+YccP45x5lupJxTtdoYfeNot2cE6OHksag/TRXaqi 06zg1uc9lqpWNIqi73eXK1RH6cHkXEcQJrBllza8pnEY9j2cpAsvJZntWUYfLzaQRLFA LLLRkYrwGcKoLxgpMvKoMT3wFIdZx25ikmSAn6bQ0J3daVmzMXFMs3VR36S7QYHogK+u IpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gy5XGROE42zu/OtGr1HVd4C1Erola+sMm0BAiQi5EAg=; b=iiU3vKsoYHzV7nEtRFpOTLyfPbQxbkgUGUsC/SCfd9bWQLhIuskq+9CBAn9K4ZJyl+ jdF13EasHF6amqBHH0P0aYM+VHMGwF8xWjJWV1MOVTFfk+VofTG8ehBqfyzWCwq6mC9q 8RFR6Lb4vBqfr/agpF1o5elceKE4kUytk3qfNh0W12wBi35LiU+bCdkVATCBpe5qVifZ Ute4wxhrfOv73mIiGbfanjV9uaBexuWyL0fu+Rq/qA8CuYLsH8czzv8PdflItllOqxlF iZ3qR4N5GGpDsU1QRRbu3KGc0vFd6EEu03LvLUM0fGRDwL8NKTulAgJCM30rDIlV7ch6 yFFw== X-Gm-Message-State: AOAM531Kv5l4BOE0G7U7vSM6auDRwCGg62r7TwQt49EkxJWje8GJiFP2 mTA2LcjArhzwOxn1b3q79dKTwD1fOII= X-Google-Smtp-Source: ABdhPJzx1S6JaOHDpOE7Um5NlUKwwsXS6LziGKVWvGGhJ+ABrjXd+W/9XaQZh6Ee4qGBqKImmEb7XQ== X-Received: by 2002:adf:f842:: with SMTP id d2mr18183246wrq.55.1593433943756; Mon, 29 Jun 2020 05:32:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id d201sm28064111wmd.34.2020.06.29.05.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:32:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang Subject: [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask Date: Mon, 29 Jun 2020 13:32:14 +0100 Message-Id: <20200629123215.1014747-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629123215.1014747-1-lee.jones@linaro.org> References: <20200629123215.1014747-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since ddata->irqs[] is already zeroed when allocated by devm_kcalloc() and dividing 0 by anything is still 0, there is no need to re-assign ddata->irqs[i].* values. Instead, it should be safe to begin at 1. This fixes the following W=1 warning: drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones --- drivers/mfd/sprd-sc27xx-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index c305e941e435c..694a7d429ccff 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -251,7 +251,7 @@ static int sprd_pmic_probe(struct spi_device *spi) return -ENOMEM; ddata->irq_chip.irqs = ddata->irqs; - for (i = 0; i < pdata->num_irqs; i++) { + for (i = 1; i < pdata->num_irqs; i++) { ddata->irqs[i].reg_offset = i / pdata->num_irqs; ddata->irqs[i].mask = BIT(i % pdata->num_irqs); } -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35152C433DF for ; Mon, 29 Jun 2020 12:35:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 005B323B2A for ; Mon, 29 Jun 2020 12:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L7YLljBM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EOEH+B4Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 005B323B2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2WaeesdunHvS/tbd5GiLjb5Z3VtesrWD50ZwFvLYBHA=; b=L7YLljBMzS9l6032HO6kissHY ms7XJczBREKwZYSCvFjr1srTKtqSPU6d8XFyXNNT4ZWJxarxoCvgV86o4rLkPjBZB6i3PeFpMsEUe h1eLptdil2jms8kcyokuKerENEdbKnOiDLHzfdRK6u/Ra9tejQ0+x5PyxPNIrsuI1RjdDbjf4ulDg PoKCzr8AQhKfaY8lyvCDrPzKEYQSS6dZWCaSKkimXWA4fgQ2usudMNStqsJWWWkv5WXgvu1Wgqsdp p7SQCqcoZOZXqKN8WH1wLNGOcsnLepMdjGfVO6/KGTwITm/FW9pKN15Grzl6jpekjUP34dTpD78Gk 0PwQ4Fzxg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsyW-0006V5-3k; Mon, 29 Jun 2020 12:33:28 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsxW-0005uR-Dv for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 12:32:28 +0000 Received: by mail-wr1-x442.google.com with SMTP id z13so16365994wrw.5 for ; Mon, 29 Jun 2020 05:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gy5XGROE42zu/OtGr1HVd4C1Erola+sMm0BAiQi5EAg=; b=EOEH+B4YAdFOH+2/KoijG8knN+YekUDS5ypT4nuQN27G/Jo02pRILBXHZJ5OmgwIYl UXsWDmJqnNK01epEhCxiKDeVnprl7cvBLEDFzU4upD4QbgxddQsrVIua0JmkNof+T46p K4zlsTPn6Bij6eu47CcKTpCxVL9+YccP45x5lupJxTtdoYfeNot2cE6OHksag/TRXaqi 06zg1uc9lqpWNIqi73eXK1RH6cHkXEcQJrBllza8pnEY9j2cpAsvJZntWUYfLzaQRLFA LLLRkYrwGcKoLxgpMvKoMT3wFIdZx25ikmSAn6bQ0J3daVmzMXFMs3VR36S7QYHogK+u IpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gy5XGROE42zu/OtGr1HVd4C1Erola+sMm0BAiQi5EAg=; b=qdGRSn9gVtEIOs03I+lIn+m6875iWcvtJpC5KcqJ55N3Bwf4DKEpptnl9OXG8G9vRV CEc/uIGC2ZVGjRg/eqZIVnvGVhVbB9e/QU/J5SlRxPY+OSiEQuewu0ezHIjjj1iN8BkO 2GonoOiHO8PmTPWs7r3L6N77JSf6jyP6pN0hkRrm1PZOdvrS/MAugT63ZUH3xjQbnzeN aTu7gsFazvr4o8uqzq62b6gHxX33b4eXcHa3+FSQHxlS1Z2yZFMYcN3mqiz+BueAKyHP 1J8toOkUz+HOiWi8upPrH5iP+RQlrc14csuLxeKB+5eEWS2Y3Hu494gBQQRmzVXiDMav YbgQ== X-Gm-Message-State: AOAM530yKW4H2Ca1lsIbTBb1vpaTlj7d9p6zqkR6jwiJt7JUSlTf86aA yjW3BdzOZLfW78vgCFoKVHiKww== X-Google-Smtp-Source: ABdhPJzx1S6JaOHDpOE7Um5NlUKwwsXS6LziGKVWvGGhJ+ABrjXd+W/9XaQZh6Ee4qGBqKImmEb7XQ== X-Received: by 2002:adf:f842:: with SMTP id d2mr18183246wrq.55.1593433943756; Mon, 29 Jun 2020 05:32:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id d201sm28064111wmd.34.2020.06.29.05.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:32:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask Date: Mon, 29 Jun 2020 13:32:14 +0100 Message-Id: <20200629123215.1014747-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629123215.1014747-1-lee.jones@linaro.org> References: <20200629123215.1014747-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baolin Wang , Orson Zhai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chunyan Zhang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since ddata->irqs[] is already zeroed when allocated by devm_kcalloc() and dividing 0 by anything is still 0, there is no need to re-assign ddata->irqs[i].* values. Instead, it should be safe to begin at 1. This fixes the following W=1 warning: drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones --- drivers/mfd/sprd-sc27xx-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index c305e941e435c..694a7d429ccff 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -251,7 +251,7 @@ static int sprd_pmic_probe(struct spi_device *spi) return -ENOMEM; ddata->irq_chip.irqs = ddata->irqs; - for (i = 0; i < pdata->num_irqs; i++) { + for (i = 1; i < pdata->num_irqs; i++) { ddata->irqs[i].reg_offset = i / pdata->num_irqs; ddata->irqs[i].mask = BIT(i % pdata->num_irqs); } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel