From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Dev Null <devnull@uvos.xyz>, Pavel Machek <pavel@ucw.cz>,
Merlijn Wajer <merlijn@wizzup.org>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-rtc@vger.kernel.org,
"Sicelo A . Mhlongo" <absicsz@gmail.com>
Subject: Re: [PATCH] rtc: cpcap: fix range
Date: Mon, 29 Jun 2020 07:34:54 -0700 [thread overview]
Message-ID: <20200629143454.GP37466@atomide.com> (raw)
In-Reply-To: <20200629114123.27956-1-sebastian.reichel@collabora.com>
* Sebastian Reichel <sebastian.reichel@collabora.com> [200629 11:42]:
> Unbreak CPCAP driver, which has one more bit in the day counter
> increasing the max. range from 2014 to 2058. The original commit
> introducing the range limit was obviously wrong, since the driver
> has only been written in 2017 (3 years after 14 bits would have
> run out).
So I guess with 14 bits vs 15 bits we have these date ranges:
1970 + (0x3fff / 365) = 2014
1970 + (0x7fff / 365) = 2059
Meaning we can't do the whole year for 2059 and it's only 2058
compatible like you say above :)
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2020-06-29 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 22:29 [bug report] Droid 4 cpcap rtc Dev Null
2020-06-29 11:41 ` [PATCH] rtc: cpcap: fix range Sebastian Reichel
2020-06-29 14:34 ` Tony Lindgren [this message]
2020-06-29 17:25 ` Merlijn Wajer
2020-07-02 20:23 ` Alexandre Belloni
2020-06-29 11:42 ` [bug report] Droid 4 cpcap rtc Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629143454.GP37466@atomide.com \
--to=tony@atomide.com \
--cc=absicsz@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devnull@uvos.xyz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.