Re: [PATCH v3 02/16] btrfs-progs: add global verbose and quiet options and helper functions

[David Sterba <dsterba@suse.cz>]

On Fri, Jun 12, 2020 at 06:56:06PM +0800, Anand Jain wrote:
> Add btrfs(8) global --verbose and --quiet command options to show
> verbose or no output from the sub-commands.
> By introducing global a %bconf::verbose memeber to transpire the same
> down to the sub-command.
> Further the added helper function pr_verbose() helps to logs the verbose
> messages, based on the state of the %bconf::verbose. And further HELPINFO_
> defines are provides for the usage.
> 
> Suggested-by: David Sterba <dsterba@suse.com>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v3:
>   Add define MUST_LOG
>   Add comment about the argument %level in the function pr_verbose()

So the v2 got merged and v3 is not usable as replacement because I did a
lot of fixups to v2 that would be lost. The updated help text and
documentation need to reflect that the subcommand specific options are
deprecated but still kept as an alias.

+	"-q|--quiet       suppress all messages, except errors. This option is",
+	"                 merged to the global quiet option.

In particular, I find the use of word 'merged' to be confusing here.
The final wording is:

-v       deprecated, alias for global -v option

or

-q       deprecated, alias for global -q option

and the options are last in the list. Similar for the documentation,
plus several fixup of spacing. All these things are just help text
updates but user-facing and it has its own importance. I had not
anticipated that merging that would be such time sink despite the
relative simplicity.