From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B28DC433E1 for ; Mon, 29 Jun 2020 20:34:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E179B206A1 for ; Mon, 29 Jun 2020 20:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="my3ZWmBM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732330AbgF2TXx (ORCPT ); Mon, 29 Jun 2020 15:23:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732139AbgF2TWo (ORCPT ); Mon, 29 Jun 2020 15:22:44 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F2BC0307A3 for ; Mon, 29 Jun 2020 08:45:46 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id q5so17013577wru.6 for ; Mon, 29 Jun 2020 08:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=M6RFYDYqKSXVITYiEJiCJyNvIh/8cppoOkzBR1lf/Bs=; b=my3ZWmBMP+bCFEkJOKqlXlSIimSWj2tQJFqLXD9wspUC/PoOmo34zvQ7tz7JEezZU6 zSSaODsccUwy30lD3WpOhEDpSDNGtsbm6UcC7V/F1wTgKdSEa/b4H84NV/m79B2YZ4I0 GwAAPAj11jo/YjCgLD3qXQiV+FJzvRbv+gnu7o6H8ZMCyztf1/18HgORZkzVIKDxnjmH cTm+hpNcu29IIKCRqcalb6/8LHeZlrawAdBZRXbu+IzbydLWmwK/X0ZiXNj9mY49te4R 00p4vQMlgX2DWlp28wBmEyt1t3uZg47UykBZroKsUN7AsCzsGNBkkfvOl/1Hulw12ck0 wk3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=M6RFYDYqKSXVITYiEJiCJyNvIh/8cppoOkzBR1lf/Bs=; b=NoIWCU0dQch0KQNHxD+jGK83JpoYYWxbnV1o1vSmAgFpcRyvuUM6k/O2k5ZB+Jn9UU k4LeZUNZjfy/AqzxSicnUcXvpiiM6AZQwGrTFEwhKKkVdwEitDaD0lgSsIP27GetlkrN qiylursbU3KDOoZ+8IX8VvhfGlFjD5XRaGSDX4QA0NjwVU5tIpRLl3HTKJQKK0lccAhC l49rGdj+JTg4qLIYnnAU8tAV95fCv68iNIrxZzgeg6dUa8Ahx+swAFc6+Gh8geFPE3Ss YgyDi4x9fTMP+DbWz3UdEqeSMc7sUKF6ddEBUbeFKIvpMpdQrEcYhajbzPasXuTr35QM YW3Q== X-Gm-Message-State: AOAM531CX392+Xb4vba72qXbXV2WNH9S9+07C+fG23wZuYFksJGMukEA hamHOuvnEhe2w5wdk7W38tZDiQ== X-Google-Smtp-Source: ABdhPJwlVgDj6Deyg8ldvc9Ax2DufMoYBmRY/fYIpLkc9zjDg8/qVeDEIufyWzOfNvWxUKXNbbUlmA== X-Received: by 2002:a5d:4687:: with SMTP id u7mr18485096wrq.357.1593445545423; Mon, 29 Jun 2020 08:45:45 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c143sm32065643wmd.1.2020.06.29.08.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 08:45:44 -0700 (PDT) Date: Mon, 29 Jun 2020 16:45:43 +0100 From: Lee Jones To: Baolin Wang Cc: Johan Hovold , Orson Zhai , LKML , linux-arm-kernel@lists.infradead.org, Chunyan Zhang Subject: Re: [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask Message-ID: <20200629154543.GN177734@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-5-lee.jones@linaro.org> <20200629130644.GU3334@localhost> <20200629140137.GK177734@dell> <20200629144325.GV3334@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Jun 2020, Baolin Wang wrote: > On Mon, Jun 29, 2020 at 10:43 PM Johan Hovold wrote: > > > > On Mon, Jun 29, 2020 at 10:35:06PM +0800, Baolin Wang wrote: > > > On Mon, Jun 29, 2020 at 10:01 PM Lee Jones wrote: > > > > > > > > On Mon, 29 Jun 2020, Johan Hovold wrote: > > > > > > > > > On Mon, Jun 29, 2020 at 01:32:14PM +0100, Lee Jones wrote: > > > > > > Since ddata->irqs[] is already zeroed when allocated by devm_kcalloc() and > > > > > > dividing 0 by anything is still 0, there is no need to re-assign > > > > > > ddata->irqs[i].* values. Instead, it should be safe to begin at 1. > > > > > > > > > > > > This fixes the following W=1 warning: > > > > > > > > > > > > drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero > > > > > > > > > > > > Cc: Orson Zhai > > > > > > Cc: Baolin Wang > > > > > > Cc: Chunyan Zhang > > > > > > Signed-off-by: Lee Jones > > > > > > --- > > > > > > drivers/mfd/sprd-sc27xx-spi.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > > > > > > index c305e941e435c..694a7d429ccff 100644 > > > > > > --- a/drivers/mfd/sprd-sc27xx-spi.c > > > > > > +++ b/drivers/mfd/sprd-sc27xx-spi.c > > > > > > @@ -251,7 +251,7 @@ static int sprd_pmic_probe(struct spi_device *spi) > > > > > > return -ENOMEM; > > > > > > > > > > > > ddata->irq_chip.irqs = ddata->irqs; > > > > > > - for (i = 0; i < pdata->num_irqs; i++) { > > > > > > + for (i = 1; i < pdata->num_irqs; i++) { > > > > > > ddata->irqs[i].reg_offset = i / pdata->num_irqs; > > > > > > ddata->irqs[i].mask = BIT(i % pdata->num_irqs); > > > > > > } > > > > > > > > > > This doesn't look right either. > > > > > > > > > > First, the loop is never executed if num_irqs is zero. > > > > > > > > The point of the patch is that 0 entries are never processed. > > > > So what's the problem? There's no division by zero here. > > > > And what compiler are you using, Lee? Seems broken. > > > > > > > Second, the current code looks bogus too as reg_offset is always set to > > > > > zero and mask to BIT(i)... > > > > > > Now the result is correct, since all PMIC irq mask bits are in one > > > register now, which means the reg_offset is always 0 can work well. > > > But I think the logics still can be improved if our PMIC irq numbers > > > are larger than 32 in future. > > > > The code is still bogus as pointed out above. Why do you bother to > > divide by num_irqs at all? > > Right, no need to divide by num_irqs, can be simplified as below. Lee, > care to resend your patch with simplifying the code? Or you want me to > send a patch? > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > index 33336cde4724..2ed5f3a4e79c 100644 > --- a/drivers/mfd/sprd-sc27xx-spi.c > +++ b/drivers/mfd/sprd-sc27xx-spi.c > @@ -250,10 +250,8 @@ static int sprd_pmic_probe(struct spi_device *spi) > return -ENOMEM; > > ddata->irq_chip.irqs = ddata->irqs; > - for (i = 0; i < pdata->num_irqs; i++) { > - ddata->irqs[i].reg_offset = i / pdata->num_irqs; > - ddata->irqs[i].mask = BIT(i % pdata->num_irqs); > - } > + for (i = 0; i < pdata->num_irqs; i++) > + ddata->irqs[i].mask = BIT(i); I'm happy to resend with your Suggested-by. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642BFC433E0 for ; Mon, 29 Jun 2020 15:47:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3195E25268 for ; Mon, 29 Jun 2020 15:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1wU/nhbV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="my3ZWmBM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3195E25268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UcL2Wq40wP9Z0uoJeUlnwnKWdlQj+xasz+pm5JAFMdQ=; b=1wU/nhbV04USjbXskwLpYMfOD ED/yINWWXOJwafst8wYjDE+KJ2p1SzHuGEwGOnm2S8eppWrJz1TyIJ0eGhfuSSqrerfp8iGVx/38x fd+PImw3+ZiyXzoVpKxvX2aged43g2ERHex7pzkh1GkYUVmzDBFctVvPZpoWdzBmh2g/0YucFlIfF SxeFRQC7UuSGj0YEeGZE2Dn4qVRYdIFu/62eMFfIdIwHily04iFhy/qSBQ83X6DWraTmj4gUx1ZtI cAr5vzd1ajUkcxbc21TH1LSbM3dY0+dRQXF0z4tO4cN/t3nDkG9tCg/cJs1TR4MxJF51JXCM3BG9M 46VS+SzMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvyf-0001sy-FQ; Mon, 29 Jun 2020 15:45:49 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvyc-0001sL-Er for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 15:45:47 +0000 Received: by mail-wr1-x443.google.com with SMTP id f7so14027827wrw.1 for ; Mon, 29 Jun 2020 08:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=M6RFYDYqKSXVITYiEJiCJyNvIh/8cppoOkzBR1lf/Bs=; b=my3ZWmBMP+bCFEkJOKqlXlSIimSWj2tQJFqLXD9wspUC/PoOmo34zvQ7tz7JEezZU6 zSSaODsccUwy30lD3WpOhEDpSDNGtsbm6UcC7V/F1wTgKdSEa/b4H84NV/m79B2YZ4I0 GwAAPAj11jo/YjCgLD3qXQiV+FJzvRbv+gnu7o6H8ZMCyztf1/18HgORZkzVIKDxnjmH cTm+hpNcu29IIKCRqcalb6/8LHeZlrawAdBZRXbu+IzbydLWmwK/X0ZiXNj9mY49te4R 00p4vQMlgX2DWlp28wBmEyt1t3uZg47UykBZroKsUN7AsCzsGNBkkfvOl/1Hulw12ck0 wk3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=M6RFYDYqKSXVITYiEJiCJyNvIh/8cppoOkzBR1lf/Bs=; b=HUijatdaKXRFXdyvaGKb+XZNdTA9f6ZjS83Pt9fWBuULZoLIszlEU/zQK+NpSpJaw+ RE/k1r6DzTfzHMLcxjbNf55KvgGBk6BrNzkeTloM3OT2YKX9HCQqkYr4x16mikt+6Ea3 ZLdrpI5ycm5mAqXzS7bFo/eZ/EWWCtWfzvmmAYw1wZV6ZZm5IobODeM7Bpz5w+EQsV/b +WWM6wcxzTfKACtaBJclSkcz0TjisPgt6OAKANFk0iZ4SZSOl6sZVbuSQvL1SUHB/Ckc c8O9O9Vm98oZjmVDamwH6qJ/wiApUYyCvpeTkcxJyKrdTeDTGp8TJteALDtwVTr6jcFg 8miw== X-Gm-Message-State: AOAM530o9lVd3mJb8ZCby1nRFmlcNIan/vX9XUmX+6pT4LLLKBQRqAaI PBh2y7YDq2Fqvn0FT9fjEWLBfA== X-Google-Smtp-Source: ABdhPJwlVgDj6Deyg8ldvc9Ax2DufMoYBmRY/fYIpLkc9zjDg8/qVeDEIufyWzOfNvWxUKXNbbUlmA== X-Received: by 2002:a5d:4687:: with SMTP id u7mr18485096wrq.357.1593445545423; Mon, 29 Jun 2020 08:45:45 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c143sm32065643wmd.1.2020.06.29.08.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 08:45:44 -0700 (PDT) Date: Mon, 29 Jun 2020 16:45:43 +0100 From: Lee Jones To: Baolin Wang Subject: Re: [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask Message-ID: <20200629154543.GN177734@dell> References: <20200629123215.1014747-1-lee.jones@linaro.org> <20200629123215.1014747-5-lee.jones@linaro.org> <20200629130644.GU3334@localhost> <20200629140137.GK177734@dell> <20200629144325.GV3334@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Orson Zhai , Chunyan Zhang , Johan Hovold , linux-arm-kernel@lists.infradead.org, LKML Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyOSBKdW4gMjAyMCwgQmFvbGluIFdhbmcgd3JvdGU6Cgo+IE9uIE1vbiwgSnVuIDI5 LCAyMDIwIGF0IDEwOjQzIFBNIEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9yZz4gd3JvdGU6 Cj4gPgo+ID4gT24gTW9uLCBKdW4gMjksIDIwMjAgYXQgMTA6MzU6MDZQTSArMDgwMCwgQmFvbGlu IFdhbmcgd3JvdGU6Cj4gPiA+IE9uIE1vbiwgSnVuIDI5LCAyMDIwIGF0IDEwOjAxIFBNIExlZSBK b25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gT24gTW9u LCAyOSBKdW4gMjAyMCwgSm9oYW4gSG92b2xkIHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gPiBPbiBN b24sIEp1biAyOSwgMjAyMCBhdCAwMTozMjoxNFBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g PiA+ID4gPiA+IFNpbmNlIGRkYXRhLT5pcnFzW10gaXMgYWxyZWFkeSB6ZXJvZWQgd2hlbiBhbGxv Y2F0ZWQgYnkgZGV2bV9rY2FsbG9jKCkgYW5kCj4gPiA+ID4gPiA+IGRpdmlkaW5nIDAgYnkgYW55 dGhpbmcgaXMgc3RpbGwgMCwgdGhlcmUgaXMgbm8gbmVlZCB0byByZS1hc3NpZ24KPiA+ID4gPiA+ ID4gZGRhdGEtPmlycXNbaV0uKiB2YWx1ZXMuICBJbnN0ZWFkLCBpdCBzaG91bGQgYmUgc2FmZSB0 byBiZWdpbiBhdCAxLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBUaGlzIGZpeGVzIHRoZSBmb2xs b3dpbmcgVz0xIHdhcm5pbmc6Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ICBkcml2ZXJzL21mZC9z cHJkLXNjMjd4eC1zcGkuYzoyNTUgc3ByZF9wbWljX3Byb2JlKCkgZGVidWc6IHN2YWxfYmlub3Bf dW5zaWduZWQ6IGRpdmlkZSBieSB6ZXJvCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IENjOiBPcnNv biBaaGFpIDxvcnNvbnpoYWlAZ21haWwuY29tPgo+ID4gPiA+ID4gPiBDYzogQmFvbGluIFdhbmcg PGJhb2xpbi53YW5nN0BnbWFpbC5jb20+Cj4gPiA+ID4gPiA+IENjOiBDaHVueWFuIFpoYW5nIDx6 aGFuZy5seXJhQGdtYWlsLmNvbT4KPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVz IDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ICBkcml2 ZXJzL21mZC9zcHJkLXNjMjd4eC1zcGkuYyB8IDIgKy0KPiA+ID4gPiA+ID4gIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvc3ByZC1zYzI3eHgtc3BpLmMgYi9kcml2ZXJzL21m ZC9zcHJkLXNjMjd4eC1zcGkuYwo+ID4gPiA+ID4gPiBpbmRleCBjMzA1ZTk0MWU0MzVjLi42OTRh N2Q0MjljY2ZmIDEwMDY0NAo+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL21mZC9zcHJkLXNjMjd4 eC1zcGkuYwo+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL21mZC9zcHJkLXNjMjd4eC1zcGkuYwo+ ID4gPiA+ID4gPiBAQCAtMjUxLDcgKzI1MSw3IEBAIHN0YXRpYyBpbnQgc3ByZF9wbWljX3Byb2Jl KHN0cnVjdCBzcGlfZGV2aWNlICpzcGkpCj4gPiA+ID4gPiA+ICAgICAgICAgICAgIHJldHVybiAt RU5PTUVNOwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiAgICAgZGRhdGEtPmlycV9jaGlwLmlycXMg PSBkZGF0YS0+aXJxczsKPiA+ID4gPiA+ID4gLSAgIGZvciAoaSA9IDA7IGkgPCBwZGF0YS0+bnVt X2lycXM7IGkrKykgewo+ID4gPiA+ID4gPiArICAgZm9yIChpID0gMTsgaSA8IHBkYXRhLT5udW1f aXJxczsgaSsrKSB7Cj4gPiA+ID4gPiA+ICAgICAgICAgICAgIGRkYXRhLT5pcnFzW2ldLnJlZ19v ZmZzZXQgPSBpIC8gcGRhdGEtPm51bV9pcnFzOwo+ID4gPiA+ID4gPiAgICAgICAgICAgICBkZGF0 YS0+aXJxc1tpXS5tYXNrID0gQklUKGkgJSBwZGF0YS0+bnVtX2lycXMpOwo+ID4gPiA+ID4gPiAg ICAgfQo+ID4gPiA+ID4KPiA+ID4gPiA+IFRoaXMgZG9lc24ndCBsb29rIHJpZ2h0IGVpdGhlci4K PiA+ID4gPiA+Cj4gPiA+ID4gPiBGaXJzdCwgdGhlIGxvb3AgaXMgbmV2ZXIgZXhlY3V0ZWQgaWYg bnVtX2lycXMgaXMgemVyby4KPiA+ID4gPgo+ID4gPiA+IFRoZSBwb2ludCBvZiB0aGUgcGF0Y2gg aXMgdGhhdCAwIGVudHJpZXMgYXJlIG5ldmVyIHByb2Nlc3NlZC4KPiA+Cj4gPiBTbyB3aGF0J3Mg dGhlIHByb2JsZW0/IFRoZXJlJ3Mgbm8gZGl2aXNpb24gYnkgemVybyBoZXJlLgo+ID4KPiA+IEFu ZCB3aGF0IGNvbXBpbGVyIGFyZSB5b3UgdXNpbmcsIExlZT8gU2VlbXMgYnJva2VuLgo+ID4KPiA+ ID4gPiA+IFNlY29uZCwgdGhlIGN1cnJlbnQgY29kZSBsb29rcyBib2d1cyB0b28gYXMgcmVnX29m ZnNldCBpcyBhbHdheXMgc2V0IHRvCj4gPiA+ID4gPiB6ZXJvIGFuZCBtYXNrIHRvIEJJVChpKS4u Lgo+ID4gPgo+ID4gPiBOb3cgdGhlIHJlc3VsdCBpcyBjb3JyZWN0LCBzaW5jZSBhbGwgUE1JQyBp cnEgbWFzayBiaXRzIGFyZSBpbiBvbmUKPiA+ID4gcmVnaXN0ZXIgbm93LCB3aGljaCBtZWFucyB0 aGUgcmVnX29mZnNldCBpcyBhbHdheXMgMCBjYW4gd29yayB3ZWxsLgo+ID4gPiBCdXQgSSB0aGlu ayB0aGUgbG9naWNzIHN0aWxsIGNhbiBiZSBpbXByb3ZlZCBpZiBvdXIgUE1JQyBpcnEgbnVtYmVy cwo+ID4gPiBhcmUgbGFyZ2VyIHRoYW4gMzIgaW4gZnV0dXJlLgo+ID4KPiA+IFRoZSBjb2RlIGlz IHN0aWxsIGJvZ3VzIGFzIHBvaW50ZWQgb3V0IGFib3ZlLiBXaHkgZG8geW91IGJvdGhlciB0bwo+ ID4gZGl2aWRlIGJ5IG51bV9pcnFzIGF0IGFsbD8KPiAKPiBSaWdodCwgbm8gbmVlZCB0byBkaXZp ZGUgYnkgbnVtX2lycXMsIGNhbiBiZSBzaW1wbGlmaWVkIGFzIGJlbG93LiBMZWUsCj4gY2FyZSB0 byByZXNlbmQgeW91ciBwYXRjaCB3aXRoIHNpbXBsaWZ5aW5nIHRoZSBjb2RlPyBPciB5b3Ugd2Fu dCBtZSB0bwo+IHNlbmQgYSBwYXRjaD8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvc3ByZC1z YzI3eHgtc3BpLmMgYi9kcml2ZXJzL21mZC9zcHJkLXNjMjd4eC1zcGkuYwo+IGluZGV4IDMzMzM2 Y2RlNDcyNC4uMmVkNWYzYTRlNzljIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL3NwcmQtc2My N3h4LXNwaS5jCj4gKysrIGIvZHJpdmVycy9tZmQvc3ByZC1zYzI3eHgtc3BpLmMKPiBAQCAtMjUw LDEwICsyNTAsOCBAQCBzdGF0aWMgaW50IHNwcmRfcG1pY19wcm9iZShzdHJ1Y3Qgc3BpX2Rldmlj ZSAqc3BpKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAKPiAgICAgICAgIGRk YXRhLT5pcnFfY2hpcC5pcnFzID0gZGRhdGEtPmlycXM7Cj4gLSAgICAgICBmb3IgKGkgPSAwOyBp IDwgcGRhdGEtPm51bV9pcnFzOyBpKyspIHsKPiAtICAgICAgICAgICAgICAgZGRhdGEtPmlycXNb aV0ucmVnX29mZnNldCA9IGkgLyBwZGF0YS0+bnVtX2lycXM7Cj4gLSAgICAgICAgICAgICAgIGRk YXRhLT5pcnFzW2ldLm1hc2sgPSBCSVQoaSAlIHBkYXRhLT5udW1faXJxcyk7Cj4gLSAgICAgICB9 Cj4gKyAgICAgICBmb3IgKGkgPSAwOyBpIDwgcGRhdGEtPm51bV9pcnFzOyBpKyspCj4gKyAgICAg ICAgICAgICAgIGRkYXRhLT5pcnFzW2ldLm1hc2sgPSBCSVQoaSk7CgpJJ20gaGFwcHkgdG8gcmVz ZW5kIHdpdGggeW91ciBTdWdnZXN0ZWQtYnkuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNl bmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBP cGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sg fCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=