From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AADC433E0 for ; Mon, 29 Jun 2020 21:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C313F20775 for ; Mon, 29 Jun 2020 21:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593464833; bh=XGuWL52K+qAbtTA70o3IBFExy55ErqwDzLBqz/ZsfZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NSuquG2//jP5tCe7OoRFAgvxGsfEAmtJCxrIf6aFojit2o2pbApozGF6y4VnLeaUr Rk+svzPYAkCvDOtvZWdfbxDaLvbJEF9RKdFFK3JszYvr6ojaJvluaHsiy1CFnVFYtD 5QmcL2NVlOMugC6bmoLrD5heOSJO99NUgQQZOyPc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732895AbgF2VHM (ORCPT ); Mon, 29 Jun 2020 17:07:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:53756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730957AbgF2TKR (ORCPT ); Mon, 29 Jun 2020 15:10:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36503254CA; Mon, 29 Jun 2020 15:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446024; bh=XGuWL52K+qAbtTA70o3IBFExy55ErqwDzLBqz/ZsfZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gYubyoltP+z/2jeiqTfZXc7luL1gAvngx30Yt8wZHBjEFjxE5Yi3bXDB85Sp7Agmu AalogZ+EG9gc7aswzHzGU68E0JtAnN8Ps6T4O/Zpbf919Ws6FfLhBV2WDE5cpK8wgY Xkzueyn/VJmkHD1Vri5dkV2jDeGZXstBsxnFhv+0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tero Kristo , Tomi Valkeinen , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.4 030/135] clk: ti: composite: fix memory leak Date: Mon, 29 Jun 2020 11:51:24 -0400 Message-Id: <20200629155309.2495516-31-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit c7c1cbbc9217ebb5601b88d138d4a5358548de9d ] The parent_names is never released for a component clock definition, causing some memory leak. Fix by releasing it once it is no longer needed. Reported-by: Tomi Valkeinen Signed-off-by: Tero Kristo Link: https://lkml.kernel.org/r/20200429131341.4697-2-t-kristo@ti.com Acked-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/composite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/ti/composite.c b/drivers/clk/ti/composite.c index dbef218fe5ecd..14201c52b44bc 100644 --- a/drivers/clk/ti/composite.c +++ b/drivers/clk/ti/composite.c @@ -228,6 +228,7 @@ static void __init _register_composite(struct clk_hw *hw, if (!cclk->comp_clks[i]) continue; list_del(&cclk->comp_clks[i]->link); + kfree(cclk->comp_clks[i]->parent_names); kfree(cclk->comp_clks[i]); } -- 2.25.1