From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6D7C433E2 for ; Mon, 29 Jun 2020 18:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9071F20656 for ; Mon, 29 Jun 2020 18:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593456268; bh=+KOLxCmwsPTRAh+iG7nBvhdN9ELAStyx3yZ+DIpMSVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mslN2iDRYixzhhW7Hz1quQqfk8P1WtAt6l4OyGtkAAaFYi1nJSDkFU9/gElCklUWd 5ELNo8/cyHKoyItC+jHdGOvWM/OlBrp/oXeqXDesyxc/1LINU9Di1Dm0YdunLiGScG gjhpcVG9s52RZqaZkzP1e+pwtxvSvYWwMHh7yCWM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728118AbgF2So1 (ORCPT ); Mon, 29 Jun 2020 14:44:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:35134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbgF2So0 (ORCPT ); Mon, 29 Jun 2020 14:44:26 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26DD520775; Mon, 29 Jun 2020 18:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593456266; bh=+KOLxCmwsPTRAh+iG7nBvhdN9ELAStyx3yZ+DIpMSVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dJDIKMRCSLEvE0WirVlwv526I2ZGk7neXM71bgloPC2OjkB1QPSUU673s2YYwBV40 dFOqgJt44qETJs2ymoIBolyAitJBRF6/PPq0ha6wCyEDLoZNoYjKJlTun4mD7F76Pc q2uBGcwiSOVQdAcampa0BMCJJlVXHO+uWyoH+9AU= Date: Mon, 29 Jun 2020 11:44:24 -0700 From: Eric Biggers To: Satya Tangirala , Theodore Ts'o , Andreas Dilger Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2 4/4] ext4: add inline encryption support Message-ID: <20200629184424.GG20492@sol.localdomain> References: <20200629120405.701023-1-satyat@google.com> <20200629120405.701023-5-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200629120405.701023-5-satyat@google.com> Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Mon, Jun 29, 2020 at 12:04:05PM +0000, Satya Tangirala via Linux-f2fs-devel wrote: > From: Eric Biggers > > Wire up ext4 to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted files where it can be used. > > - Setting the bio_crypt_ctx on bios that will be submitted to an > inline-encrypted file. > > Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for > this part, since ext4 sometimes uses ll_rw_block() on file data. > > - Not adding logically discontiguous data to bios that will be submitted > to an inline-encrypted file. > > - Not doing filesystem-layer crypto on inline-encrypted files. > > Signed-off-by: Eric Biggers > Co-developed-by: Satya Tangirala > Signed-off-by: Satya Tangirala This patch looks good to me. (I can't technically provide Reviewed-by because I'm listed as the author.) Ted and Andreas, can you take a look? - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D62C433E2 for ; Mon, 29 Jun 2020 18:44:35 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FFF32063A; Mon, 29 Jun 2020 18:44:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="VpSQARki"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="K22Yj/AB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dJDIKMRC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FFF32063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jpyle-0001BV-27; Mon, 29 Jun 2020 18:44:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpylc-0001BO-QF for linux-f2fs-devel@lists.sourceforge.net; Mon, 29 Jun 2020 18:44:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KRf18WtwAkPtCTu4dzJ2yOaf6h91Tgp+rrao1RWQhN0=; b=VpSQARkiHqqDKZUc9703cD9U2b Z0g65Wqh1zJ7N3g/ME7ysv7T3WtBFRgjNiXqYslKAqnrXln039K7suDWDghThwvzmTgY9rR+br6aP fqhZsFlqPZkACjRztKr8KIq/u7AA1thn7HNrf5boR0q+xwblnhiI4pY+cvpkiDCIcsP8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KRf18WtwAkPtCTu4dzJ2yOaf6h91Tgp+rrao1RWQhN0=; b=K22Yj/ABFpXZjrENdj8PdXWZjx YR4lSnG4uqI4kkqLkfGOBc6CSm8JrpRUeJAjZW+sosJqWb+U5SCu6Bp1uzI7bBxXKVfr1fkX2cGea KDlXE9X+FbNUlYE6qfYn/WO31zVe64NsbA4is/efiUInvPSU/8iP0ISScFaHBM6ZGvAU=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jpylb-005HIm-NS for linux-f2fs-devel@lists.sourceforge.net; Mon, 29 Jun 2020 18:44:32 +0000 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26DD520775; Mon, 29 Jun 2020 18:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593456266; bh=+KOLxCmwsPTRAh+iG7nBvhdN9ELAStyx3yZ+DIpMSVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dJDIKMRCSLEvE0WirVlwv526I2ZGk7neXM71bgloPC2OjkB1QPSUU673s2YYwBV40 dFOqgJt44qETJs2ymoIBolyAitJBRF6/PPq0ha6wCyEDLoZNoYjKJlTun4mD7F76Pc q2uBGcwiSOVQdAcampa0BMCJJlVXHO+uWyoH+9AU= Date: Mon, 29 Jun 2020 11:44:24 -0700 From: Eric Biggers To: Satya Tangirala , Theodore Ts'o , Andreas Dilger Message-ID: <20200629184424.GG20492@sol.localdomain> References: <20200629120405.701023-1-satyat@google.com> <20200629120405.701023-5-satyat@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200629120405.701023-5-satyat@google.com> X-Headers-End: 1jpylb-005HIm-NS Subject: Re: [f2fs-dev] [PATCH v2 4/4] ext4: add inline encryption support X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Jun 29, 2020 at 12:04:05PM +0000, Satya Tangirala via Linux-f2fs-devel wrote: > From: Eric Biggers > > Wire up ext4 to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted files where it can be used. > > - Setting the bio_crypt_ctx on bios that will be submitted to an > inline-encrypted file. > > Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for > this part, since ext4 sometimes uses ll_rw_block() on file data. > > - Not adding logically discontiguous data to bios that will be submitted > to an inline-encrypted file. > > - Not doing filesystem-layer crypto on inline-encrypted files. > > Signed-off-by: Eric Biggers > Co-developed-by: Satya Tangirala > Signed-off-by: Satya Tangirala This patch looks good to me. (I can't technically provide Reviewed-by because I'm listed as the author.) Ted and Andreas, can you take a look? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel