From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/3] package/qemu: add spice support
Date: Mon, 29 Jun 2020 22:59:12 +0200 [thread overview]
Message-ID: <20200629225912.6934261e@windsurf> (raw)
In-Reply-To: <20200629205002.8087-1-jared.bents@rockwellcollins.com>
On Mon, 29 Jun 2020 15:50:00 -0500
Jared Bents <jared.bents@rockwellcollins.com> wrote:
> update to add qemu spice support
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
> package/qemu/Config.in | 9 +++++++++
> package/qemu/qemu.mk | 8 +++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> index 33d4cccd7b..3de73b69ec 100644
> --- a/package/qemu/Config.in
> +++ b/package/qemu/Config.in
> @@ -127,6 +127,15 @@ config BR2_PACKAGE_QEMU_SDL
> comment "SDL frontend needs a toolchain w/ dynamic library"
> depends on BR2_STATIC_LIBS
>
> +config BR2_PACKAGE_QEMU_SPICE
> + bool "Enable Spice frontend"
> + depends on BR2_PACKAGE_SPICE
I am wondering why for this one we are adding a sub-option and not
using automatic detection of BR2_PACKAGE_SPICE=y in the .mk file, like
you've done for VNC and usb-redir.
On the other hand, we do have already a bunch of sub-options to
configure Qemu. We're not very consistent here :/
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-29 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 20:50 [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
2020-06-29 20:50 ` [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support Jared Bents
2020-07-07 12:56 ` Romain Naour
2020-06-29 20:50 ` [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support Jared Bents
2020-07-07 13:37 ` Romain Naour
2020-06-29 20:59 ` Thomas Petazzoni [this message]
2020-06-29 21:05 ` [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
2020-07-07 13:30 ` Romain Naour
2020-07-13 21:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629225912.6934261e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.