From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A156C433DF for ; Tue, 30 Jun 2020 07:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5E2D206CB for ; Tue, 30 Jun 2020 07:42:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yqLdN9FS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731131AbgF3Hm3 (ORCPT ); Tue, 30 Jun 2020 03:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731090AbgF3Hm3 (ORCPT ); Tue, 30 Jun 2020 03:42:29 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEC05C061755 for ; Tue, 30 Jun 2020 00:42:28 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l2so17086839wmf.0 for ; Tue, 30 Jun 2020 00:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EbxmwuEjQQfl0DLnt0sNJ+F2kmsq43FibPJ5cYs3dqE=; b=yqLdN9FSFlc2kfZ0HaUeSh6+xZMoG7a9hzTaXM0IMMK5oWr68ppNQrgeClaW4VtRUD rFYlYSf6VHD56zsg9coVkWgeRcWacQzlqPnh/db28TtnLyJ8TpO7cot2Jp6WWPSnqj9V VKIQCL8OCCYRTJ21S8wEgG0mnhAkrxCUAdTtuj1Qra7KRs9FwPRqSTIpW1CYXVaMfG46 Y815eVv61K0j/7D463kGd6fefzG3ZSlikA0ypDPxzl8tWlCufEbnpnlBJhlIs7dwOFA6 ZD0+aXK4MYWSJmdqYHlONh1MTPhdc2VevfIjQLiHbpnjJrXZfpkUATo6S9GZ/a3axCg3 jivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EbxmwuEjQQfl0DLnt0sNJ+F2kmsq43FibPJ5cYs3dqE=; b=SMNTzIiiYcKLBd95PWaMwsN0CJw78yrnsnDTgyWBrU4MOIaQV3znkB6rF7Z5jcIULv b4Y6i2cbzz52FV6XQP3V4DRh2gG+38aaOyqZtBKZuWT1OrtHHsOsDPwkI0XHkk5IdTem YaLTRpt4Jji/LvdxIF7CNYk5Gm/OCxEujFBv3H9Dmw4g6LzohnaMJxJOzdxQV3u+8NN0 SKtSdfUWjvIGbAnJ4EPDJzkixj2xtbxPct/lRPHxADI+/4WWPkRZda8NIMOHcb7XVEhi ef7wCxBqV24FyvO2WHCQ+qADjaUTBw+NAiv3+jd0Ye/1VnbCcF+Ib5GfoOqOqGVCIgSl ii5g== X-Gm-Message-State: AOAM533vSP39UpQbS4LsPc9R5nxKtqnNJfBh0fn0qg48OMhm13b7QDf2 ELzYH3dUpHqUMnO7ciFnf7SnzA== X-Google-Smtp-Source: ABdhPJynBs/c9Tpp0cRBlrxHe3SOKjg30fkelhIJdotq3aQy3/38ta6zFfmNTfQnAoNndEXyGBNB4w== X-Received: by 2002:a05:600c:28d:: with SMTP id 13mr19908915wmk.30.1593502947403; Tue, 30 Jun 2020 00:42:27 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g3sm2848943wrb.46.2020.06.30.00.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 00:42:26 -0700 (PDT) Date: Tue, 30 Jun 2020 08:42:24 +0100 From: Lee Jones To: haver Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Jung , Michael Ruettger , Frank Haverkamp , Joerg-Stephan Vogt Subject: Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Message-ID: <20200630074224.GH1179328@dell> References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-17-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jun 2020, haver wrote: > On 2020-06-29 16:04, Lee Jones wrote: > > Variable 'rc' hasn't been checked since the driver's inception > > in 2013. If it hasn't caused any issues since then, it's unlikely > > to in the future. Let's take it out for now. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/misc/genwqe/card_base.c: In function > > ‘genwqe_health_check_stop’: > > > > /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6: > > warning: variable ‘rc’ set but not used > > [-Wunused-but-set-variable] > > 1046 | int rc; > > | ^~ > > > > Cc: Michael Jung > > Cc: Michael Ruettger > > Cc: Frank Haverkamp > > Cc: Joerg-Stephan Vogt > > Signed-off-by: Lee Jones > > --- > > drivers/misc/genwqe/card_base.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/misc/genwqe/card_base.c > > b/drivers/misc/genwqe/card_base.c > > index 1dc6c7c5cbce9..bceebf49de2d5 100644 > > --- a/drivers/misc/genwqe/card_base.c > > +++ b/drivers/misc/genwqe/card_base.c > > @@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct > > genwqe_dev *cd) > > > > static int genwqe_health_check_stop(struct genwqe_dev *cd) > > { > > - int rc; > > - > > if (!genwqe_health_thread_running(cd)) > > return -EIO; > > > > - rc = kthread_stop(cd->health_thread); > > + kthread_stop(cd->health_thread); > > cd->health_thread = NULL; > > return 0; > > } > > Good idea. Let's remove it Thanks for the contribution. No problem, and you are welcome. > Signed-off-by: Frank Haverkamp Just as an aside, this should be Acked-by, unless you either contributed to the patch directly or are in the delivery path i.e. you plan to pick the patch and send it to, say Linus, via a pull-request. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96667C433E0 for ; Tue, 30 Jun 2020 07:43:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59E53206CB for ; Tue, 30 Jun 2020 07:43:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="y4JGcDwM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yqLdN9FS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59E53206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vhIhQPoz98eHcKW/PDsFSVEQXs6VR86jicvuSB6YbPA=; b=y4JGcDwM4u5ISWwjigP2QbsSj jEVBUZAZjXFzdGBykZs8pNZQR23QbUVtYqOsDn27sdtILoEQirsh8dNTgmvGiqkCKVKsqbjU8tYan yTo5n6XQJyMlwRZCjb57BqVgOzevMRVRPWzK4Gqse8TTsi/0DxYpI6nSi+EkaqeOK63ultjvuZ9ID WT1aU2Spb+o1ZJx/grEZpdWmix2MhP2PlPdH4QXgbDshmvNFdROhfWGxGf6gq+vU2g49VTkxx7Z/C +HPBuBFfgTr8mglwOkpY8uO8ltcpMxi5aunIe2CY6zarqEWcGRvvtxI3UUZFdU8nnnDsVODMbJ9G3 DY/4qgA3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqAuW-0000UR-WE; Tue, 30 Jun 2020 07:42:33 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqAuT-0000Ts-Su for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 07:42:31 +0000 Received: by mail-wm1-x343.google.com with SMTP id g10so3904558wmc.1 for ; Tue, 30 Jun 2020 00:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EbxmwuEjQQfl0DLnt0sNJ+F2kmsq43FibPJ5cYs3dqE=; b=yqLdN9FSFlc2kfZ0HaUeSh6+xZMoG7a9hzTaXM0IMMK5oWr68ppNQrgeClaW4VtRUD rFYlYSf6VHD56zsg9coVkWgeRcWacQzlqPnh/db28TtnLyJ8TpO7cot2Jp6WWPSnqj9V VKIQCL8OCCYRTJ21S8wEgG0mnhAkrxCUAdTtuj1Qra7KRs9FwPRqSTIpW1CYXVaMfG46 Y815eVv61K0j/7D463kGd6fefzG3ZSlikA0ypDPxzl8tWlCufEbnpnlBJhlIs7dwOFA6 ZD0+aXK4MYWSJmdqYHlONh1MTPhdc2VevfIjQLiHbpnjJrXZfpkUATo6S9GZ/a3axCg3 jivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EbxmwuEjQQfl0DLnt0sNJ+F2kmsq43FibPJ5cYs3dqE=; b=sU9qU2G8ESGMj69Ks7ARBphLk85VWpCVNMpMf/kbrS1MKLhoKvwyM1nBOvmHC6aNAB 2DvrnVEwF0SGHJtUBc4NDsW7JtJxrckAGYeY4xBoW+L5Kbagm29yyhSBQwAENf6JLivP p5ONxbCC6op9XRVvaYednHJVijnOn9nLP+zH5HjL35wCiSUP6MuF6jYLWvBVuZFQ3MA/ pNkhwAsLM1h1MmBbhF5ApsWH7K7Qz1UhSpq2wMCXSIPTQ8O1+/TIp89WbqWlc3So9+3f ToQKY9ZCmbDDooXvrmEljLvXUWzR9NDZVqOXBAjdoHrTYQ2aAEvHnvEIrc1BN+YI+moh HIfg== X-Gm-Message-State: AOAM531HFm5J46CZm6K5Z/8vkvXyhgZek+CieA4XxU4N4tzp/N2jt5uN W+HnLW/6si7jbRjYc16+4aHE1GFByps= X-Google-Smtp-Source: ABdhPJynBs/c9Tpp0cRBlrxHe3SOKjg30fkelhIJdotq3aQy3/38ta6zFfmNTfQnAoNndEXyGBNB4w== X-Received: by 2002:a05:600c:28d:: with SMTP id 13mr19908915wmk.30.1593502947403; Tue, 30 Jun 2020 00:42:27 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g3sm2848943wrb.46.2020.06.30.00.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 00:42:26 -0700 (PDT) Date: Tue, 30 Jun 2020 08:42:24 +0100 From: Lee Jones To: haver Subject: Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Message-ID: <20200630074224.GH1179328@dell> References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-17-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , arnd@arndb.de, gregkh@linuxfoundation.org, Frank Haverkamp , Michael Jung , linux-kernel@vger.kernel.org, Michael Ruettger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAzMCBKdW4gMjAyMCwgaGF2ZXIgd3JvdGU6Cgo+IE9uIDIwMjAtMDYtMjkgMTY6MDQs IExlZSBKb25lcyB3cm90ZToKPiA+IFZhcmlhYmxlICdyYycgaGFzbid0IGJlZW4gY2hlY2tlZCBz aW5jZSB0aGUgZHJpdmVyJ3MgaW5jZXB0aW9uCj4gPiBpbiAyMDEzLiAgSWYgaXQgaGFzbid0IGNh dXNlZCBhbnkgaXNzdWVzIHNpbmNlIHRoZW4sIGl0J3MgdW5saWtlbHkKPiA+IHRvIGluIHRoZSBm dXR1cmUuICBMZXQncyB0YWtlIGl0IG91dCBmb3Igbm93Lgo+ID4gCj4gPiBGaXhlcyB0aGUgZm9s bG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiA+IAo+ID4gIGRyaXZlcnMvbWlz Yy9nZW53cWUvY2FyZF9iYXNlLmM6IEluIGZ1bmN0aW9uCj4gPiDigJhnZW53cWVfaGVhbHRoX2No ZWNrX3N0b3DigJk6Cj4gPiAKPiA+IC9ob21lL2xlZS9wcm9qZWN0cy9saW51eC9rZXJuZWwvZHJp dmVycy9taXNjL2dlbndxZS9jYXJkX2Jhc2UuYzoxMDQ2OjY6Cj4gPiB3YXJuaW5nOiB2YXJpYWJs ZSDigJhyY+KAmSBzZXQgYnV0IG5vdCB1c2VkCj4gPiBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJs ZV0KPiA+ICAxMDQ2IHwgaW50IHJjOwo+ID4gIHwgXn4KPiA+IAo+ID4gQ2M6IE1pY2hhZWwgSnVu ZyA8bWlqdW5nQGdteC5uZXQ+Cj4gPiBDYzogTWljaGFlbCBSdWV0dGdlciA8bWljaGFlbEBpYm1y YS5kZT4KPiA+IENjOiBGcmFuayBIYXZlcmthbXAgPGhhdmVyQGxpbnV4LmlibS5jb20+Cj4gPiBD YzogSm9lcmctU3RlcGhhbiBWb2d0IDxqc3ZvZ3RAZGUuaWJtLmNvbT4KPiA+IFNpZ25lZC1vZmYt Ynk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L21pc2MvZ2Vud3FlL2NhcmRfYmFzZS5jIHwgNCArLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9taXNjL2dlbndxZS9jYXJkX2Jhc2UuYwo+ID4gYi9kcml2ZXJzL21pc2MvZ2Vud3FlL2NhcmRf YmFzZS5jCj4gPiBpbmRleCAxZGM2YzdjNWNiY2U5Li5iY2VlYmY0OWRlMmQ1IDEwMDY0NAo+ID4g LS0tIGEvZHJpdmVycy9taXNjL2dlbndxZS9jYXJkX2Jhc2UuYwo+ID4gKysrIGIvZHJpdmVycy9t aXNjL2dlbndxZS9jYXJkX2Jhc2UuYwo+ID4gQEAgLTEwNDMsMTIgKzEwNDMsMTAgQEAgc3RhdGlj IGludCBnZW53cWVfaGVhbHRoX3RocmVhZF9ydW5uaW5nKHN0cnVjdAo+ID4gZ2Vud3FlX2RldiAq Y2QpCj4gPiAKPiA+ICBzdGF0aWMgaW50IGdlbndxZV9oZWFsdGhfY2hlY2tfc3RvcChzdHJ1Y3Qg Z2Vud3FlX2RldiAqY2QpCj4gPiAgewo+ID4gLQlpbnQgcmM7Cj4gPiAtCj4gPiAgCWlmICghZ2Vu d3FlX2hlYWx0aF90aHJlYWRfcnVubmluZyhjZCkpCj4gPiAgCQlyZXR1cm4gLUVJTzsKPiA+IAo+ ID4gLQlyYyA9IGt0aHJlYWRfc3RvcChjZC0+aGVhbHRoX3RocmVhZCk7Cj4gPiArCWt0aHJlYWRf c3RvcChjZC0+aGVhbHRoX3RocmVhZCk7Cj4gPiAgCWNkLT5oZWFsdGhfdGhyZWFkID0gTlVMTDsK PiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+IAo+IEdvb2QgaWRlYS4gTGV0J3MgcmVtb3ZlIGl0IFRo YW5rcyBmb3IgdGhlIGNvbnRyaWJ1dGlvbi4KCk5vIHByb2JsZW0sIGFuZCB5b3UgYXJlIHdlbGNv bWUuCgo+IFNpZ25lZC1vZmYtYnk6IEZyYW5rIEhhdmVya2FtcCA8aGF2ZXJAbGludXguaWJtLmNv bT4KCkp1c3QgYXMgYW4gYXNpZGUsIHRoaXMgc2hvdWxkIGJlIEFja2VkLWJ5LCB1bmxlc3MgeW91 IGVpdGhlcgpjb250cmlidXRlZCB0byB0aGUgcGF0Y2ggZGlyZWN0bHkgb3IgYXJlIGluIHRoZSBk ZWxpdmVyeSBwYXRoIGkuZS4geW91CnBsYW4gdG8gcGljayB0aGUgcGF0Y2ggYW5kIHNlbmQgaXQg dG8sIHNheSBMaW51cywgdmlhIGEgcHVsbC1yZXF1ZXN0LgoKLS0gCkxlZSBKb25lcyBb5p2O55C8 5pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9y ZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZh Y2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK