All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@mellanox.com>
To: Alaa Hleihel <alaa@mellanox.com>
Cc: jgg@mellanox.com, linux-rdma@vger.kernel.org,
	Edward Srouji <edwards@mellanox.com>,
	Honggang Li <honli@redhat.com>
Subject: Re: [PATCH rdma-core] redhat: Fix the condition for pyverbs enablement on Fedora 32 and up
Date: Tue, 30 Jun 2020 13:31:29 +0300	[thread overview]
Message-ID: <20200630103129.GF17857@unreal> (raw)
In-Reply-To: <20200628145003.13705-1-alaa@mellanox.com>

On Sun, Jun 28, 2020 at 05:50:03PM +0300, Alaa Hleihel wrote:
> The cited commit enabled pyverbs build by default for Fedora 32 and up.
> However, it broke enalbing pyverbs build when passing '--with pyverbs' flag.
>
> Fix the condition so that now the behavior for Fedora 32 and up will be:
>  * Default: pyverbs enabled.
>  * --with pyverbs: pyverbs enabled.
>  * --without pyverbs: pyverbs disabled.
>
> Fixes: 07b304b75186 ("redhat: Build pyverbs for Fedora greater than release 31")
> Signed-off-by: Alaa Hleihel <alaa@mellanox.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> Tested-by: Edward Srouji <edwards@mellanox.com>
> CC: Honggang Li <honli@redhat.com>
> ---
>  redhat/rdma-core.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


I'll wait for the results of this PR and merge it.
https://github.com/linux-rdma/rdma-core/pull/784

Thanks

      parent reply	other threads:[~2020-06-30 10:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 14:50 [PATCH rdma-core] redhat: Fix the condition for pyverbs enablement on Fedora 32 and up Alaa Hleihel
2020-06-29 10:58 ` Honggang LI
2020-06-30 10:31 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200630103129.GF17857@unreal \
    --to=leonro@mellanox.com \
    --cc=alaa@mellanox.com \
    --cc=edwards@mellanox.com \
    --cc=honli@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.