From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394E9C433DF for ; Tue, 30 Jun 2020 12:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B87020774 for ; Tue, 30 Jun 2020 12:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593519236; bh=F02qHmmLoyKU3NlCqf/heEhvUxmk+Z5U/MXoDWHciHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BjMMdZHYs7Uh3nzi3VyDPIsIav3M98ZjP35SV0wQwLZBjKzs5gbsjOnAJv+YCmaGL XYEyq+0KAkhNxHOT0iXF8pgKmhKZnKva80G3aQajm3X8GOWd0LUYjHYI5/tjyGQ/78 9Rv1Hvk8VvCCmBbDQ3ltzUP/6dJF67Bve32RobpY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387508AbgF3MNz (ORCPT ); Tue, 30 Jun 2020 08:13:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:60436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387472AbgF3MNz (ORCPT ); Tue, 30 Jun 2020 08:13:55 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE92B2073E; Tue, 30 Jun 2020 12:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593519234; bh=F02qHmmLoyKU3NlCqf/heEhvUxmk+Z5U/MXoDWHciHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lvwYfGx8bfBi+X8FB9R4C7HqTAFjHH9qXyBZz9lizc9J7emeV06HrUDCKYYbtuWc5 PNV/HktE6ZW8e85TB8ul6UCD/7gNGHuQssRNnrsKIRZXUQPck2oIvtOybahTPm1e1C PxAPAYHOxAnFDv9cyQZAaX2W6zdzlMPI/15IdZrk= Date: Tue, 30 Jun 2020 15:13:51 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org, Yishai Hadas Subject: Re: [PATCH rdma-next 5/5] RDMA/core: Convert RWQ table logic to ib_core allocation scheme Message-ID: <20200630121351.GI17857@unreal> References: <20200624105422.1452290-1-leon@kernel.org> <20200624105422.1452290-6-leon@kernel.org> <20200629153907.GA269101@nvidia.com> <20200630072137.GC17857@unreal> <20200630113729.GC23676@nvidia.com> <20200630115224.GH17857@unreal> <20200630120630.GD23676@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200630120630.GD23676@nvidia.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jun 30, 2020 at 09:06:30AM -0300, Jason Gunthorpe wrote: > On Tue, Jun 30, 2020 at 02:52:24PM +0300, Leon Romanovsky wrote: > > On Tue, Jun 30, 2020 at 08:37:29AM -0300, Jason Gunthorpe wrote: > > > On Tue, Jun 30, 2020 at 10:21:37AM +0300, Leon Romanovsky wrote: > > > > On Mon, Jun 29, 2020 at 12:39:07PM -0300, Jason Gunthorpe wrote: > > > > > On Wed, Jun 24, 2020 at 01:54:22PM +0300, Leon Romanovsky wrote: > > > > > > @@ -4018,8 +4028,7 @@ const struct uapi_definition uverbs_def_write_intf[] = { > > > > > > IB_USER_VERBS_EX_CMD_DESTROY_RWQ_IND_TBL, > > > > > > ib_uverbs_ex_destroy_rwq_ind_table, > > > > > > UAPI_DEF_WRITE_I( > > > > > > - struct ib_uverbs_ex_destroy_rwq_ind_table), > > > > > > - UAPI_DEF_METHOD_NEEDS_FN(destroy_rwq_ind_table))), > > > > > > + struct ib_uverbs_ex_destroy_rwq_ind_table))), > > > > > > > > > > Removing these is kind of troublesome.. This misses the one for ioctl: > > > > > > > > > > UAPI_DEF_CHAIN_OBJ_TREE_NAMED( > > > > > UVERBS_OBJECT_RWQ_IND_TBL, > > > > > UAPI_DEF_OBJ_NEEDS_FN(destroy_rwq_ind_table)), > > > > > > > > I will remove, but it seems that we have some gap here, I would expect > > > > any sort of compilation error for mlx4. > > > > > > Why would there be a compilation error? > > > > I would expect BUILD_BUG_ON_ZERO() is thrown if ibdev_fn == NULL > > ?? > > > > And it should not be removed, it needs to be reworked to point to some > > > other function I suppose. > > > > Why? > > The destroy function should not be registered at all if rwq_ind is not > supported by the driver - this is the methodlogy. And here comes mlx4 case that needs create() call but doesn't need destroy(), because it will be empty after this refactoring. Thanks > > Jason