From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D500C433E0 for ; Tue, 30 Jun 2020 13:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BFAD206BE for ; Tue, 30 Jun 2020 13:51:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VkzyBtZb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388489AbgF3Nvu (ORCPT ); Tue, 30 Jun 2020 09:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388407AbgF3Nv0 (ORCPT ); Tue, 30 Jun 2020 09:51:26 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080FAC03E97A for ; Tue, 30 Jun 2020 06:51:26 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o8so18897529wmh.4 for ; Tue, 30 Jun 2020 06:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=VkzyBtZbCjJJvhPGehZwLMGCthflX3/XiLaEsXmprAcJVpo80+gSoG8rwFsE+weyh4 ktuEsHJwHeeliHVIBqZbZHfxKTIhxooQjcRWF/IRKDYzwE0+BxanVd9NYSfhyIWiG53s tCxie/X8WcL0U9Vj/0ZNtTRsbOsvDazA5kboXlz+kHELQbXY/ZUAToaYVXd5H8spQ0Ou rwE4U1QYKcOnU7H3cbJIWJX1fKQ2wKeHi3V0r0eQQ4rkLM4VTLOYwWKNhDeT+4tOUam6 RIuizvWzQw2rQii5W+le77E6a2DZZCX6R8CQv+5LcI3fDCgBy3EW/p2Aahnk/Ui+KABm 1nyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=o6/d9iUzbbr4lXey7p1jQ/o8koMTYyAIfN+Zyaiwfn6ofmNpupcXKhbIni1891/WDN o0wEl0FZu3nmN81Wc+rbH7RJSZxomIECwqVVe+h+rokWCqkdyGEuXhjqJOAWqAcWa+Ux lr/uzQDaSNSYA/b7vvuLerBOsa4SydWffVsQn2CsiJ/2fxiLbHOODIB2mbu+m95Q7P9F cQ52w2vzzfjHqz0D5ElE93fdbfjW1VXgwdTFFjwd6yzr4Lcg5e3Etp4CaxyJZ/CBUjzE G2XFC3AZs9QvuxcWmnzh+FcVkcAwaroJLqlxY1eHRbuaah73hipejjAaBiV78jn+9eaU iuxw== X-Gm-Message-State: AOAM531Ag69ZzXFk8dw8/W1PNdvVirVshoepK4a/obKZGRYT6UvRDDjV VTPf85r+1oyy5kKNnwiOdnTYqQ== X-Google-Smtp-Source: ABdhPJzXnmpgLmFJj/trdGQhzlz4Fmuvb3Xl3DNNCpx4ncsMeB/kuKfjKKh6mqpcjRvSFV0zFJrmIA== X-Received: by 2002:a1c:1b90:: with SMTP id b138mr21474519wmb.21.1593525084780; Tue, 30 Jun 2020 06:51:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:24 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , =?UTF-8?q?Max=20Asb=C3=B6ck?= Subject: [PATCH 10/30] misc: ibmasm: dot_command: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:50 +0100 Message-Id: <20200630135110.2236389-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'sp' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'message' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'message_size' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:55: warning: Function parameter or member 'sp' not described in 'ibmasm_send_driver_vpd' drivers/misc/ibmasm/dot_command.c:111: warning: Function parameter or member 'sp' not described in 'ibmasm_send_os_state' drivers/misc/ibmasm/dot_command.c:111: warning: Function parameter or member 'os_state' not described in 'ibmasm_send_os_state' Cc: "Max Asböck" Signed-off-by: Lee Jones --- drivers/misc/ibmasm/dot_command.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/ibmasm/dot_command.c b/drivers/misc/ibmasm/dot_command.c index 70273a4cb3527..df389bd4c9df7 100644 --- a/drivers/misc/ibmasm/dot_command.c +++ b/drivers/misc/ibmasm/dot_command.c @@ -10,7 +10,7 @@ #include "ibmasm.h" #include "dot_command.h" -/** +/* * Dispatch an incoming message to the specific handler for the message. * Called from interrupt context. */ @@ -48,7 +48,7 @@ void ibmasm_receive_message(struct service_processor *sp, void *message, int mes #define INIT_BUFFER_SIZE 32 -/** +/* * send the 4.3.5.10 dot command (driver VPD) to the service processor */ int ibmasm_send_driver_vpd(struct service_processor *sp) @@ -99,7 +99,7 @@ struct os_state_command { unsigned char data; }; -/** +/* * send the 4.3.6 dot command (os state) to the service processor * During driver init this function is called with os state "up". * This causes the service processor to start sending heartbeats the -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D10C433E0 for ; Tue, 30 Jun 2020 13:54:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4859020722 for ; Tue, 30 Jun 2020 13:54:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EljwqrGh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VkzyBtZb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4859020722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JOidiDZ+fPHfCIwM0clJF+GUACk8ExqtmENxjri/DuQ=; b=EljwqrGhz7+XXccbxa5Xhi2zl OLDTmetw33yljkuQ0D1wXzssfEm2Uq79vmnoMlpXZCGEuaKc/Pu5tD0jo1rasYHjp8izAO0dIB1Eq 1yImaw/ms/XfjttLi0MqF8NEEgdRkdFvISV365YWiVIMdp4Anve86COXPHYvsGvijMc8ouoNdYKuK n/iEFXUopDqz36wVFkf5eMQI/yRi4WGeZsTZJIZkq1TQZ08/eAAag/D6wiYNODj1OfpwhSA8kquMy MylLU9xhSWzWPGtWXPptjr5cNTrUoeAS02ZfFelKjLW9fMsVX5yA3vXDpPbEI5de7EH7IFAov94R7 r5AjX/AcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGh7-0001sw-Fs; Tue, 30 Jun 2020 13:53:05 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfV-0001Db-VH for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:29 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so19674437wmf.5 for ; Tue, 30 Jun 2020 06:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=VkzyBtZbCjJJvhPGehZwLMGCthflX3/XiLaEsXmprAcJVpo80+gSoG8rwFsE+weyh4 ktuEsHJwHeeliHVIBqZbZHfxKTIhxooQjcRWF/IRKDYzwE0+BxanVd9NYSfhyIWiG53s tCxie/X8WcL0U9Vj/0ZNtTRsbOsvDazA5kboXlz+kHELQbXY/ZUAToaYVXd5H8spQ0Ou rwE4U1QYKcOnU7H3cbJIWJX1fKQ2wKeHi3V0r0eQQ4rkLM4VTLOYwWKNhDeT+4tOUam6 RIuizvWzQw2rQii5W+le77E6a2DZZCX6R8CQv+5LcI3fDCgBy3EW/p2Aahnk/Ui+KABm 1nyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=qQmPcCgOsEYjFrabwfp2NwqfQNPmoLIYGVOLEIX6snuoeErucRCJ9xlv9a/l3SFSK1 CiGqYYqPgGK952+MozcQlwY6TmphKG5u++aSl6d/ST7/NrpePvTvIuK14mjKney1WuHz F5FKkwT8U/PAOCGj6e5xq5REdxpME7QGsNE4eX1TKIy4u5iqty9D5xiuVpY65nAbp1gc fea8Aqrd+S6e0ukv/HLc4FTWYsMhJ7nBV2dQl1t2BuChPZ7S4CdOGcXhTFmnsfL15bOw aa4KycZQcOfsVTy7Nf1iytvMWRhlQgd5i2Et+qbtd30TUFRLmfW3L4z7y5mEbv4QzBHt yrnQ== X-Gm-Message-State: AOAM530k4KQHesnutLdzvBUK5ShZRAlB8W2pmWm60e83EfgM2MAtJKUR PHjfUy8geqFKG4HvZ9TFLWGk2A== X-Google-Smtp-Source: ABdhPJzXnmpgLmFJj/trdGQhzlz4Fmuvb3Xl3DNNCpx4ncsMeB/kuKfjKKh6mqpcjRvSFV0zFJrmIA== X-Received: by 2002:a1c:1b90:: with SMTP id b138mr21474519wmb.21.1593525084780; Tue, 30 Jun 2020 06:51:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:24 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 10/30] misc: ibmasm: dot_command: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:50 +0100 Message-Id: <20200630135110.2236389-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Max=20Asb=C3=B6ck?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIGNvcnJlY3QgZm9ybWF0IGlzIG5vdCB1c2VkIGFuZCBubyBhdHRlbXB0IGhhcyBiZWVuIG1h ZGUKdG8gZG9jdW1lbnQgdGhlIGZ1bmN0aW9uIGFyZ3VtZW50cy4gIE1ha2VzIHNlbnNlIHRvIGp1 c3QgZGVtb3RlCnRoZSBoZWFkZXIgYmFjayBkb3duIHRvIGEgc2ltcGxlIGNvbW1lbnQuCgpGaXhl cyB0aGUgZm9sbG93aW5nIFc9MSB3YXJuaW5nczoKCiBkcml2ZXJzL21pc2MvaWJtYXNtL2RvdF9j b21tYW5kLmM6MTg6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ3NwJyBu b3QgZGVzY3JpYmVkIGluICdpYm1hc21fcmVjZWl2ZV9tZXNzYWdlJwogZHJpdmVycy9taXNjL2li bWFzbS9kb3RfY29tbWFuZC5jOjE4OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVt YmVyICdtZXNzYWdlJyBub3QgZGVzY3JpYmVkIGluICdpYm1hc21fcmVjZWl2ZV9tZXNzYWdlJwog ZHJpdmVycy9taXNjL2libWFzbS9kb3RfY29tbWFuZC5jOjE4OiB3YXJuaW5nOiBGdW5jdGlvbiBw YXJhbWV0ZXIgb3IgbWVtYmVyICdtZXNzYWdlX3NpemUnIG5vdCBkZXNjcmliZWQgaW4gJ2libWFz bV9yZWNlaXZlX21lc3NhZ2UnCiBkcml2ZXJzL21pc2MvaWJtYXNtL2RvdF9jb21tYW5kLmM6NTU6 IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ3NwJyBub3QgZGVzY3JpYmVk IGluICdpYm1hc21fc2VuZF9kcml2ZXJfdnBkJwogZHJpdmVycy9taXNjL2libWFzbS9kb3RfY29t bWFuZC5jOjExMTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnc3AnIG5v dCBkZXNjcmliZWQgaW4gJ2libWFzbV9zZW5kX29zX3N0YXRlJwogZHJpdmVycy9taXNjL2libWFz bS9kb3RfY29tbWFuZC5jOjExMTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJl ciAnb3Nfc3RhdGUnIG5vdCBkZXNjcmliZWQgaW4gJ2libWFzbV9zZW5kX29zX3N0YXRlJwoKQ2M6 ICJNYXggQXNiw7ZjayIgPGFtYXhAdXMuaWJtLmNvbT4KU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVz IDxsZWUuam9uZXNAbGluYXJvLm9yZz4KLS0tCiBkcml2ZXJzL21pc2MvaWJtYXNtL2RvdF9jb21t YW5kLmMgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL21pc2MvaWJtYXNtL2RvdF9jb21tYW5kLmMg Yi9kcml2ZXJzL21pc2MvaWJtYXNtL2RvdF9jb21tYW5kLmMKaW5kZXggNzAyNzNhNGNiMzUyNy4u ZGYzODliZDRjOWRmNyAxMDA2NDQKLS0tIGEvZHJpdmVycy9taXNjL2libWFzbS9kb3RfY29tbWFu ZC5jCisrKyBiL2RyaXZlcnMvbWlzYy9pYm1hc20vZG90X2NvbW1hbmQuYwpAQCAtMTAsNyArMTAs NyBAQAogI2luY2x1ZGUgImlibWFzbS5oIgogI2luY2x1ZGUgImRvdF9jb21tYW5kLmgiCiAKLS8q KgorLyoKICAqIERpc3BhdGNoIGFuIGluY29taW5nIG1lc3NhZ2UgdG8gdGhlIHNwZWNpZmljIGhh bmRsZXIgZm9yIHRoZSBtZXNzYWdlLgogICogQ2FsbGVkIGZyb20gaW50ZXJydXB0IGNvbnRleHQu CiAgKi8KQEAgLTQ4LDcgKzQ4LDcgQEAgdm9pZCBpYm1hc21fcmVjZWl2ZV9tZXNzYWdlKHN0cnVj dCBzZXJ2aWNlX3Byb2Nlc3NvciAqc3AsIHZvaWQgKm1lc3NhZ2UsIGludCBtZXMKICNkZWZpbmUg SU5JVF9CVUZGRVJfU0laRSAzMgogCiAKLS8qKgorLyoKICAqIHNlbmQgdGhlIDQuMy41LjEwIGRv dCBjb21tYW5kIChkcml2ZXIgVlBEKSB0byB0aGUgc2VydmljZSBwcm9jZXNzb3IKICAqLwogaW50 IGlibWFzbV9zZW5kX2RyaXZlcl92cGQoc3RydWN0IHNlcnZpY2VfcHJvY2Vzc29yICpzcCkKQEAg LTk5LDcgKzk5LDcgQEAgc3RydWN0IG9zX3N0YXRlX2NvbW1hbmQgewogCXVuc2lnbmVkIGNoYXIJ CQlkYXRhOwogfTsKIAotLyoqCisvKgogICogc2VuZCB0aGUgNC4zLjYgZG90IGNvbW1hbmQgKG9z IHN0YXRlKSB0byB0aGUgc2VydmljZSBwcm9jZXNzb3IKICAqIER1cmluZyBkcml2ZXIgaW5pdCB0 aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB3aXRoIG9zIHN0YXRlICJ1cCIuCiAgKiBUaGlzIGNhdXNl cyB0aGUgc2VydmljZSBwcm9jZXNzb3IgdG8gc3RhcnQgc2VuZGluZyBoZWFydGJlYXRzIHRoZQot LSAKMi4yNS4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=