From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1C6C433E0 for ; Tue, 30 Jun 2020 14:00:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E7CE206BE for ; Tue, 30 Jun 2020 14:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DPw3BIis" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388576AbgF3OAq (ORCPT ); Tue, 30 Jun 2020 10:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728808AbgF3OAo (ORCPT ); Tue, 30 Jun 2020 10:00:44 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 768A2C03E979 for ; Tue, 30 Jun 2020 07:00:44 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id a6so20318238wrm.4 for ; Tue, 30 Jun 2020 07:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=azJ5/+1T/5WlBvvDNzOL+HKFyrTPeN5+4fQ9+NwyQ6Q=; b=DPw3BIisvTLr4bdylP1hsEUiTYSusQMtKIASSVoN5oseJRJ0oxrxzra8CiVOo3xlQm 6HXe6HeRS03z9c0A+yQkeFn/vfuHA6DE9VBYgNPTdRRvKVZ4rAS9gowke7aHVDPL/K0f NfzjJBZohbFU8LTE1llSW0LPGqR/qN8SjyWGcxMzvb33ok8XNnZAI5bhFkwbZPIon5NP 8Hmu6k0EeF48f1SirkZX+Aqi3esW/cTTrSb6ZJ69kEjUamkJJaHTwZG8i/laMWkQ+45s 0CusblQF5lmIjZPZGqU8VHkBjtFoetRQ1EL7Lw7FKlRJEDmaxUpalMgzHP73yhaICYhw j+SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=azJ5/+1T/5WlBvvDNzOL+HKFyrTPeN5+4fQ9+NwyQ6Q=; b=fwT0JnsFHEx0/mJpKgT3swBicBS7v8dm1cQTXc3KvHNx1JMiqPxY39sD8PbnjHzZBC +0bSQ1fE3MtMA+4tGzrPV+GQtYHM+7WXT/MKSPsAHlluW2wb1z/Nz1iuhJnWKE7TU4Ee nSm/xAqL/UJS7aSWGNDEMMe57V0qRt6FB5AGpwRg1GFo9W8ynLc5NHPo27qy/vVdEWGg yz8xZ3+XcNoL9K5/ag0U3Y7GSlhLv2FtuEuEylGEvm9FdGToy5q0YUn7OvWznJP3ZGWM 6cYpnv195Y/Pr+9b1zpRatKer1v1LSpnU4pCHkciefs3mnR49oXtDHRIYItQ0nVtwnxX F2jg== X-Gm-Message-State: AOAM531F1c3IDBfHTxvXZ+xVoVdY6PiNwQykCjq4Beuob9PMtKeBiE45 +vYyEe0XqcaGMl0lPTiipU8tAQ== X-Google-Smtp-Source: ABdhPJx0b6XZVAYnbtoMnu2qgJzXxG+B7rCo7HyI4am/omrC2rLYGqbNbkHoy1PETImZJeeKD1v6Fw== X-Received: by 2002:adf:e2c9:: with SMTP id d9mr21780992wrj.227.1593525642488; Tue, 30 Jun 2020 07:00:42 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id n16sm3647457wra.19.2020.06.30.07.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 07:00:41 -0700 (PDT) Date: Tue, 30 Jun 2020 15:00:38 +0100 From: Lee Jones To: haver Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Jung , Michael Ruettger , Frank Haverkamp , Joerg-Stephan Vogt Subject: Re: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err' Message-ID: <20200630140038.GN1179328@dell> References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-18-lee.jones@linaro.org> <016718c7218cf811897cc32cf9476222@linux.vnet.ibm.com> <20200630091020.GJ1179328@dell> <235f96392b5a2f06b4410e9532b1322b@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <235f96392b5a2f06b4410e9532b1322b@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jun 2020, haver wrote: > On 2020-06-30 11:10, Lee Jones wrote: > > On Tue, 30 Jun 2020, haver wrote: > > > > > On 2020-06-29 16:04, Lee Jones wrote: > > > > 'fatal_err' is taken as an argument to a static function which is only > > > > invoked once. During this invocation 'fatal_err' is not set. There > > > > doesn't appear to be a good reason to keep it around. > > > > > > > > Also fixes the following W=1 kernel build warning: > > > > > > > > drivers/misc/genwqe/card_base.c:588: warning: Function parameter or > > > > member 'fatal_err' not described in 'genwqe_recover_card' > > > > > > > > Cc: Michael Jung > > > > Cc: Michael Ruettger > > > > Cc: Frank Haverkamp > > > > Cc: Joerg-Stephan Vogt > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/misc/genwqe/card_base.c | 18 +++--------------- > > > > 1 file changed, 3 insertions(+), 15 deletions(-) > > > > > > > > diff --git a/drivers/misc/genwqe/card_base.c > > > > b/drivers/misc/genwqe/card_base.c > > > > index bceebf49de2d5..809a6f46f6de3 100644 > > > > --- a/drivers/misc/genwqe/card_base.c > > > > +++ b/drivers/misc/genwqe/card_base.c > > > > @@ -569,30 +569,18 @@ static int genwqe_stop(struct genwqe_dev *cd) > > > > > > > > /** > > > > * genwqe_recover_card() - Try to recover the card if it is possible > > > > - * > > > > - * If fatal_err is set no register access is possible anymore. It is > > > > - * likely that genwqe_start fails in that situation. Proper error > > > > - * handling is required in this case. > > > > + * @cd: GenWQE device information > > > > * > > > > * genwqe_bus_reset() will cause the pci code to call genwqe_remove() > > > > * and later genwqe_probe() for all virtual functions. > > > > */ > > > > -static int genwqe_recover_card(struct genwqe_dev *cd, int fatal_err) > > > > +static int genwqe_recover_card(struct genwqe_dev *cd) > > > > { > > > > int rc; > > > > struct pci_dev *pci_dev = cd->pci_dev; > > > > > > > > genwqe_stop(cd); > > > > > > > > - /* > > > > - * Make sure chip is not reloaded to maintain FFDC. Write SLU > > > > - * Reset Register, CPLDReset field to 0. > > > > - */ > > > > - if (!fatal_err) { > > > > - cd->softreset = 0x70ull; > > > > - __genwqe_writeq(cd, IO_SLC_CFGREG_SOFTRESET, cd->softreset); > > > > - } > > > > - > > > > rc = genwqe_bus_reset(cd); > > > > if (rc != 0) { > > > > dev_err(&pci_dev->dev, > > > > @@ -958,7 +946,7 @@ static int genwqe_health_thread(void *data) > > > > > > > > cd->card_state = GENWQE_CARD_FATAL_ERROR; > > > > > > > > - rc = genwqe_recover_card(cd, 0); > > > > + rc = genwqe_recover_card(cd); > > > > if (rc < 0) { > > > > /* FIXME Card is unusable and needs unbind! */ > > > > goto fatal_error; > > > > > > I think this one I want to keep. Since fatal_err is 0, !fatal_error > > > is 1 and > > > the register write is actually executed. > > > > Ah yes, good catch. > > > > What if we *always* did instead then? > > I knew you would ask that ;-). > > > > > > I also want to keep the parameter even though it is only used with > > > 0. The > > > register bit causes a less drastic recovery, but if we would > > > discover that > > > that is not working ok, we rather discard the debug data we get in > > > this case > > > instead of letting the recovery fail. I think it does not hurt to > > > keep it. > > > > I'm not 100% against it, but it is dead code. > > > > > Maybe you can add a comment? > > > > If you really want to keep it, I can just update the kerneldoc > > instead. > > I prefer that option. I want to indicate that there are two possible ways to > recover on a problem. If we delete the currently not exploited parameter, > this information gets lost. That's fine. Will fix. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C902C433DF for ; Tue, 30 Jun 2020 14:05:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC9AA2063A for ; Tue, 30 Jun 2020 14:05:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0WrQts2N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DPw3BIis" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC9AA2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bt1hf1Ne+9OVwD33EDrijfxl4tXoRR3D2jN21P/UIbY=; b=0WrQts2NM18/jfCKybGTQJacu Hm6ep9tWciMAuqPQziB7o/hEd8ONT9mWiWfSeglAyuczaX65Oy9XOpItrRrQoWMafPswEPhP5Tqx+ X4Jn2YG/4dHhtBboQ2C+4jBlMDhWSYajgewBz79URZamD9/eFES+MDq2+FqYq6iDdbw48IpiN2I0C 8W3tqe5hbwLFDeJFaLnJWpFc+0ELB3LvYpFQbYDAPzuU6wKrJYVKmqM04c3gI2K7bXUpe9Z8FfwiQ 41Ano9a5EW1im4N5EwoGcN+RK+K/9l8n3iSjMfwnP/IL7PLCXXn6La3zc1ysMICWiKCFK5nGFRzhJ xxNq9WC9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGrF-0007av-FY; Tue, 30 Jun 2020 14:03:33 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGoW-0006Cp-A0 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 14:00:47 +0000 Received: by mail-wr1-x442.google.com with SMTP id g18so20355717wrm.2 for ; Tue, 30 Jun 2020 07:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=azJ5/+1T/5WlBvvDNzOL+HKFyrTPeN5+4fQ9+NwyQ6Q=; b=DPw3BIisvTLr4bdylP1hsEUiTYSusQMtKIASSVoN5oseJRJ0oxrxzra8CiVOo3xlQm 6HXe6HeRS03z9c0A+yQkeFn/vfuHA6DE9VBYgNPTdRRvKVZ4rAS9gowke7aHVDPL/K0f NfzjJBZohbFU8LTE1llSW0LPGqR/qN8SjyWGcxMzvb33ok8XNnZAI5bhFkwbZPIon5NP 8Hmu6k0EeF48f1SirkZX+Aqi3esW/cTTrSb6ZJ69kEjUamkJJaHTwZG8i/laMWkQ+45s 0CusblQF5lmIjZPZGqU8VHkBjtFoetRQ1EL7Lw7FKlRJEDmaxUpalMgzHP73yhaICYhw j+SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=azJ5/+1T/5WlBvvDNzOL+HKFyrTPeN5+4fQ9+NwyQ6Q=; b=N1FYDGJ71+nsMJajpKOj7Bx4P7WHCurgfH9cNOMksfN0GTS4CXsxpqCAZt0l10FH7Y 2MY1oDrtzx+PMS/dEwIpS3zbZwUYsHYjQaAK12iKNpFbAQNPe9xWUuPJ7e5iKbY0YpyG GAybWdeEdBd9fDBghiAE1mC0/EscYTzYIHQi1++EwyqiIu8SiaXWgqtrvNLobDr9s4AD H8emF4JJauZOuE4SZvPaJxaw3JauJwWI7XAjx/KrsLK8nLdnozEoDMNYQHg7dag+2x5n XXp9iDSQhuiL4zPmgaGm1sNQyT6Vv8sU5agan2BlALAsDTL0ZKbykOQdkTygFLM4AQ/x Jhqw== X-Gm-Message-State: AOAM531NnUibS+4v4DPz118LpKPfCgxrV7t1EPfkfF6KrPQAlIirdkEy z+0TKLsbQ+wOPdRXAMg4B12NPg== X-Google-Smtp-Source: ABdhPJx0b6XZVAYnbtoMnu2qgJzXxG+B7rCo7HyI4am/omrC2rLYGqbNbkHoy1PETImZJeeKD1v6Fw== X-Received: by 2002:adf:e2c9:: with SMTP id d9mr21780992wrj.227.1593525642488; Tue, 30 Jun 2020 07:00:42 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id n16sm3647457wra.19.2020.06.30.07.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 07:00:41 -0700 (PDT) Date: Tue, 30 Jun 2020 15:00:38 +0100 From: Lee Jones To: haver Subject: Re: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err' Message-ID: <20200630140038.GN1179328@dell> References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-18-lee.jones@linaro.org> <016718c7218cf811897cc32cf9476222@linux.vnet.ibm.com> <20200630091020.GJ1179328@dell> <235f96392b5a2f06b4410e9532b1322b@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <235f96392b5a2f06b4410e9532b1322b@linux.vnet.ibm.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , arnd@arndb.de, gregkh@linuxfoundation.org, Frank Haverkamp , Michael Jung , linux-kernel@vger.kernel.org, Michael Ruettger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAzMCBKdW4gMjAyMCwgaGF2ZXIgd3JvdGU6Cgo+IE9uIDIwMjAtMDYtMzAgMTE6MTAs IExlZSBKb25lcyB3cm90ZToKPiA+IE9uIFR1ZSwgMzAgSnVuIDIwMjAsIGhhdmVyIHdyb3RlOgo+ ID4gCj4gPiA+IE9uIDIwMjAtMDYtMjkgMTY6MDQsIExlZSBKb25lcyB3cm90ZToKPiA+ID4gPiAn ZmF0YWxfZXJyJyBpcyB0YWtlbiBhcyBhbiBhcmd1bWVudCB0byBhIHN0YXRpYyBmdW5jdGlvbiB3 aGljaCBpcyBvbmx5Cj4gPiA+ID4gaW52b2tlZCBvbmNlLiAgRHVyaW5nIHRoaXMgaW52b2NhdGlv biAnZmF0YWxfZXJyJyBpcyBub3Qgc2V0LiAgVGhlcmUKPiA+ID4gPiBkb2Vzbid0IGFwcGVhciB0 byBiZSBhIGdvb2QgcmVhc29uIHRvIGtlZXAgaXQgYXJvdW5kLgo+ID4gPiA+Cj4gPiA+ID4gQWxz byBmaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZzoKPiA+ID4gPgo+ ID4gPiA+ICBkcml2ZXJzL21pc2MvZ2Vud3FlL2NhcmRfYmFzZS5jOjU4ODogd2FybmluZzogRnVu Y3Rpb24gcGFyYW1ldGVyIG9yCj4gPiA+ID4gbWVtYmVyICdmYXRhbF9lcnInIG5vdCBkZXNjcmli ZWQgaW4gJ2dlbndxZV9yZWNvdmVyX2NhcmQnCj4gPiA+ID4KPiA+ID4gPiBDYzogTWljaGFlbCBK dW5nIDxtaWp1bmdAZ214Lm5ldD4KPiA+ID4gPiBDYzogTWljaGFlbCBSdWV0dGdlciA8bWljaGFl bEBpYm1yYS5kZT4KPiA+ID4gPiBDYzogRnJhbmsgSGF2ZXJrYW1wIDxoYXZlckBsaW51eC5pYm0u Y29tPgo+ID4gPiA+IENjOiBKb2VyZy1TdGVwaGFuIFZvZ3QgPGpzdm9ndEBkZS5pYm0uY29tPgo+ ID4gPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4g PiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvbWlzYy9nZW53cWUvY2FyZF9iYXNlLmMgfCAxOCAr KystLS0tLS0tLS0tLS0tLS0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr KSwgMTUgZGVsZXRpb25zKC0pCj4gPiA+ID4KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t aXNjL2dlbndxZS9jYXJkX2Jhc2UuYwo+ID4gPiA+IGIvZHJpdmVycy9taXNjL2dlbndxZS9jYXJk X2Jhc2UuYwo+ID4gPiA+IGluZGV4IGJjZWViZjQ5ZGUyZDUuLjgwOWE2ZjQ2ZjZkZTMgMTAwNjQ0 Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9taXNjL2dlbndxZS9jYXJkX2Jhc2UuYwo+ID4gPiA+ICsr KyBiL2RyaXZlcnMvbWlzYy9nZW53cWUvY2FyZF9iYXNlLmMKPiA+ID4gPiBAQCAtNTY5LDMwICs1 NjksMTggQEAgc3RhdGljIGludCBnZW53cWVfc3RvcChzdHJ1Y3QgZ2Vud3FlX2RldiAqY2QpCj4g PiA+ID4KPiA+ID4gPiAgLyoqCj4gPiA+ID4gICAqIGdlbndxZV9yZWNvdmVyX2NhcmQoKSAtIFRy eSB0byByZWNvdmVyIHRoZSBjYXJkIGlmIGl0IGlzIHBvc3NpYmxlCj4gPiA+ID4gLSAqCj4gPiA+ ID4gLSAqIElmIGZhdGFsX2VyciBpcyBzZXQgbm8gcmVnaXN0ZXIgYWNjZXNzIGlzIHBvc3NpYmxl IGFueW1vcmUuIEl0IGlzCj4gPiA+ID4gLSAqIGxpa2VseSB0aGF0IGdlbndxZV9zdGFydCBmYWls cyBpbiB0aGF0IHNpdHVhdGlvbi4gUHJvcGVyIGVycm9yCj4gPiA+ID4gLSAqIGhhbmRsaW5nIGlz IHJlcXVpcmVkIGluIHRoaXMgY2FzZS4KPiA+ID4gPiArICogQGNkOiBHZW5XUUUgZGV2aWNlIGlu Zm9ybWF0aW9uCj4gPiA+ID4gICAqCj4gPiA+ID4gICAqIGdlbndxZV9idXNfcmVzZXQoKSB3aWxs IGNhdXNlIHRoZSBwY2kgY29kZSB0byBjYWxsIGdlbndxZV9yZW1vdmUoKQo+ID4gPiA+ICAgKiBh bmQgbGF0ZXIgZ2Vud3FlX3Byb2JlKCkgZm9yIGFsbCB2aXJ0dWFsIGZ1bmN0aW9ucy4KPiA+ID4g PiAgICovCj4gPiA+ID4gLXN0YXRpYyBpbnQgZ2Vud3FlX3JlY292ZXJfY2FyZChzdHJ1Y3QgZ2Vu d3FlX2RldiAqY2QsIGludCBmYXRhbF9lcnIpCj4gPiA+ID4gK3N0YXRpYyBpbnQgZ2Vud3FlX3Jl Y292ZXJfY2FyZChzdHJ1Y3QgZ2Vud3FlX2RldiAqY2QpCj4gPiA+ID4gIHsKPiA+ID4gPiAgCWlu dCByYzsKPiA+ID4gPiAgCXN0cnVjdCBwY2lfZGV2ICpwY2lfZGV2ID0gY2QtPnBjaV9kZXY7Cj4g PiA+ID4KPiA+ID4gPiAgCWdlbndxZV9zdG9wKGNkKTsKPiA+ID4gPgo+ID4gPiA+IC0JLyoKPiA+ ID4gPiAtCSAqIE1ha2Ugc3VyZSBjaGlwIGlzIG5vdCByZWxvYWRlZCB0byBtYWludGFpbiBGRkRD LiBXcml0ZSBTTFUKPiA+ID4gPiAtCSAqIFJlc2V0IFJlZ2lzdGVyLCBDUExEUmVzZXQgZmllbGQg dG8gMC4KPiA+ID4gPiAtCSAqLwo+ID4gPiA+IC0JaWYgKCFmYXRhbF9lcnIpIHsKPiA+ID4gPiAt CQljZC0+c29mdHJlc2V0ID0gMHg3MHVsbDsKPiA+ID4gPiAtCQlfX2dlbndxZV93cml0ZXEoY2Qs IElPX1NMQ19DRkdSRUdfU09GVFJFU0VULCBjZC0+c29mdHJlc2V0KTsKPiA+ID4gPiAtCX0KPiA+ ID4gPiAtCj4gPiA+ID4gIAlyYyA9IGdlbndxZV9idXNfcmVzZXQoY2QpOwo+ID4gPiA+ICAJaWYg KHJjICE9IDApIHsKPiA+ID4gPiAgCQlkZXZfZXJyKCZwY2lfZGV2LT5kZXYsCj4gPiA+ID4gQEAg LTk1OCw3ICs5NDYsNyBAQCBzdGF0aWMgaW50IGdlbndxZV9oZWFsdGhfdGhyZWFkKHZvaWQgKmRh dGEpCj4gPiA+ID4KPiA+ID4gPiAgCQkJY2QtPmNhcmRfc3RhdGUgPSBHRU5XUUVfQ0FSRF9GQVRB TF9FUlJPUjsKPiA+ID4gPgo+ID4gPiA+IC0JCQlyYyA9IGdlbndxZV9yZWNvdmVyX2NhcmQoY2Qs IDApOwo+ID4gPiA+ICsJCQlyYyA9IGdlbndxZV9yZWNvdmVyX2NhcmQoY2QpOwo+ID4gPiA+ICAJ CQlpZiAocmMgPCAwKSB7Cj4gPiA+ID4gIAkJCQkvKiBGSVhNRSBDYXJkIGlzIHVudXNhYmxlIGFu ZCBuZWVkcyB1bmJpbmQhICovCj4gPiA+ID4gIAkJCQlnb3RvIGZhdGFsX2Vycm9yOwo+ID4gPiAK PiA+ID4gSSB0aGluayB0aGlzIG9uZSBJIHdhbnQgdG8ga2VlcC4gU2luY2UgZmF0YWxfZXJyIGlz IDAsICFmYXRhbF9lcnJvcgo+ID4gPiBpcyAxIGFuZAo+ID4gPiB0aGUgcmVnaXN0ZXIgd3JpdGUg aXMgYWN0dWFsbHkgZXhlY3V0ZWQuCj4gPiAKPiA+IEFoIHllcywgZ29vZCBjYXRjaC4KPiA+IAo+ ID4gV2hhdCBpZiB3ZSAqYWx3YXlzKiBkaWQgaW5zdGVhZCB0aGVuPwo+IAo+IEkga25ldyB5b3Ug d291bGQgYXNrIHRoYXQgOy0pLgo+IAo+ID4gCj4gPiA+IEkgYWxzbyB3YW50IHRvIGtlZXAgdGhl IHBhcmFtZXRlciBldmVuIHRob3VnaCBpdCBpcyBvbmx5IHVzZWQgd2l0aAo+ID4gPiAwLiBUaGUK PiA+ID4gcmVnaXN0ZXIgYml0IGNhdXNlcyBhIGxlc3MgZHJhc3RpYyByZWNvdmVyeSwgYnV0IGlm IHdlIHdvdWxkCj4gPiA+IGRpc2NvdmVyIHRoYXQKPiA+ID4gdGhhdCBpcyBub3Qgd29ya2luZyBv aywgd2UgcmF0aGVyIGRpc2NhcmQgdGhlIGRlYnVnIGRhdGEgd2UgZ2V0IGluCj4gPiA+IHRoaXMg Y2FzZQo+ID4gPiBpbnN0ZWFkIG9mIGxldHRpbmcgdGhlIHJlY292ZXJ5IGZhaWwuIEkgdGhpbmsg aXQgZG9lcyBub3QgaHVydCB0bwo+ID4gPiBrZWVwIGl0Lgo+ID4gCj4gPiBJJ20gbm90IDEwMCUg YWdhaW5zdCBpdCwgYnV0IGl0IGlzIGRlYWQgY29kZS4KPiA+IAo+ID4gPiBNYXliZSB5b3UgY2Fu IGFkZCBhIGNvbW1lbnQ/Cj4gPiAKPiA+IElmIHlvdSByZWFsbHkgd2FudCB0byBrZWVwIGl0LCBJ IGNhbiBqdXN0IHVwZGF0ZSB0aGUga2VybmVsZG9jCj4gPiBpbnN0ZWFkLgo+IAo+IEkgcHJlZmVy IHRoYXQgb3B0aW9uLiBJIHdhbnQgdG8gaW5kaWNhdGUgdGhhdCB0aGVyZSBhcmUgdHdvIHBvc3Np YmxlIHdheXMgdG8KPiByZWNvdmVyIG9uIGEgcHJvYmxlbS4gSWYgd2UgZGVsZXRlIHRoZSBjdXJy ZW50bHkgbm90IGV4cGxvaXRlZCBwYXJhbWV0ZXIsCj4gdGhpcyBpbmZvcm1hdGlvbiBnZXRzIGxv c3QuCgpUaGF0J3MgZmluZS4gIFdpbGwgZml4LgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpT ZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIg T3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29r IHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK