From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: andrew@lunn.ch, netdev@vger.kernel.org, f.fainelli@gmail.com,
hkallweit1@gmail.com, cphealy@gmail.com, mkubecek@suse.cz
Subject: Re: [PATCH net-next v4 03/10] net: ethtool: netlink: Add support for triggering a cable test
Date: Wed, 01 Jul 2020 16:00:14 -0700 (PDT) [thread overview]
Message-ID: <20200701.160014.637327748926165441.davem@davemloft.net> (raw)
In-Reply-To: <20200701155621.2b6ea9b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 1 Jul 2020 15:56:21 -0700
> On Sun, 10 May 2020 21:12:33 +0200 Andrew Lunn wrote:
>> diff --git a/net/Kconfig b/net/Kconfig
>> index c5ba2d180c43..5c524c6ee75d 100644
>> --- a/net/Kconfig
>> +++ b/net/Kconfig
>> @@ -455,6 +455,7 @@ config FAILOVER
>> config ETHTOOL_NETLINK
>> bool "Netlink interface for ethtool"
>> default y
>> + depends on PHYLIB=y || PHYLIB=n
>> help
>> An alternative userspace interface for ethtool based on generic
>> netlink. It provides better extensibility and some new features,
>
> Since ETHTOOL_NETLINK is a bool we end up not enabling it on
> allmodconfig builds, (PHYLIB=m so ETHTOOL_NETLINK dependency
> can't be met) - which is v scary for build testing.
>
> Is there a way we can change this dependency? Some REACHABLE shenanigans?
>
> Or since there are just two callbacks maybe phylib can "tell" ethtool
> core the pointers to call when it loads?
This has been discussed a few times and it's very irritating to me as well
as allmodconfig is the standard test build I do for all new changes.
next prev parent reply other threads:[~2020-07-01 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 19:12 [PATCH net-next v4 00/10] Ethernet Cable test support Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 01/10] net: phy: Add cable test support to state machine Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 1/1] net: phy: Send notifier when starting the cable test Andrew Lunn
2020-05-10 19:17 ` Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 02/10] net: phy: Add support for polling " Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 03/10] net: ethtool: netlink: Add support for triggering a " Andrew Lunn
2020-07-01 22:56 ` Jakub Kicinski
2020-07-01 23:00 ` David Miller [this message]
2020-07-02 0:26 ` Florian Fainelli
2020-07-02 1:06 ` David Miller
2020-05-10 19:12 ` [PATCH net-next v4 04/10] net: ethtool: Add attributes for cable test reports Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 05/10] net: ethtool: Make helpers public Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 06/10] net: ethtool: Add infrastructure for reporting cable test results Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 07/10] net: ethtool: Add helpers for reporting " Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 08/10] net: phy: marvell: Add cable test support Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 09/10] net: phy: Put interface into oper testing during cable test Andrew Lunn
2020-05-10 19:12 ` [PATCH net-next v4 10/10] net: phy: Send notifier when starting the " Andrew Lunn
2020-05-10 19:35 ` [PATCH net-next v4 00/10] Ethernet Cable test support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701.160014.637327748926165441.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.