From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A118C433E0 for ; Wed, 1 Jul 2020 07:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D627C2073E for ; Wed, 1 Jul 2020 07:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593590120; bh=5t93NkyfGhKJiTYQKhPT1KaCn9gTsqJJ06hndKaTj1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LYlGX9gFqHT3p1VkUmcwgqUnHSlcjVCj7qYI75xNYYqsugks+VKLTgQ8cr2u50m5m p29R2T60Sq1h1fh4wWmk1IR+iBYrMAAH6MM3mY2G3NHz6aKCjRFUvbRus3p41CX9Lx GQC3bMgbwNW3CGgisSHDk2T27tmsytleNlCIJu18= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728408AbgGAHzT (ORCPT ); Wed, 1 Jul 2020 03:55:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:48118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728392AbgGAHzS (ORCPT ); Wed, 1 Jul 2020 03:55:18 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57CB0206B6; Wed, 1 Jul 2020 07:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593590118; bh=5t93NkyfGhKJiTYQKhPT1KaCn9gTsqJJ06hndKaTj1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vlhT+lzaWNMNK4uLKefQhXFrghxc0l40imaCxs9ZSxhzqYoaJvwbQfef21615tsct 1ybdJsnpVmaQGLmrGoCjBBv3RNVTt7220zpexa1YFr4EN1A5V+d85twCf0XaatN7g9 Qwfn1JdXLO1qvIN0RnaeYzeHH+9R0xgg8OXpB2AU= Received: by pali.im (Postfix) id 90B6A102D; Wed, 1 Jul 2020 09:55:15 +0200 (CEST) Date: Wed, 1 Jul 2020 09:55:15 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Ajay.Kathat@microchip.com Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, johannes@sipsolutions.net, Nicolas.Ferre@microchip.com, Claudiu.Beznea@microchip.com, Sripad.Balwadgi@microchip.com, Venkateswara.Kaja@microchip.com Subject: Re: [PATCH v7 00/17] wilc1000: move out of staging Message-ID: <20200701075515.zypusfh4xazqu2fl@pali> References: <20200623110000.31559-1-ajay.kathat@microchip.com> <20200629132612.nl6rfpihzlii6ilh@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tuesday 30 June 2020 03:17:01 Ajay.Kathat@microchip.com wrote: > On 29/06/20 6:56 pm, Pali Rohár wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote: > >> This patch series is to review and move wilc1000 driver out of staging. > >> Most of the review comments received in [1] & [2] are addressed in the > >> latest code. > >> Please review and provide your inputs. > > > > Hello Ajay! Could you please move SDIO vendor/device ID definitions from > > driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h? > > > > Currently, the wilc1000 driver movement changes are present in topic > branch and yet to be merged to master branch. Would it be okay to submit > the new patch once driver is merged to 'wireless-driver-next' master and > branch is pulled into Greg's staging repo. I think it should be OK. But maybe Ulf as maintainer of mmc subsystem could have opinion or react on this. > Regards, > Ajay > > > Similar cleanup was recently finished for all existing non-staging drivers: > > https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@kernel.org/ > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B84AC433E0 for ; Wed, 1 Jul 2020 07:55:41 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EEA1206B6 for ; Wed, 1 Jul 2020 07:55:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vlhT+lza" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EEA1206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 418D1893CF; Wed, 1 Jul 2020 07:55:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lXqaYaTHZce9; Wed, 1 Jul 2020 07:55:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A18C68939F; Wed, 1 Jul 2020 07:55:39 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5FEE01BF59A for ; Wed, 1 Jul 2020 07:55:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 599878BBD3 for ; Wed, 1 Jul 2020 07:55:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sxnSosa8K7EV for ; Wed, 1 Jul 2020 07:55:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id CF3F38C2A6 for ; Wed, 1 Jul 2020 07:55:18 +0000 (UTC) Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57CB0206B6; Wed, 1 Jul 2020 07:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593590118; bh=5t93NkyfGhKJiTYQKhPT1KaCn9gTsqJJ06hndKaTj1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vlhT+lzaWNMNK4uLKefQhXFrghxc0l40imaCxs9ZSxhzqYoaJvwbQfef21615tsct 1ybdJsnpVmaQGLmrGoCjBBv3RNVTt7220zpexa1YFr4EN1A5V+d85twCf0XaatN7g9 Qwfn1JdXLO1qvIN0RnaeYzeHH+9R0xgg8OXpB2AU= Received: by pali.im (Postfix) id 90B6A102D; Wed, 1 Jul 2020 09:55:15 +0200 (CEST) Date: Wed, 1 Jul 2020 09:55:15 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Ajay.Kathat@microchip.com Subject: Re: [PATCH v7 00/17] wilc1000: move out of staging Message-ID: <20200701075515.zypusfh4xazqu2fl@pali> References: <20200623110000.31559-1-ajay.kathat@microchip.com> <20200629132612.nl6rfpihzlii6ilh@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Venkateswara.Kaja@microchip.com, Sripad.Balwadgi@microchip.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, Nicolas.Ferre@microchip.com, johannes@sipsolutions.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gVHVlc2RheSAzMCBKdW5lIDIwMjAgMDM6MTc6MDEgQWpheS5LYXRoYXRAbWljcm9jaGlwLmNv bSB3cm90ZToKPiBPbiAyOS8wNi8yMCA2OjU2IHBtLCBQYWxpIFJvaMOhciB3cm90ZToKPiA+IEVY VEVSTkFMIEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxl c3MgeW91IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQo+ID4gCj4gPiBPbiBUdWVzZGF5IDIzIEp1 bmUgMjAyMCAxMTowMDowNCBBamF5LkthdGhhdEBtaWNyb2NoaXAuY29tIHdyb3RlOgo+ID4+IFRo aXMgcGF0Y2ggc2VyaWVzIGlzIHRvIHJldmlldyBhbmQgbW92ZSB3aWxjMTAwMCBkcml2ZXIgb3V0 IG9mIHN0YWdpbmcuCj4gPj4gTW9zdCBvZiB0aGUgcmV2aWV3IGNvbW1lbnRzIHJlY2VpdmVkIGlu IFsxXSAmIFsyXSBhcmUgYWRkcmVzc2VkIGluIHRoZQo+ID4+IGxhdGVzdCBjb2RlLgo+ID4+IFBs ZWFzZSByZXZpZXcgYW5kIHByb3ZpZGUgeW91ciBpbnB1dHMuCj4gPiAKPiA+IEhlbGxvIEFqYXkh IENvdWxkIHlvdSBwbGVhc2UgbW92ZSBTRElPIHZlbmRvci9kZXZpY2UgSUQgZGVmaW5pdGlvbnMg ZnJvbQo+ID4gZHJpdmVyIGNvZGUgd2lsYzEwMDAvc2Rpby5jIHRvIGNvbW1vbiBmaWxlIGluY2x1 ZGUvbGludXgvbW1jL3NkaW9faWRzLmg/Cj4gPiAKPiAKPiBDdXJyZW50bHksIHRoZSB3aWxjMTAw MCBkcml2ZXIgbW92ZW1lbnQgY2hhbmdlcyBhcmUgcHJlc2VudCBpbiB0b3BpYwo+IGJyYW5jaCBh bmQgeWV0IHRvIGJlIG1lcmdlZCB0byBtYXN0ZXIgYnJhbmNoLiBXb3VsZCBpdCBiZSBva2F5IHRv IHN1Ym1pdAo+IHRoZSBuZXcgcGF0Y2ggb25jZSBkcml2ZXIgaXMgbWVyZ2VkIHRvICd3aXJlbGVz cy1kcml2ZXItbmV4dCcgbWFzdGVyIGFuZAo+IGJyYW5jaCBpcyBwdWxsZWQgaW50byBHcmVnJ3Mg c3RhZ2luZyByZXBvLgoKSSB0aGluayBpdCBzaG91bGQgYmUgT0suIEJ1dCBtYXliZSBVbGYgYXMg bWFpbnRhaW5lciBvZiBtbWMgc3Vic3lzdGVtCmNvdWxkIGhhdmUgb3BpbmlvbiBvciByZWFjdCBv biB0aGlzLgoKPiBSZWdhcmRzLAo+IEFqYXkKPiAKPiA+IFNpbWlsYXIgY2xlYW51cCB3YXMgcmVj ZW50bHkgZmluaXNoZWQgZm9yIGFsbCBleGlzdGluZyBub24tc3RhZ2luZyBkcml2ZXJzOgo+ID4g aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtbW1jLzIwMjAwNTIyMTQ0NDEyLjE5NzEyLTEt cGFsaUBrZXJuZWwub3JnLwo+ID4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qu b3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaXZlcmRldi1kZXZlbAo=