From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D030C433E1 for ; Wed, 1 Jul 2020 08:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A42C2073E for ; Wed, 1 Jul 2020 08:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593590927; bh=TiD5QRE8thatHCQG5rAJYxG5gqOGvYmSCBd/C5D2dj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tTZaCFNBg+hQMycxzWtn2okWYqmNnYVbdvSNO4zjbGdfONQTBnQ/OXcJ/f+kBpIat OOaMEwIBe5CZUxRhHfOhuX9eBf/VFhzAiLyH9nq3AuSHYjCdczc+jsvxzAPXxdXFRS /d/uVJ+G57AAXHIwNAeWSTvMvfzI2ogaFrCwXBsw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728593AbgGAIIp (ORCPT ); Wed, 1 Jul 2020 04:08:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:53968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728367AbgGAIIo (ORCPT ); Wed, 1 Jul 2020 04:08:44 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC97A206A1; Wed, 1 Jul 2020 08:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593590924; bh=TiD5QRE8thatHCQG5rAJYxG5gqOGvYmSCBd/C5D2dj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NsoWZqW8i2SPBdjU5yNdZH/0A7YB18OhTiJv/L2UjlEjFUBMq6nZt0Ojfc2X6Xyh5 GHIdfTrzaHPj7A+Leb2Cc8IKm9neML7wie4Sxe7h57LuUUMQ7++XNRZj0iVBYIJxV+ NCKJdBpFngy96TSlf7ZgWbzTT/8CCF/XprHUkSWs= Received: by pali.im (Postfix) id 1A366102D; Wed, 1 Jul 2020 10:08:42 +0200 (CEST) Date: Wed, 1 Jul 2020 10:08:41 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , Marek =?utf-8?B?QmVow7pu?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200701080841.azvlx2ijwxf5iyfl@pali> References: <20200630140420.7qkuq7wturmaafzf@pali> <20200630145848.GA3419143@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200630145848.GA3419143@bjorn-Precision-5520> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 30 June 2020 09:58:48 Bjorn Helgaas wrote: > On Tue, Jun 30, 2020 at 04:04:20PM +0200, Pali Rohár wrote: > > On Tuesday 30 June 2020 08:51:27 Bjorn Helgaas wrote: > > > On Thu, May 28, 2020 at 06:38:09PM +0200, Pali Rohár wrote: > > > > On Thursday 28 May 2020 11:26:04 Bjorn Helgaas wrote: > > > > > On Thu, May 28, 2020 at 04:31:41PM +0200, Pali Rohár wrote: > > > > > > When there is no PCIe card connected and advk_pcie_rd_conf() or > > > > > > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > > > > > > root bridge, the aardvark driver throws the following error message: > > > > > > > > > > > > advk-pcie d0070000.pcie: config read/write timed out > > > > > > > > > > > > Obviously accessing PCIe registers of disconnected card is not possible. > > > > > > > > > > > > Extend check in advk_pcie_valid_device() function for validating > > > > > > availability of PCIe bus. If PCIe link is down, then the device is marked > > > > > > as Not Found and the driver does not try to access these registers. > > > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > > --- > > > > > > drivers/pci/controller/pci-aardvark.c | 3 +++ > > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > > > > > index 90ff291c24f0..53a4cfd7d377 100644 > > > > > > --- a/drivers/pci/controller/pci-aardvark.c > > > > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > > > > @@ -644,6 +644,9 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus, > > > > > > if ((bus->number == pcie->root_bus_nr) && PCI_SLOT(devfn) != 0) > > > > > > return false; > > > > > > > > > > > > + if (bus->number != pcie->root_bus_nr && !advk_pcie_link_up(pcie)) > > > > > > + return false; > > > > > > > > > > I don't think this is the right fix. This makes it racy because the > > > > > link may go down after we call advk_pcie_valid_device() but before we > > > > > perform the config read. > > > > > > > > Yes, it is racy, but I do not think it cause problems. Trying to read > > > > PCIe registers when device is not connected cause just those timeouts, > > > > printing error message and increased delay in advk_pcie_wait_pio() due > > > > to polling loop. This patch reduce unnecessary access to PCIe registers > > > > when advk_pcie_wait_pio() polling just fail. > > > > > > What happens when the device is removed after advk_pcie_link_up() > > > returns true, but before we actually do the config access? > > > > Do you mean to remove device physically at runtime? I was told that our > > board would crash or issue reset. Removing device from mini PCIe slot > > without power off is not supported. > > Right, I don't think PCIe mini cards support hotplug. > > > Anyway, currently we are trying to read from device registers even when > > no device is connected. So when advk_pcie_link_up() returns true and > > after that device is not connected (somehow board and kernel would be > > still alive) I guess that it would behave as without applying this > > patch. So kernel starts reading from register and would wait until > > timeout expires. As device is not connected there would be no answer, > > so kernel print error message to dmesg (same as in commit message) and > > returns error that read failed. > > OK, so if I understand correctly, checking advk_pcie_link_up() is > strictly an optimization. If we guess wrong (e.g., after calling > advk_pcie_link_up(), the link went down because the card was removed, > DPC triggered, etc), the only bad thing is that we wait for a timeout; > it never causes a crash. Yes. > If that's the case, I'm fine with this. But please add a comment to > that effect. Ok, I will send V2 with updated commit message. > I think several other drivers check for the link being up because we > actually crash if we try to read config space when the link is down. > That's what I was trying to avoid here. > > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF01FC433E0 for ; Wed, 1 Jul 2020 08:10:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B82F4206A1 for ; Wed, 1 Jul 2020 08:10:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wnnUc16O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NsoWZqW8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B82F4206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=atJix2URDKhLLm6lLKsCKgymKa3TbNCfzqPQPWCW0BI=; b=wnnUc16OHQQThmuxNbK2UAkMr /DNV3o4yr4exb+bMZbhnyiMU1eMSqWLQue+xDGFT2IeD3OQw1oA9LAgztZlo/XEgrvT9ADpns+Ozy IpQKR2asw56kHZn/iqtSzYP0Jsg/BU3hbmuB5hLEQKROx22KoJONUKj36GRRIEThrDlJG7A3dGE6w RuUoVg20eBi/PMVKv6fjdpOg8IVoLITXn4IjeYuI2lmoZ9MSWxQTsfhoNWX957qAZVe3U1AfaxRJN FIC+OjnM28dE3H+xzwjXODc1SY9O5feVcEoG6opNtuduPZXtu2eHXX0ZMlu/ieRlkAdFZCuytnKjg CJw8UTkkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqXnT-0006bu-5E; Wed, 01 Jul 2020 08:08:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqXnQ-0006bM-L8 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 08:08:45 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC97A206A1; Wed, 1 Jul 2020 08:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593590924; bh=TiD5QRE8thatHCQG5rAJYxG5gqOGvYmSCBd/C5D2dj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NsoWZqW8i2SPBdjU5yNdZH/0A7YB18OhTiJv/L2UjlEjFUBMq6nZt0Ojfc2X6Xyh5 GHIdfTrzaHPj7A+Leb2Cc8IKm9neML7wie4Sxe7h57LuUUMQ7++XNRZj0iVBYIJxV+ NCKJdBpFngy96TSlf7ZgWbzTT/8CCF/XprHUkSWs= Received: by pali.im (Postfix) id 1A366102D; Wed, 1 Jul 2020 10:08:42 +0200 (CEST) Date: Wed, 1 Jul 2020 10:08:41 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Subject: Re: [PATCH] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200701080841.azvlx2ijwxf5iyfl@pali> References: <20200630140420.7qkuq7wturmaafzf@pali> <20200630145848.GA3419143@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200630145848.GA3419143@bjorn-Precision-5520> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_040844_820328_06AB2006 X-CRM114-Status: GOOD ( 40.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Xogium , linux-kernel@vger.kernel.org, Marek =?utf-8?B?QmVow7pu?= , Remi Pommarel , Thomas Petazzoni , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andrew Murray Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlc2RheSAzMCBKdW5lIDIwMjAgMDk6NTg6NDggQmpvcm4gSGVsZ2FhcyB3cm90ZToKPiBP biBUdWUsIEp1biAzMCwgMjAyMCBhdCAwNDowNDoyMFBNICswMjAwLCBQYWxpIFJvaMOhciB3cm90 ZToKPiA+IE9uIFR1ZXNkYXkgMzAgSnVuZSAyMDIwIDA4OjUxOjI3IEJqb3JuIEhlbGdhYXMgd3Jv dGU6Cj4gPiA+IE9uIFRodSwgTWF5IDI4LCAyMDIwIGF0IDA2OjM4OjA5UE0gKzAyMDAsIFBhbGkg Um9ow6FyIHdyb3RlOgo+ID4gPiA+IE9uIFRodXJzZGF5IDI4IE1heSAyMDIwIDExOjI2OjA0IEJq b3JuIEhlbGdhYXMgd3JvdGU6Cj4gPiA+ID4gPiBPbiBUaHUsIE1heSAyOCwgMjAyMCBhdCAwNDoz MTo0MVBNICswMjAwLCBQYWxpIFJvaMOhciB3cm90ZToKPiA+ID4gPiA+ID4gV2hlbiB0aGVyZSBp cyBubyBQQ0llIGNhcmQgY29ubmVjdGVkIGFuZCBhZHZrX3BjaWVfcmRfY29uZigpIG9yCj4gPiA+ ID4gPiA+IGFkdmtfcGNpZV93cl9jb25mKCkgaXMgY2FsbGVkIGZvciBQQ0kgYnVzIHdoaWNoIGRv ZXNuJ3QgYmVsb25nIHRvIGVtdWxhdGVkCj4gPiA+ID4gPiA+IHJvb3QgYnJpZGdlLCB0aGUgYWFy ZHZhcmsgZHJpdmVyIHRocm93cyB0aGUgZm9sbG93aW5nIGVycm9yIG1lc3NhZ2U6Cj4gPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiAgIGFkdmstcGNpZSBkMDA3MDAwMC5wY2llOiBjb25maWcgcmVhZC93 cml0ZSB0aW1lZCBvdXQKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IE9idmlvdXNseSBhY2Nlc3Np bmcgUENJZSByZWdpc3RlcnMgb2YgZGlzY29ubmVjdGVkIGNhcmQgaXMgbm90IHBvc3NpYmxlLgo+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gRXh0ZW5kIGNoZWNrIGluIGFkdmtfcGNpZV92YWxpZF9k ZXZpY2UoKSBmdW5jdGlvbiBmb3IgdmFsaWRhdGluZwo+ID4gPiA+ID4gPiBhdmFpbGFiaWxpdHkg b2YgUENJZSBidXMuIElmIFBDSWUgbGluayBpcyBkb3duLCB0aGVuIHRoZSBkZXZpY2UgaXMgbWFy a2VkCj4gPiA+ID4gPiA+IGFzIE5vdCBGb3VuZCBhbmQgdGhlIGRyaXZlciBkb2VzIG5vdCB0cnkg dG8gYWNjZXNzIHRoZXNlIHJlZ2lzdGVycy4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFNpZ25l ZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+Cj4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyB8IDMgKysr Cj4gPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFy ZHZhcmsuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKPiA+ID4gPiA+ ID4gaW5kZXggOTBmZjI5MWMyNGYwLi41M2E0Y2ZkN2QzNzcgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0t LSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKPiA+ID4gPiA+ID4gKysr IGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwo+ID4gPiA+ID4gPiBAQCAt NjQ0LDYgKzY0NCw5IEBAIHN0YXRpYyBib29sIGFkdmtfcGNpZV92YWxpZF9kZXZpY2Uoc3RydWN0 IGFkdmtfcGNpZSAqcGNpZSwgc3RydWN0IHBjaV9idXMgKmJ1cywKPiA+ID4gPiA+ID4gIAlpZiAo KGJ1cy0+bnVtYmVyID09IHBjaWUtPnJvb3RfYnVzX25yKSAmJiBQQ0lfU0xPVChkZXZmbikgIT0g MCkKPiA+ID4gPiA+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gPiA+ID4gPiAgCj4gPiA+ID4gPiA+ ICsJaWYgKGJ1cy0+bnVtYmVyICE9IHBjaWUtPnJvb3RfYnVzX25yICYmICFhZHZrX3BjaWVfbGlu a191cChwY2llKSkKPiA+ID4gPiA+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBJIGRvbid0IHRoaW5rIHRoaXMgaXMgdGhlIHJpZ2h0IGZpeC4gIFRoaXMgbWFrZXMgaXQg cmFjeSBiZWNhdXNlIHRoZQo+ID4gPiA+ID4gbGluayBtYXkgZ28gZG93biBhZnRlciB3ZSBjYWxs IGFkdmtfcGNpZV92YWxpZF9kZXZpY2UoKSBidXQgYmVmb3JlIHdlCj4gPiA+ID4gPiBwZXJmb3Jt IHRoZSBjb25maWcgcmVhZC4KPiA+ID4gPiAKPiA+ID4gPiBZZXMsIGl0IGlzIHJhY3ksIGJ1dCBJ IGRvIG5vdCB0aGluayBpdCBjYXVzZSBwcm9ibGVtcy4gVHJ5aW5nIHRvIHJlYWQKPiA+ID4gPiBQ Q0llIHJlZ2lzdGVycyB3aGVuIGRldmljZSBpcyBub3QgY29ubmVjdGVkIGNhdXNlIGp1c3QgdGhv c2UgdGltZW91dHMsCj4gPiA+ID4gcHJpbnRpbmcgZXJyb3IgbWVzc2FnZSBhbmQgaW5jcmVhc2Vk IGRlbGF5IGluIGFkdmtfcGNpZV93YWl0X3BpbygpIGR1ZQo+ID4gPiA+IHRvIHBvbGxpbmcgbG9v cC4gVGhpcyBwYXRjaCByZWR1Y2UgdW5uZWNlc3NhcnkgYWNjZXNzIHRvIFBDSWUgcmVnaXN0ZXJz Cj4gPiA+ID4gd2hlbiBhZHZrX3BjaWVfd2FpdF9waW8oKSBwb2xsaW5nIGp1c3QgZmFpbC4KPiA+ ID4gCj4gPiA+IFdoYXQgaGFwcGVucyB3aGVuIHRoZSBkZXZpY2UgaXMgcmVtb3ZlZCBhZnRlciBh ZHZrX3BjaWVfbGlua191cCgpCj4gPiA+IHJldHVybnMgdHJ1ZSwgYnV0IGJlZm9yZSB3ZSBhY3R1 YWxseSBkbyB0aGUgY29uZmlnIGFjY2Vzcz8KPiA+IAo+ID4gRG8geW91IG1lYW4gdG8gcmVtb3Zl IGRldmljZSBwaHlzaWNhbGx5IGF0IHJ1bnRpbWU/IEkgd2FzIHRvbGQgdGhhdCBvdXIKPiA+IGJv YXJkIHdvdWxkIGNyYXNoIG9yIGlzc3VlIHJlc2V0LiBSZW1vdmluZyBkZXZpY2UgZnJvbSBtaW5p IFBDSWUgc2xvdAo+ID4gd2l0aG91dCBwb3dlciBvZmYgaXMgbm90IHN1cHBvcnRlZC4KPiAKPiBS aWdodCwgSSBkb24ndCB0aGluayBQQ0llIG1pbmkgY2FyZHMgc3VwcG9ydCBob3RwbHVnLgo+IAo+ ID4gQW55d2F5LCBjdXJyZW50bHkgd2UgYXJlIHRyeWluZyB0byByZWFkIGZyb20gZGV2aWNlIHJl Z2lzdGVycyBldmVuIHdoZW4KPiA+IG5vIGRldmljZSBpcyBjb25uZWN0ZWQuIFNvIHdoZW4gYWR2 a19wY2llX2xpbmtfdXAoKSByZXR1cm5zIHRydWUgYW5kCj4gPiBhZnRlciB0aGF0IGRldmljZSBp cyBub3QgY29ubmVjdGVkIChzb21laG93IGJvYXJkIGFuZCBrZXJuZWwgd291bGQgYmUKPiA+IHN0 aWxsIGFsaXZlKSBJIGd1ZXNzIHRoYXQgaXQgd291bGQgYmVoYXZlIGFzIHdpdGhvdXQgYXBwbHlp bmcgdGhpcwo+ID4gcGF0Y2guIFNvIGtlcm5lbCBzdGFydHMgcmVhZGluZyBmcm9tIHJlZ2lzdGVy IGFuZCB3b3VsZCB3YWl0IHVudGlsCj4gPiB0aW1lb3V0IGV4cGlyZXMuIEFzIGRldmljZSBpcyBu b3QgY29ubmVjdGVkIHRoZXJlIHdvdWxkIGJlIG5vIGFuc3dlciwKPiA+IHNvIGtlcm5lbCBwcmlu dCBlcnJvciBtZXNzYWdlIHRvIGRtZXNnIChzYW1lIGFzIGluIGNvbW1pdCBtZXNzYWdlKSBhbmQK PiA+IHJldHVybnMgZXJyb3IgdGhhdCByZWFkIGZhaWxlZC4KPiAKPiBPSywgc28gaWYgSSB1bmRl cnN0YW5kIGNvcnJlY3RseSwgY2hlY2tpbmcgYWR2a19wY2llX2xpbmtfdXAoKSBpcwo+IHN0cmlj dGx5IGFuIG9wdGltaXphdGlvbi4gIElmIHdlIGd1ZXNzIHdyb25nIChlLmcuLCBhZnRlciBjYWxs aW5nCj4gYWR2a19wY2llX2xpbmtfdXAoKSwgdGhlIGxpbmsgd2VudCBkb3duIGJlY2F1c2UgdGhl IGNhcmQgd2FzIHJlbW92ZWQsCj4gRFBDIHRyaWdnZXJlZCwgZXRjKSwgdGhlIG9ubHkgYmFkIHRo aW5nIGlzIHRoYXQgd2Ugd2FpdCBmb3IgYSB0aW1lb3V0Owo+IGl0IG5ldmVyIGNhdXNlcyBhIGNy YXNoLgoKWWVzLgoKPiBJZiB0aGF0J3MgdGhlIGNhc2UsIEknbSBmaW5lIHdpdGggdGhpcy4gIEJ1 dCBwbGVhc2UgYWRkIGEgY29tbWVudCB0bwo+IHRoYXQgZWZmZWN0LgoKT2ssIEkgd2lsbCBzZW5k IFYyIHdpdGggdXBkYXRlZCBjb21taXQgbWVzc2FnZS4KCj4gSSB0aGluayBzZXZlcmFsIG90aGVy IGRyaXZlcnMgY2hlY2sgZm9yIHRoZSBsaW5rIGJlaW5nIHVwIGJlY2F1c2Ugd2UKPiBhY3R1YWxs eSBjcmFzaCBpZiB3ZSB0cnkgdG8gcmVhZCBjb25maWcgc3BhY2Ugd2hlbiB0aGUgbGluayBpcyBk b3duLgo+IFRoYXQncyB3aGF0IEkgd2FzIHRyeWluZyB0byBhdm9pZCBoZXJlLgo+IAo+IEJqb3Ju CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==