From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5394C433DF for ; Wed, 1 Jul 2020 21:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1BEF2078A for ; Wed, 1 Jul 2020 21:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593639286; bh=1IXZOrZkYM9neavpCctk0wMLNeZPLPq2m53FYeI7R3Y=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=QZ4U6zZMvo+b6VbMwondJTw6FRlnWWAbExtzuVv0ueMI8h29Prz2xKplFNMKjunNs 9l9z+Stk4TgX5l5IqoBh9XZJSNqqOD2HCO9WrIrfuZJ75eLq8PHV43hOg8SxbzVs8J xlpUTIRj59qLS7+TLSe1HrcjlVqZ7UxQvGTIZsZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbgGAVep (ORCPT ); Wed, 1 Jul 2020 17:34:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgGAVeo (ORCPT ); Wed, 1 Jul 2020 17:34:44 -0400 Received: from localhost (mobile-166-175-191-139.mycingular.net [166.175.191.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B578620772; Wed, 1 Jul 2020 21:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593639284; bh=1IXZOrZkYM9neavpCctk0wMLNeZPLPq2m53FYeI7R3Y=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=rF3Ewa/DKeKRd7U/VwQDI9QcjPY5MWYOBR0LJpIBp1SLRkn2QT4i7qTZTG07NxK1m M8q+xoldII2dJ92U815VFStWbt9B4ALxER1mY7dMl9lJsDDNOWiGAido654S2MhuPr dz5UVbYgCqY+bpKJZjkWsv7Vtv7Pagr86fKv0BjQ= Date: Wed, 1 Jul 2020 16:34:42 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , Marek =?iso-8859-1?Q?Beh=FAn?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200701213442.GA3662456@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701082044.4494-1-pali@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2020 at 10:20:44AM +0200, Pali Rohár wrote: > When there is no PCIe card connected and advk_pcie_rd_conf() or > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > root bridge, the aardvark driver throws the following error message: > > advk-pcie d0070000.pcie: config read/write timed out > > Obviously accessing PCIe registers of disconnected card is not possible. > > Extend check in advk_pcie_valid_device() function for validating > availability of PCIe bus. If PCIe link is down, then the device is marked > as Not Found and the driver does not try to access these registers. > > This is just an optimization to prevent accessing PCIe registers when card > is disconnected. Trying to access PCIe registers of disconnected card does > not cause any crash, kernel just needs to wait for a timeout. So if card > disappear immediately after checking for PCIe link (before accessing PCIe > registers), it does not cause any problems. Thanks, this is good. I'd really like a short comment in the code as well, because this sort of link-up check tends to get copied to new drivers where it shouldn't be used, e.g., something like this: /* * If the link goes down after we check for link-up, nothing bad * happens but the config access times out. */ > Signed-off-by: Pali Rohár > > --- > Changes in V2: > * Update commit message, mention that this is optimization > --- > drivers/pci/controller/pci-aardvark.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index 90ff291c24f0..53a4cfd7d377 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -644,6 +644,9 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus, > if ((bus->number == pcie->root_bus_nr) && PCI_SLOT(devfn) != 0) > return false; > > + if (bus->number != pcie->root_bus_nr && !advk_pcie_link_up(pcie)) > + return false; > + > return true; > } > > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A022C433DF for ; Wed, 1 Jul 2020 21:36:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC9F620772 for ; Wed, 1 Jul 2020 21:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fRe6DCXF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rF3Ewa/D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC9F620772 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=UIjpyduHwFY6fOR4/wC5KhZ1vGaeyRARfzMbfM7rgCs=; b=fRe6DCXFqFq7hRIyheHajCWcF XBVq3+mAX0XbJPSLwP/tm7p4larCwzmFAgdA/iStYnD8J5VTI2jaLu0o1EKr8bfwmY+W1Z9zt3Rk8 qs2z60uZf0F6vcwEnFky555/EscON0YEn1USADOGrzfdoLlErUaLfjfE+2P+fFmelD6ddIHVD6xHK 8dGKiDaywAR7blxjjyiQ/E6fRE8jtnQcWeEmaB2Glv2+6De5i5XXauT22saLYwBzGq9552PSpG066 tmba2GVKVOHzqkF85wP7ShIokfMc4TDCyU37Z2cCOgjSJ3dpqEoYOEqL3CBQfVc4HRgrG9ep/8mE1 pozvM4jgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqkNU-0004lH-70; Wed, 01 Jul 2020 21:34:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqkNR-0004kg-Px for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 21:34:46 +0000 Received: from localhost (mobile-166-175-191-139.mycingular.net [166.175.191.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B578620772; Wed, 1 Jul 2020 21:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593639284; bh=1IXZOrZkYM9neavpCctk0wMLNeZPLPq2m53FYeI7R3Y=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=rF3Ewa/DKeKRd7U/VwQDI9QcjPY5MWYOBR0LJpIBp1SLRkn2QT4i7qTZTG07NxK1m M8q+xoldII2dJ92U815VFStWbt9B4ALxER1mY7dMl9lJsDDNOWiGAido654S2MhuPr dz5UVbYgCqY+bpKJZjkWsv7Vtv7Pagr86fKv0BjQ= Date: Wed, 1 Jul 2020 16:34:42 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH v2] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200701213442.GA3662456@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701082044.4494-1-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_173445_911621_109211CF X-CRM114-Status: GOOD ( 24.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Xogium , linux-kernel@vger.kernel.org, Marek =?iso-8859-1?Q?Beh=FAn?= , Remi Pommarel , Thomas Petazzoni , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andrew Murray Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2020 at 10:20:44AM +0200, Pali Roh=E1r wrote: > When there is no PCIe card connected and advk_pcie_rd_conf() or > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > root bridge, the aardvark driver throws the following error message: > = > advk-pcie d0070000.pcie: config read/write timed out > = > Obviously accessing PCIe registers of disconnected card is not possible. > = > Extend check in advk_pcie_valid_device() function for validating > availability of PCIe bus. If PCIe link is down, then the device is marked > as Not Found and the driver does not try to access these registers. > = > This is just an optimization to prevent accessing PCIe registers when card > is disconnected. Trying to access PCIe registers of disconnected card does > not cause any crash, kernel just needs to wait for a timeout. So if card > disappear immediately after checking for PCIe link (before accessing PCIe > registers), it does not cause any problems. Thanks, this is good. I'd really like a short comment in the code as well, because this sort of link-up check tends to get copied to new drivers where it shouldn't be used, e.g., something like this: /* * If the link goes down after we check for link-up, nothing bad * happens but the config access times out. */ > Signed-off-by: Pali Roh=E1r > = > --- > Changes in V2: > * Update commit message, mention that this is optimization > --- > drivers/pci/controller/pci-aardvark.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controll= er/pci-aardvark.c > index 90ff291c24f0..53a4cfd7d377 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -644,6 +644,9 @@ static bool advk_pcie_valid_device(struct advk_pcie *= pcie, struct pci_bus *bus, > if ((bus->number =3D=3D pcie->root_bus_nr) && PCI_SLOT(devfn) !=3D 0) > return false; > = > + if (bus->number !=3D pcie->root_bus_nr && !advk_pcie_link_up(pcie)) > + return false; > + > return true; > } > = > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel