From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46BCC433E0 for ; Thu, 2 Jul 2020 08:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A565920720 for ; Thu, 2 Jul 2020 08:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593678250; bh=A4x8rASu1MxlGaK4Uw98Lg3c9yofoP0D7gnk1mnvwQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tW5+XcQzJuL27IfeyC+mPNo9Ok4cApsNOea9C5IFHllweSRCavSg/09yy0NhpXA/t thjqSuQ0FVhGuLgTNDPUBbMSo6dNjYwRfOacaRVtnT0Y1Il18wzxDVX6w6fiM9am1w SivH1vvrMbYEmaP+ZOREaNBFn0UzZZobj8SD9S8s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728801AbgGBIYI (ORCPT ); Thu, 2 Jul 2020 04:24:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:50598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728746AbgGBIYD (ORCPT ); Thu, 2 Jul 2020 04:24:03 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 635FF20720; Thu, 2 Jul 2020 08:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593678242; bh=A4x8rASu1MxlGaK4Uw98Lg3c9yofoP0D7gnk1mnvwQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x7OVPlAjY6MGQp6wnGj9/IFkiOBoc/jegOMFsboi3w/M/7o0WD9ubPagnMIcFwMyJ 6ruT2TpqQtkJGu5k2iETtFULovOrL+bhlfJqgN/oX3AczHJOtX8v2Cf5YpBhZsQ3U7 vnxCNNP9F5uS2V+vYf57H/iyktY5nVDHGvMzGNts= Received: by pali.im (Postfix) id D496DE92; Thu, 2 Jul 2020 10:23:59 +0200 (CEST) Date: Thu, 2 Jul 2020 10:23:59 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , Marek =?utf-8?B?QmVow7pu?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200702082359.h6f6r3hsr57fnquh@pali> References: <20200701082044.4494-1-pali@kernel.org> <20200701213442.GA3662456@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701213442.GA3662456@bjorn-Precision-5520> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 01 July 2020 16:34:42 Bjorn Helgaas wrote: > On Wed, Jul 01, 2020 at 10:20:44AM +0200, Pali Rohár wrote: > > When there is no PCIe card connected and advk_pcie_rd_conf() or > > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > > root bridge, the aardvark driver throws the following error message: > > > > advk-pcie d0070000.pcie: config read/write timed out > > > > Obviously accessing PCIe registers of disconnected card is not possible. > > > > Extend check in advk_pcie_valid_device() function for validating > > availability of PCIe bus. If PCIe link is down, then the device is marked > > as Not Found and the driver does not try to access these registers. > > > > This is just an optimization to prevent accessing PCIe registers when card > > is disconnected. Trying to access PCIe registers of disconnected card does > > not cause any crash, kernel just needs to wait for a timeout. So if card > > disappear immediately after checking for PCIe link (before accessing PCIe > > registers), it does not cause any problems. > > Thanks, this is good. I'd really like a short comment in the code as > well, because this sort of link-up check tends to get copied to new > drivers where it shouldn't be used, e.g., something like this: > > /* > * If the link goes down after we check for link-up, nothing bad > * happens but the config access times out. > */ Ok, it makes sense! I will send a new patch version. > > Signed-off-by: Pali Rohár > > > > --- > > Changes in V2: > > * Update commit message, mention that this is optimization > > --- > > drivers/pci/controller/pci-aardvark.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > index 90ff291c24f0..53a4cfd7d377 100644 > > --- a/drivers/pci/controller/pci-aardvark.c > > +++ b/drivers/pci/controller/pci-aardvark.c > > @@ -644,6 +644,9 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus, > > if ((bus->number == pcie->root_bus_nr) && PCI_SLOT(devfn) != 0) > > return false; > > > > + if (bus->number != pcie->root_bus_nr && !advk_pcie_link_up(pcie)) > > + return false; > > + > > return true; > > } > > > > -- > > 2.20.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D370C433E2 for ; Thu, 2 Jul 2020 08:25:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CCE820899 for ; Thu, 2 Jul 2020 08:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jDau5YnN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="x7OVPlAj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CCE820899 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b4U+JYwlp/ITXPVhQAgScZ184ngLVSZK2aJls60O5vI=; b=jDau5YnNRdc3NzJHmNE5I/PWr nvFQAWn1LnVoRCjje1V2NPQt/v+4H37MJ4GRrZUVBPXsDRQRg3BhvY2vkK7TZvl7H3aoZuxVfD2a4 9RYGS9VuOzb9IV4Octl3BU8MLZGqrABRZKMjwz3rIow5njutRw8GQ4K/vFH7+gkM4b/Snsnk5rlgX /FfB5/BXToN5Jbenqrh9TiCaHaD2FtSSaglVtYDe0XSSoEb4SD3S3fdwwdpknjZ13miKbA6qOZiWq uiPvMl2j3OOjiYcinH74o1GS8vwXHP/GxevKJCZIxW6o+WHRiRZ3vVUgBJfO94wtKsaem5JW4ka5M 5vu9zToIw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jquVp-0007bv-Np; Thu, 02 Jul 2020 08:24:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jquVo-0007b0-0t for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 08:24:04 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 635FF20720; Thu, 2 Jul 2020 08:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593678242; bh=A4x8rASu1MxlGaK4Uw98Lg3c9yofoP0D7gnk1mnvwQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x7OVPlAjY6MGQp6wnGj9/IFkiOBoc/jegOMFsboi3w/M/7o0WD9ubPagnMIcFwMyJ 6ruT2TpqQtkJGu5k2iETtFULovOrL+bhlfJqgN/oX3AczHJOtX8v2Cf5YpBhZsQ3U7 vnxCNNP9F5uS2V+vYf57H/iyktY5nVDHGvMzGNts= Received: by pali.im (Postfix) id D496DE92; Thu, 2 Jul 2020 10:23:59 +0200 (CEST) Date: Thu, 2 Jul 2020 10:23:59 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Subject: Re: [PATCH v2] PCI: aardvark: Don't touch PCIe registers if no card connected Message-ID: <20200702082359.h6f6r3hsr57fnquh@pali> References: <20200701082044.4494-1-pali@kernel.org> <20200701213442.GA3662456@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701213442.GA3662456@bjorn-Precision-5520> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_042404_196889_1A41088A X-CRM114-Status: GOOD ( 27.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Xogium , linux-kernel@vger.kernel.org, Marek =?utf-8?B?QmVow7pu?= , Remi Pommarel , Thomas Petazzoni , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andrew Murray Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkbmVzZGF5IDAxIEp1bHkgMjAyMCAxNjozNDo0MiBCam9ybiBIZWxnYWFzIHdyb3RlOgo+ IE9uIFdlZCwgSnVsIDAxLCAyMDIwIGF0IDEwOjIwOjQ0QU0gKzAyMDAsIFBhbGkgUm9ow6FyIHdy b3RlOgo+ID4gV2hlbiB0aGVyZSBpcyBubyBQQ0llIGNhcmQgY29ubmVjdGVkIGFuZCBhZHZrX3Bj aWVfcmRfY29uZigpIG9yCj4gPiBhZHZrX3BjaWVfd3JfY29uZigpIGlzIGNhbGxlZCBmb3IgUENJ IGJ1cyB3aGljaCBkb2Vzbid0IGJlbG9uZyB0byBlbXVsYXRlZAo+ID4gcm9vdCBicmlkZ2UsIHRo ZSBhYXJkdmFyayBkcml2ZXIgdGhyb3dzIHRoZSBmb2xsb3dpbmcgZXJyb3IgbWVzc2FnZToKPiA+ IAo+ID4gICBhZHZrLXBjaWUgZDAwNzAwMDAucGNpZTogY29uZmlnIHJlYWQvd3JpdGUgdGltZWQg b3V0Cj4gPiAKPiA+IE9idmlvdXNseSBhY2Nlc3NpbmcgUENJZSByZWdpc3RlcnMgb2YgZGlzY29u bmVjdGVkIGNhcmQgaXMgbm90IHBvc3NpYmxlLgo+ID4gCj4gPiBFeHRlbmQgY2hlY2sgaW4gYWR2 a19wY2llX3ZhbGlkX2RldmljZSgpIGZ1bmN0aW9uIGZvciB2YWxpZGF0aW5nCj4gPiBhdmFpbGFi aWxpdHkgb2YgUENJZSBidXMuIElmIFBDSWUgbGluayBpcyBkb3duLCB0aGVuIHRoZSBkZXZpY2Ug aXMgbWFya2VkCj4gPiBhcyBOb3QgRm91bmQgYW5kIHRoZSBkcml2ZXIgZG9lcyBub3QgdHJ5IHRv IGFjY2VzcyB0aGVzZSByZWdpc3RlcnMuCj4gPiAKPiA+IFRoaXMgaXMganVzdCBhbiBvcHRpbWl6 YXRpb24gdG8gcHJldmVudCBhY2Nlc3NpbmcgUENJZSByZWdpc3RlcnMgd2hlbiBjYXJkCj4gPiBp cyBkaXNjb25uZWN0ZWQuIFRyeWluZyB0byBhY2Nlc3MgUENJZSByZWdpc3RlcnMgb2YgZGlzY29u bmVjdGVkIGNhcmQgZG9lcwo+ID4gbm90IGNhdXNlIGFueSBjcmFzaCwga2VybmVsIGp1c3QgbmVl ZHMgdG8gd2FpdCBmb3IgYSB0aW1lb3V0LiBTbyBpZiBjYXJkCj4gPiBkaXNhcHBlYXIgaW1tZWRp YXRlbHkgYWZ0ZXIgY2hlY2tpbmcgZm9yIFBDSWUgbGluayAoYmVmb3JlIGFjY2Vzc2luZyBQQ0ll Cj4gPiByZWdpc3RlcnMpLCBpdCBkb2VzIG5vdCBjYXVzZSBhbnkgcHJvYmxlbXMuCj4gCj4gVGhh bmtzLCB0aGlzIGlzIGdvb2QuICBJJ2QgcmVhbGx5IGxpa2UgYSBzaG9ydCBjb21tZW50IGluIHRo ZSBjb2RlIGFzCj4gd2VsbCwgYmVjYXVzZSB0aGlzIHNvcnQgb2YgbGluay11cCBjaGVjayB0ZW5k cyB0byBnZXQgY29waWVkIHRvIG5ldwo+IGRyaXZlcnMgd2hlcmUgaXQgc2hvdWxkbid0IGJlIHVz ZWQsIGUuZy4sIHNvbWV0aGluZyBsaWtlIHRoaXM6Cj4gCj4gICAvKgo+ICAgICogSWYgdGhlIGxp bmsgZ29lcyBkb3duIGFmdGVyIHdlIGNoZWNrIGZvciBsaW5rLXVwLCBub3RoaW5nIGJhZAo+ICAg ICogaGFwcGVucyBidXQgdGhlIGNvbmZpZyBhY2Nlc3MgdGltZXMgb3V0Lgo+ICAgICovCgpPaywg aXQgbWFrZXMgc2Vuc2UhIEkgd2lsbCBzZW5kIGEgbmV3IHBhdGNoIHZlcnNpb24uCgo+ID4gU2ln bmVkLW9mZi1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiA+IAo+ID4gLS0tCj4g PiBDaGFuZ2VzIGluIFYyOgo+ID4gKiBVcGRhdGUgY29tbWl0IG1lc3NhZ2UsIG1lbnRpb24gdGhh dCB0aGlzIGlzIG9wdGltaXphdGlvbgo+ID4gLS0tCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxl ci9wY2ktYWFyZHZhcmsuYyB8IDMgKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9u cygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFy ZHZhcmsuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKPiA+IGluZGV4 IDkwZmYyOTFjMjRmMC4uNTNhNGNmZDdkMzc3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9wY2kv Y29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwo+ID4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9wY2ktYWFyZHZhcmsuYwo+ID4gQEAgLTY0NCw2ICs2NDQsOSBAQCBzdGF0aWMgYm9vbCBhZHZr X3BjaWVfdmFsaWRfZGV2aWNlKHN0cnVjdCBhZHZrX3BjaWUgKnBjaWUsIHN0cnVjdCBwY2lfYnVz ICpidXMsCj4gPiAgCWlmICgoYnVzLT5udW1iZXIgPT0gcGNpZS0+cm9vdF9idXNfbnIpICYmIFBD SV9TTE9UKGRldmZuKSAhPSAwKQo+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gIAo+ID4gKwlpZiAo YnVzLT5udW1iZXIgIT0gcGNpZS0+cm9vdF9idXNfbnIgJiYgIWFkdmtfcGNpZV9saW5rX3VwKHBj aWUpKQo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwo+ID4gIAlyZXR1cm4gdHJ1ZTsKPiA+ICB9 Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMjAuMQo+ID4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==