From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3013C433DF for ; Thu, 2 Jul 2020 15:42:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9527B208D5 for ; Thu, 2 Jul 2020 15:42:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MwGxMiEp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730224AbgGBPmY (ORCPT ); Thu, 2 Jul 2020 11:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730213AbgGBPmU (ORCPT ); Thu, 2 Jul 2020 11:42:20 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4017FC08C5DD for ; Thu, 2 Jul 2020 08:42:20 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id d10so11461056pls.5 for ; Thu, 02 Jul 2020 08:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Kybd0zpVtDTcpe4L/HEboaUKNNgAnXPFcQy8ZwcEJuI=; b=MwGxMiEp5/dtTA3ogef34O3PctcdhAV3Nj892QYS7iq/+bdlneIKDksIISF88MZTJs 551vB7jwtgzZZvtq6shJNSIVEPChNMunEoUB8LbEsFmwqHkuUWtxgcXHKQhYMgExY7+k RjFrm4VGnLlBn/66+5Gz+fn0C9B0GHrDhf0l0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Kybd0zpVtDTcpe4L/HEboaUKNNgAnXPFcQy8ZwcEJuI=; b=NFLP9x6eCA+Y2FXQWvKYJRYGXkG2VRWUhhxrfwQiKxkfL8HRWr6y6O2IkdwSTsTWN1 K0SKPI0xN/06xQKWGDNm6LFs1on3WoYbyd+uHo/MaDUF7Dz0m4vvZUwQf21CA53Ah56u hhDMYbe2sgUXiTekrghZxkA4prdIC0CORR+lrzgfOlnqFKw2GNYPM8m8UsDUcuAxZISp wZ1PL9LCfqOSB5/YkwP5vUk+MvR+LDrKQxaJckmt/iSZbureNKl4u6mUSWw7JoVB+qaq IY7Et6t2Rrlz/Mh1KCdH/JgscXIceOjwSDGNxtocQRQbHDkjKKkW0Nb9YYfEPfKENfJ/ OX4w== X-Gm-Message-State: AOAM532bd6al3wdzDbhUhjexMVp5NWczHNIxOUWaNud6rWh0JoXfEWMW DXpb+wePGr5N5Ezx9TAyNZJuQA== X-Google-Smtp-Source: ABdhPJx/V021h2YOrPd2qoUZY3+ajz3Yf7zbLlvvx3ojyPgvvotTbq49bzs576UQiATe81OrpVMgog== X-Received: by 2002:a17:90a:7785:: with SMTP id v5mr35048412pjk.31.1593704539711; Thu, 02 Jul 2020 08:42:19 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l191sm9749876pfd.149.2020.07.02.08.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 08:42:18 -0700 (PDT) Date: Thu, 2 Jul 2020 08:42:17 -0700 From: Kees Cook To: Mark Brown Cc: linux-kernel@vger.kernel.org, Nick Desaulniers , Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage Message-ID: <202007020839.545A571CA4@keescook> References: <20200620033007.1444705-1-keescook@chromium.org> <20200620033007.1444705-9-keescook@chromium.org> <20200701203920.GC3776@sirena.org.uk> <202007020819.318824DA@keescook> <20200702152335.GJ4483@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702152335.GJ4483@sirena.org.uk> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Jul 02, 2020 at 04:23:35PM +0100, Mark Brown wrote: > On Thu, Jul 02, 2020 at 08:21:40AM -0700, Kees Cook wrote: > > On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > > > > Please copy maintainers on patches :( > > > Hi! Sorry about that; the CC list was giant, so I had opted for using > > subsystem mailing lists where possible. > > If you're going to err in a direction there I'd err in the direction of > CCing the people not the list - I only saw this since I was looking for > something else, I don't normally see stuff in the mailing list folder. Yeah, I've gotten conflicting feedback on treewide changes: - please CC me on only the one patch, I don't want to see everything else - please CC me on the whole series, I want the full context for the change I opted toward "CC me on this series", but then I get stuck when the CC is giant. I think I may switch back to individual CCs for specific patches, and point people to lore if they want greater context. (lore didn't exist before...) Thanks for the poke to make me reconsider this workflow. :) -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Thu, 2 Jul 2020 08:42:17 -0700 Subject: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage In-Reply-To: <20200702152335.GJ4483@sirena.org.uk> References: <20200620033007.1444705-1-keescook@chromium.org> <20200620033007.1444705-9-keescook@chromium.org> <20200701203920.GC3776@sirena.org.uk> <202007020819.318824DA@keescook> <20200702152335.GJ4483@sirena.org.uk> Message-ID: <202007020839.545A571CA4@keescook> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown Cc: linux-kernel@vger.kernel.org, Nick Desaulniers , Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com On Thu, Jul 02, 2020 at 04:23:35PM +0100, Mark Brown wrote: > On Thu, Jul 02, 2020 at 08:21:40AM -0700, Kees Cook wrote: > > On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > > > > Please copy maintainers on patches :( > > > Hi! Sorry about that; the CC list was giant, so I had opted for using > > subsystem mailing lists where possible. > > If you're going to err in a direction there I'd err in the direction of > CCing the people not the list - I only saw this since I was looking for > something else, I don't normally see stuff in the mailing list folder. Yeah, I've gotten conflicting feedback on treewide changes: - please CC me on only the one patch, I don't want to see everything else - please CC me on the whole series, I want the full context for the change I opted toward "CC me on this series", but then I get stuck when the CC is giant. I think I may switch back to individual CCs for specific patches, and point people to lore if they want greater context. (lore didn't exist before...) Thanks for the poke to make me reconsider this workflow. :) -- Kees Cook