From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7429BC433E0 for ; Thu, 2 Jul 2020 14:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D845206E2 for ; Thu, 2 Jul 2020 14:49:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yIWlMjN0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730335AbgGBOtY (ORCPT ); Thu, 2 Jul 2020 10:49:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729960AbgGBOqm (ORCPT ); Thu, 2 Jul 2020 10:46:42 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D236C08C5C1 for ; Thu, 2 Jul 2020 07:46:42 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id s10so28744784wrw.12 for ; Thu, 02 Jul 2020 07:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=yIWlMjN0w19WzloUJb27YHxd5Lv2apKTHNCXpZAD+f82IlZ3PHXnJHPuKhqY0rS81s QhZs+X6iPjFvByqqq7pbk0L53rMGDtKW5FxzOziYz6xeaR8f5G/QXdzGL/5bqnDtJiPL sNH3X1dLCSubDr7yM/FA9k24CATuCeAh/iLiL1cX5ux7S1E0GMK8QS8Bt+apIPUWr5vd SZ57qUbVbp6Y3pFbnr8TEYhdSOdESv+8q7JOp726Q0hQtCOeKBHPSPTEt5Msd4ErPqsN BjNbMI2tqHASmGNzXbMyPz2SSAoKQWZklBkBhEeDGBIYuaaXABebQIPiWIan83aqDdb/ Ufrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=YixzLaI2831+kmUiBu/35GoXcuXP/hxYuFWeFBVM+dmqAvNkYC+Z65V58XLOFykbzZ 8+LPqW/TwCaloERK3aLZ0TX2CvIdun6WEXrR7wAoGR4jq+NM9schmG43X3ThyaZ0U1yw y8JquL6F0zsaJ8PgySCMZCqG56XBLcpZXCG+tQFScLGkIEx46+WvY2TRnEDS0U/mfEgT ToX2ZdAhGa1XNaH+x9yISxShy1I1i18HnURdeQ48sF9FEzES93ZRXJOUPb01MYgxlPuP MkmM1/5CK4vjNFBYNGUHVnkGC7hxEQUkfWA9Z7Dex2DfOvgwdfRtkdrNzpkS9T0/1638 8Jyw== X-Gm-Message-State: AOAM531SfG44hkCQyluUzeYZ5ouGhhB22gzotQ2G6tJpZGapcU+GEa5y LiJFVAeDAWOmjnCzDifhYzMSOg== X-Google-Smtp-Source: ABdhPJyIZmpTdu7PTQVZc5pYnov4rLotdR3wYot7zbkIhZfmSkLmkMIl/bLtH204G49vYqtuSIyZ/A== X-Received: by 2002:a5d:44c7:: with SMTP id z7mr34212570wrr.226.1593701201196; Thu, 02 Jul 2020 07:46:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:40 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Heikki Krogerus Subject: [PATCH 07/30] usb: common: ulpi: Fix a few kerneldoc related issues Date: Thu, 2 Jul 2020 15:46:02 +0100 Message-Id: <20200702144625.2533530-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Firstly, demote function header to standard comment block as they are not suitable for kerneldoc. Then provide description for ulpi_register_driver()'s argument 'module'. Finally rename description for ulpi_unregister_interface()'s 'ulpi' arg. Fixes the following W=1 warnings: drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'ulpi' not described in 'ulpi_read' drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'addr' not described in 'ulpi_read' drivers/usb/common/ulpi.c:150: warning: Function parameter or member 'module' not described in '__ulpi_register_driver' drivers/usb/common/ulpi.c:299: warning: Function parameter or member 'ulpi' not described in 'ulpi_unregister_interface' drivers/usb/common/ulpi.c:299: warning: Excess function parameter 'intrf' description in 'ulpi_unregister_interface' Cc: Felipe Balbi Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/common/ulpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 9a2ab6751a23c..a18d7c4222ddf 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * ulpi.c - USB ULPI PHY bus * * Copyright (C) 2015 Intel Corporation @@ -143,6 +143,7 @@ static const struct device_type ulpi_dev_type = { /** * ulpi_register_driver - register a driver with the ULPI bus * @drv: driver being registered + * @module: ends up being THIS_MODULE * * Registers a driver with the ULPI bus. */ @@ -290,7 +291,7 @@ EXPORT_SYMBOL_GPL(ulpi_register_interface); /** * ulpi_unregister_interface - unregister ULPI interface - * @intrf: struct ulpi_interface + * @ulpi: struct ulpi_interface * * Unregisters a ULPI device and it's interface that was created with * ulpi_create_interface(). -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3092AC433E0 for ; Thu, 2 Jul 2020 14:50:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE87120772 for ; Thu, 2 Jul 2020 14:50:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hDpAMKtf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yIWlMjN0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE87120772 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H1tf3prtuti6GHe4gEy9i+MOMOzhleiFCb9N7u4w+Jk=; b=hDpAMKtftL3p/x1x41RX6LPEb t+Ix583Yt/hXvbpDrnEiMZL/f0evenfpCXWy9RBwl1WfpxDjVpjr0bXFYy7nE7lFVfIceKN8Gi0tr dJ7NF9OdlUEzETRDY6QQTyHY7rz1YljhrGpHEHybh1+Eu4G2GxKoyqYQZpnrohQPCXsjxfbG0O3mC wnITeBt42tpellaLec1mynZ6jS5+Hc5kO48udeEFURaGzj5ftTb/FdM2u83mSCz4k3fACT1h4/3ns DkgTAaTbZfZgGO85M6UhlWxeWSNp8XJ7EJ+EH4m/p8xBTt2IIFCkEew6lINwVV6GDCD6tZ4cOidli 7XccGBiKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0VL-0005uw-Sz; Thu, 02 Jul 2020 14:48:00 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0U6-0005Et-2p for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 14:46:43 +0000 Received: by mail-wr1-x441.google.com with SMTP id f2so817144wrp.7 for ; Thu, 02 Jul 2020 07:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=yIWlMjN0w19WzloUJb27YHxd5Lv2apKTHNCXpZAD+f82IlZ3PHXnJHPuKhqY0rS81s QhZs+X6iPjFvByqqq7pbk0L53rMGDtKW5FxzOziYz6xeaR8f5G/QXdzGL/5bqnDtJiPL sNH3X1dLCSubDr7yM/FA9k24CATuCeAh/iLiL1cX5ux7S1E0GMK8QS8Bt+apIPUWr5vd SZ57qUbVbp6Y3pFbnr8TEYhdSOdESv+8q7JOp726Q0hQtCOeKBHPSPTEt5Msd4ErPqsN BjNbMI2tqHASmGNzXbMyPz2SSAoKQWZklBkBhEeDGBIYuaaXABebQIPiWIan83aqDdb/ Ufrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=d8YBQ6b7wthEf6sulxnDFLFzanFleXXd7E8Y8AlESUSN0u682ojWGElCKsvVv7ZdOd Whzy3Xb6hlJWDcAU7rgUqeHjmAjBIF5TzesVXx+tDazSp4jhMQxTAI8Vd3kH7jHhCgic iyRM/Osi5zdbA9/csyQgJjGhhmU4g+6ZZrk7crk7J514lhFwA1tQuNDS24k/9r4UiEy+ EuDOIFgGdC8XkGU4+hMDEjBWHDDPKds9TVE1sKgk1N5ZP7t3uqWOntbbDvaJo3/Cp9pM hIgt+lvxo1dRJiqp2rEvjy1/rcDM0zEOiMnYGqkg745Zsdiju4TNfMR1pXv76sdg6L7T oTlg== X-Gm-Message-State: AOAM532R+nE282P/VvX3bStfx4bdMbZM6YeBU2MJzBN/xBD+TDcxWp5w +00AKJY/fCF6mcysifCCK8cn1w== X-Google-Smtp-Source: ABdhPJyIZmpTdu7PTQVZc5pYnov4rLotdR3wYot7zbkIhZfmSkLmkMIl/bLtH204G49vYqtuSIyZ/A== X-Received: by 2002:a5d:44c7:: with SMTP id z7mr34212570wrr.226.1593701201196; Thu, 02 Jul 2020 07:46:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:40 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 07/30] usb: common: ulpi: Fix a few kerneldoc related issues Date: Thu, 2 Jul 2020 15:46:02 +0100 Message-Id: <20200702144625.2533530-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_104642_184851_686C33DF X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Firstly, demote function header to standard comment block as they are not suitable for kerneldoc. Then provide description for ulpi_register_driver()'s argument 'module'. Finally rename description for ulpi_unregister_interface()'s 'ulpi' arg. Fixes the following W=1 warnings: drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'ulpi' not described in 'ulpi_read' drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'addr' not described in 'ulpi_read' drivers/usb/common/ulpi.c:150: warning: Function parameter or member 'module' not described in '__ulpi_register_driver' drivers/usb/common/ulpi.c:299: warning: Function parameter or member 'ulpi' not described in 'ulpi_unregister_interface' drivers/usb/common/ulpi.c:299: warning: Excess function parameter 'intrf' description in 'ulpi_unregister_interface' Cc: Felipe Balbi Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/common/ulpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 9a2ab6751a23c..a18d7c4222ddf 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * ulpi.c - USB ULPI PHY bus * * Copyright (C) 2015 Intel Corporation @@ -143,6 +143,7 @@ static const struct device_type ulpi_dev_type = { /** * ulpi_register_driver - register a driver with the ULPI bus * @drv: driver being registered + * @module: ends up being THIS_MODULE * * Registers a driver with the ULPI bus. */ @@ -290,7 +291,7 @@ EXPORT_SYMBOL_GPL(ulpi_register_interface); /** * ulpi_unregister_interface - unregister ULPI interface - * @intrf: struct ulpi_interface + * @ulpi: struct ulpi_interface * * Unregisters a ULPI device and it's interface that was created with * ulpi_create_interface(). -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel