From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Peter Tribble <peter.tribble@gmail.com>,
qemu-devel@nongnu.org, Michele Denber <denber@mindspring.com>
Subject: Re: [PATCH] configure / util: Auto-detect the availability of openpty()
Date: Thu, 2 Jul 2020 15:46:50 +0100 [thread overview]
Message-ID: <20200702144650.GM1888119@redhat.com> (raw)
In-Reply-To: <20200702143955.678-1-thuth@redhat.com>
On Thu, Jul 02, 2020 at 04:39:55PM +0200, Thomas Huth wrote:
> Recent versions of Solaris (v11.4) now feature an openpty() function,
> too, causing a build failure since we ship our own implementation of
> openpty() for Solaris in util/qemu-openpty.c so far. Since there are
> now both variants available in the wild, with and without this function,
> let's introduce a proper HAVE_OPENPTY define for this to fix the build
> failure.
11.4 has been out since Aug 2018
The previous verison of solaris 11.3 was from Oct 2015, with EOL
in Oct 2020 [1].
Solaris isn't an officially supported platform for QEMU, but if it
was, then we'd probably consider it a long life distro, and thus
consider 11.3 to be out of scope for QEMU by now.
IOW, instead of checking for openpty being missing, I think there's
a decent argument to be made that we can just assume openpty exists,
and delete the old solaris compat code entirely.
Regards,
Daniel
[1] https://en.wikipedia.org/wiki/Solaris_(operating_system)
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-07-02 14:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:39 [PATCH] configure / util: Auto-detect the availability of openpty() Thomas Huth
2020-07-02 14:46 ` Daniel P. Berrangé [this message]
2020-07-02 16:07 ` Michele Denber
2020-07-02 17:38 ` Thomas Huth
2020-07-02 16:13 ` Michele Denber
2020-07-02 17:34 ` Thomas Huth
2020-07-02 21:33 ` Michele Denber
2020-07-03 5:11 ` Thomas Huth
2020-07-03 16:25 ` Michele Denber
2020-07-03 16:34 ` Michele Denber
2020-07-03 16:50 ` Peter Maydell
2020-07-03 18:49 ` gmake in Solaris 11.4: _IOR missing Michele Denber
2020-07-03 21:35 ` gmake in Solaris 11.4: TFR missing Michele Denber
2020-07-03 21:55 ` Philippe Mathieu-Daudé
2020-07-04 9:11 ` Peter Maydell
2020-07-04 11:30 ` Philippe Mathieu-Daudé
2020-07-04 13:52 ` Peter Maydell
2020-07-04 15:27 ` Michele Denber
2020-07-04 12:02 ` Thomas Huth
2020-07-04 15:36 ` Michele Denber
2020-07-04 15:57 ` Philippe Mathieu-Daudé
2020-07-04 19:15 ` Michele Denber
2020-07-04 21:58 ` Peter Maydell
2020-07-04 19:48 ` Michele Denber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702144650.GM1888119@redhat.com \
--to=berrange@redhat.com \
--cc=denber@mindspring.com \
--cc=peter.tribble@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.