From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC2FC433DF for ; Fri, 3 Jul 2020 11:11:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 718DA207FF for ; Fri, 3 Jul 2020 11:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbgGCLLQ (ORCPT ); Fri, 3 Jul 2020 07:11:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:54744 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgGCLLQ (ORCPT ); Fri, 3 Jul 2020 07:11:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 55C19AEA7; Fri, 3 Jul 2020 11:11:14 +0000 (UTC) Date: Fri, 3 Jul 2020 13:11:13 +0200 From: Petr Mladek To: qiang.zhang@windriver.com Cc: ben.dooks@codethink.co.uk, bfields@redhat.com, cl@rock-chips.com, peterz@infradead.org, tj@kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] kthread: work could not be queued when worker being destroyed Message-ID: <20200703111113.GG14288@alley> References: <20200702070156.5862-1-qiang.zhang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702070156.5862-1-qiang.zhang@windriver.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2020-07-02 15:01:56, qiang.zhang@windriver.com wrote: > From: Zhang Qiang > > The "queuing_blocked" func should print warning message and > returns true when the worker being destroyed. > > Suggested-by: Petr Mladek > Signed-off-by: Zhang Qiang Looks good to me. Reviewed-by: Petr Mladek Adding Andrew into CC. Changes in kernel/kthread.c usually goes through him. You might need to resend the patch once again with Andrew in CC. Best Regards, Petr Mladek