From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
Date: Fri, 03 Jul 2020 19:35:59 +0800 [thread overview]
Message-ID: <20200703113559.GA19031@bf425ecdd42c> (raw)
In-Reply-To: <202007031941.um9p1FRJ%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 5006 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Corey Minyard <minyard@acm.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: openipmi-developer(a)lists.sourceforge.net
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/char/ipmi/ipmi_msghandler.c:2694:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2743:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2612:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2659:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2765:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2676:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2711:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2727:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2628:8-16: WARNING: use scnprintf or sprintf
drivers/char/ipmi/ipmi_msghandler.c:2643:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: 988676da8375 ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.9
head: 5502a4eb3af819792a6c43b418c401f613a39d02
commit: 988676da837516bbfafda5478472fd4265f0de4e [1/3] coccinelle: api: add device_attr_show script
:::::: branch date: 8 days ago
:::::: commit date: 9 days ago
Please take the patch only if it's a positive warning. Thanks!
ipmi_msghandler.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2609,7 +2609,7 @@ static ssize_t device_id_show(struct dev
if (rv)
return rv;
- return snprintf(buf, 10, "%u\n", id.device_id);
+ return scnprintf(buf, 10, "%u\n", id.device_id);
}
static DEVICE_ATTR_RO(device_id);
@@ -2625,7 +2625,7 @@ static ssize_t provides_device_sdrs_show
if (rv)
return rv;
- return snprintf(buf, 10, "%u\n", (id.device_revision & 0x80) >> 7);
+ return scnprintf(buf, 10, "%u\n", (id.device_revision & 0x80) >> 7);
}
static DEVICE_ATTR_RO(provides_device_sdrs);
@@ -2640,7 +2640,7 @@ static ssize_t revision_show(struct devi
if (rv)
return rv;
- return snprintf(buf, 20, "%u\n", id.device_revision & 0x0F);
+ return scnprintf(buf, 20, "%u\n", id.device_revision & 0x0F);
}
static DEVICE_ATTR_RO(revision);
@@ -2656,7 +2656,7 @@ static ssize_t firmware_revision_show(st
if (rv)
return rv;
- return snprintf(buf, 20, "%u.%x\n", id.firmware_revision_1,
+ return scnprintf(buf, 20, "%u.%x\n", id.firmware_revision_1,
id.firmware_revision_2);
}
static DEVICE_ATTR_RO(firmware_revision);
@@ -2673,7 +2673,7 @@ static ssize_t ipmi_version_show(struct
if (rv)
return rv;
- return snprintf(buf, 20, "%u.%u\n",
+ return scnprintf(buf, 20, "%u.%u\n",
ipmi_version_major(&id),
ipmi_version_minor(&id));
}
@@ -2691,7 +2691,7 @@ static ssize_t add_dev_support_show(stru
if (rv)
return rv;
- return snprintf(buf, 10, "0x%02x\n", id.additional_device_support);
+ return scnprintf(buf, 10, "0x%02x\n", id.additional_device_support);
}
static DEVICE_ATTR(additional_device_support, S_IRUGO, add_dev_support_show,
NULL);
@@ -2708,7 +2708,7 @@ static ssize_t manufacturer_id_show(stru
if (rv)
return rv;
- return snprintf(buf, 20, "0x%6.6x\n", id.manufacturer_id);
+ return scnprintf(buf, 20, "0x%6.6x\n", id.manufacturer_id);
}
static DEVICE_ATTR_RO(manufacturer_id);
@@ -2724,7 +2724,7 @@ static ssize_t product_id_show(struct de
if (rv)
return rv;
- return snprintf(buf, 10, "0x%4.4x\n", id.product_id);
+ return scnprintf(buf, 10, "0x%4.4x\n", id.product_id);
}
static DEVICE_ATTR_RO(product_id);
@@ -2740,7 +2740,7 @@ static ssize_t aux_firmware_rev_show(str
if (rv)
return rv;
- return snprintf(buf, 21, "0x%02x 0x%02x 0x%02x 0x%02x\n",
+ return scnprintf(buf, 21, "0x%02x 0x%02x 0x%02x 0x%02x\n",
id.aux_firmware_revision[3],
id.aux_firmware_revision[2],
id.aux_firmware_revision[1],
@@ -2762,7 +2762,7 @@ static ssize_t guid_show(struct device *
if (!guid_set)
return -ENOENT;
- return snprintf(buf, UUID_STRING_LEN + 1 + 1, "%pUl\n", &guid);
+ return scnprintf(buf, UUID_STRING_LEN + 1 + 1, "%pUl\n", &guid);
}
static DEVICE_ATTR_RO(guid);
next prev parent reply other threads:[~2020-07-03 11:35 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 11:35 [jlawall:for-5.9 1/3] drivers/tty/serial/8250/8250_port.c:2989:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-07-03 11:35 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-07-03 11:35 ` kernel test robot
2020-07-03 11:35 ` kernel test robot
2020-07-03 11:35 ` kernel test robot
2020-07-03 11:35 ` kernel test robot
2020-07-03 11:35 ` kernel test robot
2020-07-03 11:35 ` kernel test robot
2020-07-03 11:35 ` kernel test robot [this message]
2020-07-03 11:36 ` kernel test robot
2020-07-03 11:36 ` kernel test robot
2020-07-03 11:36 ` kernel test robot
2020-07-03 11:36 ` kernel test robot
[not found] <86ae66c7-927b-d41b-f097-b46f28943f58@linux.com>
2020-12-30 1:19 ` Rong Chen
-- strict thread matches above, loose matches on Subject: below --
2020-12-29 7:35 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1950:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-29 7:35 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-29 4:59 drivers/acpi/bgrt.c:28:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-29 4:59 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-27 20:04 drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-27 20:04 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-27 20:04 ` kernel test robot
2020-12-27 20:04 ` kernel test robot
2020-12-27 20:04 ` kernel test robot
2020-12-27 20:05 ` kernel test robot
2020-12-27 20:05 ` kernel test robot
2020-12-27 20:05 ` kernel test robot
2020-12-27 20:05 ` kernel test robot
2020-12-27 20:05 ` kernel test robot
2020-12-14 17:27 drivers/hid/hid-sensor-custom.c:371:10-18: WARNING: use scnprintf or sprintf kernel test robot
2020-12-14 17:27 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-14 15:10 mm/backing-dev.c:209:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-14 15:10 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-14 15:10 ` kernel test robot
2020-12-14 15:10 ` kernel test robot
2020-12-14 15:10 ` kernel test robot
2020-12-14 15:10 ` kernel test robot
2020-12-14 15:10 ` kernel test robot
2020-12-10 21:20 drivers/hid/wacom_sys.c:1796:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-10 21:20 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-07 6:03 drivers/net/can/janz-ican3.c:1834:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-07 6:03 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-02 13:02 drivers/iio/trigger/iio-trig-hrtimer.c:41:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-02 13:02 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-12-01 1:10 drivers/scsi/fcoe/fcoe_sysfs.c:376:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-12-01 1:10 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-30 21:50 drivers/perf/fsl_imx8_ddr_perf.c:119:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-30 21:50 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-24 20:47 drivers/iio/trigger/stm32-timer-trigger.c:299:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-24 20:47 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-22 19:07 drivers/hwmon/pmbus/inspur-ipsps.c:94:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-22 19:07 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-22 10:27 drivers/char/ipmi/ipmi_msghandler.c:2694:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-22 10:27 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-20 11:52 drivers/crypto/picoxcell_crypto.c:1200:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-20 11:52 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-19 7:24 drivers/hwmon/occ/common.c:554:9-17: WARNING: use scnprintf or sprintf kernel test robot
2020-11-19 7:24 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-17 17:21 drivers/net/can/at91_can.c:1185:9-17: WARNING: use scnprintf or sprintf kernel test robot
2020-11-17 17:21 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-13 17:02 drivers/platform/x86/panasonic-laptop.c:371:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-13 17:02 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-12 1:20 drivers/net/can/janz-ican3.c:1834:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-12 1:20 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-11-05 1:14 drivers/platform/x86/sony-laptop.c:2054:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-11-05 1:14 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-10-06 7:21 drivers/platform/x86/lg-laptop.c:496:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-10-06 7:21 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-10-06 7:21 ` kernel test robot
2020-10-01 4:11 drivers/block/aoe/aoeblk.c:102:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-10-01 4:11 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-29 20:34 drivers/usb/usbip/stub_dev.c:33:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-29 20:34 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-15 7:28 drivers/video/fbdev/sstfb.c:736:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-15 7:28 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-15 7:28 ` kernel test robot
2020-09-12 22:57 drivers/scsi/isci/init.c:140:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-12 22:57 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-12 10:01 drivers/scsi/csiostor/csio_scsi.c:1433:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-12 10:01 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-10 8:53 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-09 15:04 arch/x86/events/intel/pt.c:95:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-09 15:04 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-02 12:37 drivers/edac/edac_mc_sysfs.c:210:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-02 12:37 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-02 12:37 ` kernel test robot
2020-09-02 12:37 ` kernel test robot
2020-09-01 8:46 drivers/scsi/pmcraid.c:4091:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-01 8:46 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-08-26 19:38 drivers/scsi/aacraid/linit.c:1355:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-08-26 19:38 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-08-18 22:52 drivers/video/fbdev/sstfb.c:736:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-08-18 22:52 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-08-13 0:56 drivers/acpi/dock.c:563:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-08-13 0:56 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-13 0:56 ` kernel test robot
2020-08-10 9:20 drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-08-10 9:21 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-08-10 9:21 ` kernel test robot
2020-08-10 9:21 ` kernel test robot
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
2020-09-08 12:08 ` Julia Lawall
2020-07-27 3:35 [jlawall:for-5.9 1/7] drivers/most/core.c:254:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-07-27 3:35 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-07-26 23:39 [jlawall:for-5.9 1/7] drivers/scsi/ufs/ufshcd.c:1749:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-07-26 23:39 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-07-08 2:42 [jlawall:for-5.9 1/3] drivers/char/hw_random/core.c:399:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-07-08 2:42 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-07-08 2:42 ` kernel test robot
2020-07-08 2:42 ` kernel test robot
2020-07-07 17:07 [jlawall:for-5.9 1/3] drivers/scsi/pcmcia/sym53c500_cs.c:621:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-07-07 17:07 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-06-25 4:50 [jlawall:for-5.9 1/3] drivers/base/core.c:1526:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-06-25 4:50 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-06-25 3:41 [jlawall:for-5.9 1/3] arch/x86/events/core.c:2219:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-06-25 3:41 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703113559.GA19031@bf425ecdd42c \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.