From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69F4C433DF for ; Fri, 3 Jul 2020 12:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C161120B80 for ; Fri, 3 Jul 2020 12:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="RipJvTN4"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tp0tdt6/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbgGCMRO (ORCPT ); Fri, 3 Jul 2020 08:17:14 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:43557 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgGCMRN (ORCPT ); Fri, 3 Jul 2020 08:17:13 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id CBC44580B40; Fri, 3 Jul 2020 08:17:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 03 Jul 2020 08:17:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=rTAW5gwN1+eRVhnOurD7jQuXi4p UqbQePveppBGQdEw=; b=RipJvTN4fMIJGnPXzaFbH2xdYeXlEM/TLctg/+dGVFw hUE2Yj8IAutcexKEPxJj4fDjPLfOU6p6cR28VWPmXRUY7l3UcT3kIWwphonjaL8A Qks3wiMJHd3qDBq0BOGkOpdiJr5GAm7SADf+i9Aub45Rr2xFm3CExJX0DYFd4Y6x S1xVHZt/yDDmkWzhBDnpIHeoeoq4UrVcut4evC6/F4NzpePePCjC7sGRGNeBTSU8 ZU6y4zriP90AyZPumw4zEmArRs/wpGrV+x0YR1nowyno6HDdx6Z4vEvMlK4Xqvdc UUrzm39uGrUysaBPACcEisxuVMFjGqDsc0nFveOlXxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rTAW5g wN1+eRVhnOurD7jQuXi4pUqbQePveppBGQdEw=; b=tp0tdt6/H2GLCGlRnPCcSP 8rqvOJRVFL4dpHscL4XPeQNuA8C+Ik+UI48jSjPz2fbdb3ieehNukO29NdP5a5Gw DOEqTWwlVCLYr7AVDcAnDO/2qqCaA9/rybp0a2AMSkH6e6Nh1iRQ9a/SM330IvAK z3pYZi/FLNFXXD3dktC7sR43Uhb1hD6UrI0S15ZUwMkxk+hiqrPd6LAKWDPB/1FV I8YxfhdfNw7TPuDeBOii2ef/YlhAMnRkiKY7St5GaLdzfAua8hxkfO3ngQ8CtJS3 bRQKD4ks/EWjr7loPth7ntGGuqnyH0qrBcOP3rE+kODCYLtar45LqQnAicFI17UA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtdeigdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A6DF306006D; Fri, 3 Jul 2020 08:17:08 -0400 (EDT) Date: Fri, 3 Jul 2020 14:17:06 +0200 From: Maxime Ripard To: Ondrej Jirman Cc: Rob Herring , Chen-Yu Tsai , Icenowy Zheng , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Samuel Holland , Martijn Braam , Luca Weiss , Bhushan Shah , Linus Walleij Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Message-ID: <20200703121706.gf2yxfe7crleatlm@gilmour.lan> References: <20200702081432.1727696-1-megous@megous.com> <20200702081432.1727696-3-megous@megous.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cxgywaqrrd6jmrsp" Content-Disposition: inline In-Reply-To: <20200702081432.1727696-3-megous@megous.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cxgywaqrrd6jmrsp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote: > Pinephone has a Goodix GT917S capacitive touchscreen controller on > I2C0 bus. Add support for it. >=20 > Signed-off-by: Ondrej Jirman > Acked-by: Linus Walleij > --- > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/ar= ch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > index a89425ad3727..5c7386566053 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > @@ -121,6 +121,25 @@ &ehci1 { > status =3D "okay"; > }; > =20 > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins>; > + status =3D "okay"; I didn't spot this earlier, but the pinctrl properties are already set in the DTSI. I've removed them while applying the patch. Thanks! Maxime --cxgywaqrrd6jmrsp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXv8hwQAKCRDj7w1vZxhR xZHoAQDeaPm5c6iWX8CcvBcL8Vrae7EAun13r2RrsQbElBt06AD/RGPN7dt9hGp8 nvnWM3MC/4nwVVPKFdGRLOiTy6Tg1AI= =+CVs -----END PGP SIGNATURE----- --cxgywaqrrd6jmrsp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D61CC433DF for ; Fri, 3 Jul 2020 12:18:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1957620826 for ; Fri, 3 Jul 2020 12:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MUbQNNtV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="RipJvTN4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tp0tdt6/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1957620826 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1CzotYKJ5/tE8BZfZp7VBaiPZWR7wn1oxjJcE7RMWiE=; b=MUbQNNtVH0FoSqMT2kKBWySd6 SxDz7ECCleSo7/GPEWGq2kWkh+jahcXtCRaX745U6VY+aPMmBgYL8Mr9rYmbFZ1Ktv0bONq0hQ8HK 3wEpBjNbFy2H9L/1B8mgs//7nxxf9E4xkHVWr/u0n4ZNX8+npgDDc6F5ZplwNPiSxFaadP+FupA3n p6YZiO7OyZHRzni0+oJs6pzeTrN69Dcf5J8JKvMuot55wXoHCPCXtpfbF22p3zfXkpW6silZgGfBg YkcpItk/D4+H8SbxfPqEYpt/kb837WeJ49SS89jMhbIGu6jy6h1D8+ZWOs9wNgfV3M0FV8y+KsMAU mghW5NOPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrKd4-00030i-AX; Fri, 03 Jul 2020 12:17:18 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrKd1-0002zj-OD for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 12:17:16 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id CBC44580B40; Fri, 3 Jul 2020 08:17:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 03 Jul 2020 08:17:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=rTAW5gwN1+eRVhnOurD7jQuXi4p UqbQePveppBGQdEw=; b=RipJvTN4fMIJGnPXzaFbH2xdYeXlEM/TLctg/+dGVFw hUE2Yj8IAutcexKEPxJj4fDjPLfOU6p6cR28VWPmXRUY7l3UcT3kIWwphonjaL8A Qks3wiMJHd3qDBq0BOGkOpdiJr5GAm7SADf+i9Aub45Rr2xFm3CExJX0DYFd4Y6x S1xVHZt/yDDmkWzhBDnpIHeoeoq4UrVcut4evC6/F4NzpePePCjC7sGRGNeBTSU8 ZU6y4zriP90AyZPumw4zEmArRs/wpGrV+x0YR1nowyno6HDdx6Z4vEvMlK4Xqvdc UUrzm39uGrUysaBPACcEisxuVMFjGqDsc0nFveOlXxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rTAW5g wN1+eRVhnOurD7jQuXi4pUqbQePveppBGQdEw=; b=tp0tdt6/H2GLCGlRnPCcSP 8rqvOJRVFL4dpHscL4XPeQNuA8C+Ik+UI48jSjPz2fbdb3ieehNukO29NdP5a5Gw DOEqTWwlVCLYr7AVDcAnDO/2qqCaA9/rybp0a2AMSkH6e6Nh1iRQ9a/SM330IvAK z3pYZi/FLNFXXD3dktC7sR43Uhb1hD6UrI0S15ZUwMkxk+hiqrPd6LAKWDPB/1FV I8YxfhdfNw7TPuDeBOii2ef/YlhAMnRkiKY7St5GaLdzfAua8hxkfO3ngQ8CtJS3 bRQKD4ks/EWjr7loPth7ntGGuqnyH0qrBcOP3rE+kODCYLtar45LqQnAicFI17UA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtdeigdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A6DF306006D; Fri, 3 Jul 2020 08:17:08 -0400 (EDT) Date: Fri, 3 Jul 2020 14:17:06 +0200 From: Maxime Ripard To: Ondrej Jirman Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Message-ID: <20200703121706.gf2yxfe7crleatlm@gilmour.lan> References: <20200702081432.1727696-1-megous@megous.com> <20200702081432.1727696-3-megous@megous.com> MIME-Version: 1.0 In-Reply-To: <20200702081432.1727696-3-megous@megous.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_081715_862935_9814E14F X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Samuel Holland , Linus Walleij , Bhushan Shah , linux-kernel@vger.kernel.org, Luca Weiss , Martijn Braam , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============8529780213148423660==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8529780213148423660== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cxgywaqrrd6jmrsp" Content-Disposition: inline --cxgywaqrrd6jmrsp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote: > Pinephone has a Goodix GT917S capacitive touchscreen controller on > I2C0 bus. Add support for it. >=20 > Signed-off-by: Ondrej Jirman > Acked-by: Linus Walleij > --- > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/ar= ch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > index a89425ad3727..5c7386566053 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > @@ -121,6 +121,25 @@ &ehci1 { > status =3D "okay"; > }; > =20 > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins>; > + status =3D "okay"; I didn't spot this earlier, but the pinctrl properties are already set in the DTSI. I've removed them while applying the patch. Thanks! Maxime --cxgywaqrrd6jmrsp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXv8hwQAKCRDj7w1vZxhR xZHoAQDeaPm5c6iWX8CcvBcL8Vrae7EAun13r2RrsQbElBt06AD/RGPN7dt9hGp8 nvnWM3MC/4nwVVPKFdGRLOiTy6Tg1AI= =+CVs -----END PGP SIGNATURE----- --cxgywaqrrd6jmrsp-- --===============8529780213148423660== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8529780213148423660==--