From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35DCC433DF for ; Fri, 3 Jul 2020 14:13:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E41920884 for ; Fri, 3 Jul 2020 14:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593785638; bh=PsIKumf3rYwghoEYKnSPlB30VQJPntaNJu+MX4yG8zU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zrd5AtKxsxgLTp5fAJl8ouP/Xn7HLyk2s1FkTl5el5LM4FNuElduAP+DMZO87U4hi ejGLC14uAcztZ8AdKd8Ae2eL44jhxOj6imHT2QQx/tATvhIH56nRBJGXb6LPNHrfgH n6VTa1l3tUxKsxJLsDdE12cVoGUVvb+Ghlii7mgY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbgGCON5 (ORCPT ); Fri, 3 Jul 2020 10:13:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:45712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbgGCON5 (ORCPT ); Fri, 3 Jul 2020 10:13:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1D46206BE; Fri, 3 Jul 2020 14:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593785636; bh=PsIKumf3rYwghoEYKnSPlB30VQJPntaNJu+MX4yG8zU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wz2RQlj56qd9dwtqd+LeV7sedWyVH2ZPMf1HK2LvrTbdZ/TkJjSZboqSrWkT3CbsY M/j5gN40UqBhZTJdjMBXNnwzN+hZ6ZA3JraAyIADJHmIi8shJNlL5uXryraYIwSYKv kfDYLyjG0YPFnDAzP/3JXd/j7j2aSBwvyL0O26Hg= Date: Fri, 3 Jul 2020 16:13:59 +0200 From: Greg KH To: Daeho Jeong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Subject: Re: [PATCH v3] f2fs: add symbolic link to kobject in sysfs Message-ID: <20200703141359.GA2953162@kroah.com> References: <20200703065420.3544269-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200703065420.3544269-1-daeho43@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 03, 2020 at 03:54:20PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added a symbolic link to directory of sysfs. It will > create a symbolic link such as "mount_0" and "mount_1" to > each f2fs mount in the order of mounting filesystem. But > once one mount point was umounted, that sequential number > @x in "mount_@x" could be reused by later newly mounted > point. It will provide easy access to sysfs node even if > not knowing the specific device node name like sda19 and > dm-3. > > Signed-off-by: Daeho Jeong > --- > Documentation/filesystems/f2fs.rst | 13 ++++++++++++- No Documentation/ABI/ entry for your new sysfs file/link? And what does this help with? If it's really needed, why don't we do this for all filesystem types? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA8AC433DF for ; Fri, 3 Jul 2020 14:14:08 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBFCC206BE; Fri, 3 Jul 2020 14:14:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="h9GXFJZE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="apCHH6ap"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wz2RQlj5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBFCC206BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jrMS6-0003qu-3D; Fri, 03 Jul 2020 14:14:06 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrMS4-0003qn-Ug for linux-f2fs-devel@lists.sourceforge.net; Fri, 03 Jul 2020 14:14:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u+gpTnkYAnNsVZQwtMPSe0ZFnSOa/OUqPW48RJAccnM=; b=h9GXFJZE9XQpnUm/f53gIHEMo5 Nx0aTL9BRb9ra2t7UAUO7Q3JGuhAfbqx0McBAzUqwmpXvsc7Df2ZHpnjiYjzXbayY/9nSEk7hQ9jl 5np6HUttriJ66H2FKuvdT0ez8Rz5fknrek9mSsE9vVEkHMKsgJhGoi2i3i+YAu67mm2w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u+gpTnkYAnNsVZQwtMPSe0ZFnSOa/OUqPW48RJAccnM=; b=apCHH6apdRaAhAcOuX2StwGZsI QuHiMWXMPHHiHPVEa2cU+tbgJr8RHp7OOzn+aUpYgryPa5YvzNjMqj82sjnMeV2zi9IAfcTVf9wJk 4OjjMHY/85ihOM1RDUrrgss/NB84zQKIahpTtuqUrB5MFqEsjPKAAyCtctQMaKgmP+xs=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jrMS3-00C136-Mx for linux-f2fs-devel@lists.sourceforge.net; Fri, 03 Jul 2020 14:14:04 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1D46206BE; Fri, 3 Jul 2020 14:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593785636; bh=PsIKumf3rYwghoEYKnSPlB30VQJPntaNJu+MX4yG8zU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wz2RQlj56qd9dwtqd+LeV7sedWyVH2ZPMf1HK2LvrTbdZ/TkJjSZboqSrWkT3CbsY M/j5gN40UqBhZTJdjMBXNnwzN+hZ6ZA3JraAyIADJHmIi8shJNlL5uXryraYIwSYKv kfDYLyjG0YPFnDAzP/3JXd/j7j2aSBwvyL0O26Hg= Date: Fri, 3 Jul 2020 16:13:59 +0200 From: Greg KH To: Daeho Jeong Message-ID: <20200703141359.GA2953162@kroah.com> References: <20200703065420.3544269-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200703065420.3544269-1-daeho43@gmail.com> X-Headers-End: 1jrMS3-00C136-Mx Subject: Re: [f2fs-dev] [PATCH v3] f2fs: add symbolic link to kobject in sysfs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Jul 03, 2020 at 03:54:20PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added a symbolic link to directory of sysfs. It will > create a symbolic link such as "mount_0" and "mount_1" to > each f2fs mount in the order of mounting filesystem. But > once one mount point was umounted, that sequential number > @x in "mount_@x" could be reused by later newly mounted > point. It will provide easy access to sysfs node even if > not knowing the specific device node name like sda19 and > dm-3. > > Signed-off-by: Daeho Jeong > --- > Documentation/filesystems/f2fs.rst | 13 ++++++++++++- No Documentation/ABI/ entry for your new sysfs file/link? And what does this help with? If it's really needed, why don't we do this for all filesystem types? thanks, greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel