From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: [PATCH v6 00/26] arm64: Memory Tagging Extension user-space support Date: Fri, 3 Jul 2020 16:36:52 +0100 Message-ID: <20200703153718.16973-1-catalin.marinas@arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: Received: from mail.kernel.org ([198.145.29.99]:40540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgGCPhW (ORCPT ); Fri, 3 Jul 2020 11:37:22 -0400 Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-arm-kernel@lists.infradead.org Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, Will Deacon , Dave P Martin , Vincenzo Frascino , Szabolcs Nagy , Kevin Brodsky , Andrey Konovalov , Peter Collingbourne , Andrew Morton This is version 6 (5th version here [1]) of the series adding user-space support for the ARMv8.5 Memory Tagging Extension ([2], [3]). The patches are also available on this branch: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux for-next/mte There are no ABI changes since v4/v5. I'll push these patches into linux-next for wider coverage, aiming for merging into 5.9. There are still some acks needed on the core mm and fs patches in the series. Thanks for the review/acks on v5. An important note, patch 7 introduces a core mm change to __split_huge_page_tail() so that it transfers the PG_arch_* flags from the head page to the tail ones. My understanding is that it shouldn't break anything but a more informed opinion from the mm folk is needed. Changes in this version: - __split_huge_page_tail() function update to preserve the PG_arch_* flags. - copy_mount_options() simplified with a fall-back to byte-by-byte copying. It turns out we arm64 can't guarantee an exact copy_from_user() with intra-page (tag) faults. - Dropped CONFIG_ARCH_USES_PG_ARCH_2 in favour of simply guarding PG_arch_2 by CONFIG_64BIT. - Added comments on where the new arch_swap_* and __HAVE_ARCH_SWAP_* macros should be defined by the arch code if they need to be overridden. - Fixed broken rebase conflict resolution in v5 re-introducing asm-generic/pgtable.h. - Added the acks received so far. [1] https://lore.kernel.org/linux-arm-kernel/20200624175244.25837-1-catalin.marinas@arm.com/ [2] https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/posts/enhancing-memory-safety [3] https://developer.arm.com/-/media/Arm%20Developer%20Community/PDF/Arm_Memory_Tagging_Extension_Whitepaper.pdf [4] https://sourceware.org/pipermail/libc-alpha/2020-June/115039.html Catalin Marinas (14): arm64: mte: Use Normal Tagged attributes for the linear map mm: Preserve the PG_arch_* flags in __split_huge_page_tail() arm64: mte: Clear the tags when a page is mapped in user-space with PROT_MTE arm64: Avoid unnecessary clear_user_page() indirection arm64: mte: Tags-aware aware memcmp_pages() implementation arm64: mte: Add PROT_MTE support to mmap() and mprotect() mm: Introduce arch_validate_flags() arm64: mte: Validate the PROT_MTE request via arch_validate_flags() mm: Allow arm64 mmap(PROT_MTE) on RAM-based files arm64: mte: Allow user control of the tag check mode via prctl() arm64: mte: Allow user control of the generated random tags via prctl() arm64: mte: Restore the GCR_EL1 register after a suspend arm64: mte: Add PTRACE_{PEEK,POKE}MTETAGS support fs: Handle intra-page faults in copy_mount_options() Kevin Brodsky (1): mm: Introduce arch_calc_vm_flag_bits() Steven Price (4): mm: Add PG_arch_2 page flag mm: Add arch hooks for saving/restoring tags arm64: mte: Enable swap of tagged pages arm64: mte: Save tags when hibernating Vincenzo Frascino (7): arm64: mte: system register definitions arm64: mte: CPU feature detection and initial sysreg configuration arm64: mte: Add specific SIGSEGV codes arm64: mte: Handle synchronous and asynchronous tag check faults arm64: mte: Tags-aware copy_{user_,}highpage() implementations arm64: mte: Kconfig entry arm64: mte: Add Memory Tagging Extension documentation Documentation/arm64/cpu-feature-registers.rst | 2 + Documentation/arm64/elf_hwcaps.rst | 4 + Documentation/arm64/index.rst | 1 + .../arm64/memory-tagging-extension.rst | 297 ++++++++++++++++ arch/arm64/Kconfig | 28 ++ arch/arm64/include/asm/cpucaps.h | 3 +- arch/arm64/include/asm/cpufeature.h | 6 + arch/arm64/include/asm/hwcap.h | 1 + arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/memory.h | 17 +- arch/arm64/include/asm/mman.h | 56 ++- arch/arm64/include/asm/mte.h | 86 +++++ arch/arm64/include/asm/page.h | 19 +- arch/arm64/include/asm/pgtable-prot.h | 2 + arch/arm64/include/asm/pgtable.h | 46 ++- arch/arm64/include/asm/processor.h | 4 + arch/arm64/include/asm/sysreg.h | 61 ++++ arch/arm64/include/asm/thread_info.h | 4 +- arch/arm64/include/uapi/asm/hwcap.h | 1 + arch/arm64/include/uapi/asm/mman.h | 1 + arch/arm64/include/uapi/asm/ptrace.h | 4 + arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/cpufeature.c | 61 ++++ arch/arm64/kernel/cpuinfo.c | 1 + arch/arm64/kernel/entry.S | 37 ++ arch/arm64/kernel/hibernate.c | 118 +++++++ arch/arm64/kernel/mte.c | 331 ++++++++++++++++++ arch/arm64/kernel/process.c | 31 +- arch/arm64/kernel/ptrace.c | 9 +- arch/arm64/kernel/signal.c | 9 + arch/arm64/kernel/suspend.c | 4 + arch/arm64/kernel/syscall.c | 10 + arch/arm64/lib/Makefile | 2 + arch/arm64/lib/mte.S | 151 ++++++++ arch/arm64/mm/Makefile | 1 + arch/arm64/mm/copypage.c | 25 +- arch/arm64/mm/dump.c | 4 + arch/arm64/mm/fault.c | 9 +- arch/arm64/mm/mmu.c | 22 +- arch/arm64/mm/mteswap.c | 83 +++++ arch/arm64/mm/proc.S | 8 +- arch/x86/kernel/signal_compat.c | 2 +- fs/namespace.c | 25 +- fs/proc/page.c | 3 + fs/proc/task_mmu.c | 4 + include/linux/kernel-page-flags.h | 1 + include/linux/mm.h | 8 + include/linux/mman.h | 23 +- include/linux/page-flags.h | 3 + include/linux/pgtable.h | 28 ++ include/trace/events/mmflags.h | 9 +- include/uapi/asm-generic/siginfo.h | 4 +- include/uapi/linux/prctl.h | 9 + mm/huge_memory.c | 4 + mm/mmap.c | 9 + mm/mprotect.c | 6 + mm/page_io.c | 10 + mm/shmem.c | 9 + mm/swapfile.c | 2 + mm/util.c | 2 +- tools/vm/page-types.c | 2 + 61 files changed, 1678 insertions(+), 48 deletions(-) create mode 100644 Documentation/arm64/memory-tagging-extension.rst create mode 100644 arch/arm64/include/asm/mte.h create mode 100644 arch/arm64/kernel/mte.c create mode 100644 arch/arm64/lib/mte.S create mode 100644 arch/arm64/mm/mteswap.c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E278CC433DF for ; Fri, 3 Jul 2020 15:39:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACEA921534 for ; Fri, 3 Jul 2020 15:39:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BGqK0cqD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACEA921534 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=q31JxWH6ZJcdzEbY60etNCtrnkalrroeUFkzeJD73vQ=; b=BGqK0cqDv/qVwPhFqVfSEJAHsD rfz3TM5/dnXlATpnb7u888PVsJ7E9yAkmBOjNXBy8g08ll5RRGnwaU6+cJrtYUxmmK5moa6US5h4S WuK5VZzZfK1hDypSb1zOEES9mzWBYBRcwEbDo7jmFG7h0hfCXvk4Us3dNbpZRtLBmxw9R9q8XSmZe ZfPCP2aiD5Sy17Z/l7OOmDWWzQmVqHa4Xgl0occp+uAjRInQ4Eq8+q9i2pp6VFUSoCKPP3LfjEOdF 4YEt+XU3A9uG6Vu0Gdu3bDpkAFwIw4BaUCipq7OdqstcDsbzVAMK0yrWJqvuDj1b/wyQiQ42Eyjub MjoCZuGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrNkl-000143-Jh; Fri, 03 Jul 2020 15:37:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrNkh-000122-1z for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 15:37:24 +0000 Received: from localhost.localdomain (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2D1421534; Fri, 3 Jul 2020 15:37:19 +0000 (UTC) From: Catalin Marinas To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 00/26] arm64: Memory Tagging Extension user-space support Date: Fri, 3 Jul 2020 16:36:52 +0100 Message-Id: <20200703153718.16973-1-catalin.marinas@arm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_113723_241116_3CF8979D X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Szabolcs Nagy , Andrey Konovalov , Kevin Brodsky , Peter Collingbourne , linux-mm@kvack.org, Andrew Morton , Vincenzo Frascino , Will Deacon , Dave P Martin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is version 6 (5th version here [1]) of the series adding user-space support for the ARMv8.5 Memory Tagging Extension ([2], [3]). The patches are also available on this branch: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux for-next/mte There are no ABI changes since v4/v5. I'll push these patches into linux-next for wider coverage, aiming for merging into 5.9. There are still some acks needed on the core mm and fs patches in the series. Thanks for the review/acks on v5. An important note, patch 7 introduces a core mm change to __split_huge_page_tail() so that it transfers the PG_arch_* flags from the head page to the tail ones. My understanding is that it shouldn't break anything but a more informed opinion from the mm folk is needed. Changes in this version: - __split_huge_page_tail() function update to preserve the PG_arch_* flags. - copy_mount_options() simplified with a fall-back to byte-by-byte copying. It turns out we arm64 can't guarantee an exact copy_from_user() with intra-page (tag) faults. - Dropped CONFIG_ARCH_USES_PG_ARCH_2 in favour of simply guarding PG_arch_2 by CONFIG_64BIT. - Added comments on where the new arch_swap_* and __HAVE_ARCH_SWAP_* macros should be defined by the arch code if they need to be overridden. - Fixed broken rebase conflict resolution in v5 re-introducing asm-generic/pgtable.h. - Added the acks received so far. [1] https://lore.kernel.org/linux-arm-kernel/20200624175244.25837-1-catalin.marinas@arm.com/ [2] https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/posts/enhancing-memory-safety [3] https://developer.arm.com/-/media/Arm%20Developer%20Community/PDF/Arm_Memory_Tagging_Extension_Whitepaper.pdf [4] https://sourceware.org/pipermail/libc-alpha/2020-June/115039.html Catalin Marinas (14): arm64: mte: Use Normal Tagged attributes for the linear map mm: Preserve the PG_arch_* flags in __split_huge_page_tail() arm64: mte: Clear the tags when a page is mapped in user-space with PROT_MTE arm64: Avoid unnecessary clear_user_page() indirection arm64: mte: Tags-aware aware memcmp_pages() implementation arm64: mte: Add PROT_MTE support to mmap() and mprotect() mm: Introduce arch_validate_flags() arm64: mte: Validate the PROT_MTE request via arch_validate_flags() mm: Allow arm64 mmap(PROT_MTE) on RAM-based files arm64: mte: Allow user control of the tag check mode via prctl() arm64: mte: Allow user control of the generated random tags via prctl() arm64: mte: Restore the GCR_EL1 register after a suspend arm64: mte: Add PTRACE_{PEEK,POKE}MTETAGS support fs: Handle intra-page faults in copy_mount_options() Kevin Brodsky (1): mm: Introduce arch_calc_vm_flag_bits() Steven Price (4): mm: Add PG_arch_2 page flag mm: Add arch hooks for saving/restoring tags arm64: mte: Enable swap of tagged pages arm64: mte: Save tags when hibernating Vincenzo Frascino (7): arm64: mte: system register definitions arm64: mte: CPU feature detection and initial sysreg configuration arm64: mte: Add specific SIGSEGV codes arm64: mte: Handle synchronous and asynchronous tag check faults arm64: mte: Tags-aware copy_{user_,}highpage() implementations arm64: mte: Kconfig entry arm64: mte: Add Memory Tagging Extension documentation Documentation/arm64/cpu-feature-registers.rst | 2 + Documentation/arm64/elf_hwcaps.rst | 4 + Documentation/arm64/index.rst | 1 + .../arm64/memory-tagging-extension.rst | 297 ++++++++++++++++ arch/arm64/Kconfig | 28 ++ arch/arm64/include/asm/cpucaps.h | 3 +- arch/arm64/include/asm/cpufeature.h | 6 + arch/arm64/include/asm/hwcap.h | 1 + arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/memory.h | 17 +- arch/arm64/include/asm/mman.h | 56 ++- arch/arm64/include/asm/mte.h | 86 +++++ arch/arm64/include/asm/page.h | 19 +- arch/arm64/include/asm/pgtable-prot.h | 2 + arch/arm64/include/asm/pgtable.h | 46 ++- arch/arm64/include/asm/processor.h | 4 + arch/arm64/include/asm/sysreg.h | 61 ++++ arch/arm64/include/asm/thread_info.h | 4 +- arch/arm64/include/uapi/asm/hwcap.h | 1 + arch/arm64/include/uapi/asm/mman.h | 1 + arch/arm64/include/uapi/asm/ptrace.h | 4 + arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/cpufeature.c | 61 ++++ arch/arm64/kernel/cpuinfo.c | 1 + arch/arm64/kernel/entry.S | 37 ++ arch/arm64/kernel/hibernate.c | 118 +++++++ arch/arm64/kernel/mte.c | 331 ++++++++++++++++++ arch/arm64/kernel/process.c | 31 +- arch/arm64/kernel/ptrace.c | 9 +- arch/arm64/kernel/signal.c | 9 + arch/arm64/kernel/suspend.c | 4 + arch/arm64/kernel/syscall.c | 10 + arch/arm64/lib/Makefile | 2 + arch/arm64/lib/mte.S | 151 ++++++++ arch/arm64/mm/Makefile | 1 + arch/arm64/mm/copypage.c | 25 +- arch/arm64/mm/dump.c | 4 + arch/arm64/mm/fault.c | 9 +- arch/arm64/mm/mmu.c | 22 +- arch/arm64/mm/mteswap.c | 83 +++++ arch/arm64/mm/proc.S | 8 +- arch/x86/kernel/signal_compat.c | 2 +- fs/namespace.c | 25 +- fs/proc/page.c | 3 + fs/proc/task_mmu.c | 4 + include/linux/kernel-page-flags.h | 1 + include/linux/mm.h | 8 + include/linux/mman.h | 23 +- include/linux/page-flags.h | 3 + include/linux/pgtable.h | 28 ++ include/trace/events/mmflags.h | 9 +- include/uapi/asm-generic/siginfo.h | 4 +- include/uapi/linux/prctl.h | 9 + mm/huge_memory.c | 4 + mm/mmap.c | 9 + mm/mprotect.c | 6 + mm/page_io.c | 10 + mm/shmem.c | 9 + mm/swapfile.c | 2 + mm/util.c | 2 +- tools/vm/page-types.c | 2 + 61 files changed, 1678 insertions(+), 48 deletions(-) create mode 100644 Documentation/arm64/memory-tagging-extension.rst create mode 100644 arch/arm64/include/asm/mte.h create mode 100644 arch/arm64/kernel/mte.c create mode 100644 arch/arm64/lib/mte.S create mode 100644 arch/arm64/mm/mteswap.c _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel