From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8E1C433E0 for ; Fri, 3 Jul 2020 17:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50FDC20899 for ; Fri, 3 Jul 2020 17:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593796245; bh=DLKxsllCedsKXDxzh2iPko52HqauiEp1c7CtqKnE4Mo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ikTlWfcJR9RLiZIw0pOzwgMlJGZhS+mo+HeuB5V5EKfEcbkmBoIa+ld1S3kebfMDH tjpZvhplmOOTQZV443F+2oaRXvud05WEnTMkrygMY4AH0TrPcBbXgk+F+iIni6uODL I3cfrmuhOgE8LHbFAwyysm3YVVOciBpP1lBhlxlY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726999AbgGCRKo (ORCPT ); Fri, 3 Jul 2020 13:10:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgGCRKo (ORCPT ); Fri, 3 Jul 2020 13:10:44 -0400 Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85BA820708; Fri, 3 Jul 2020 17:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593796243; bh=DLKxsllCedsKXDxzh2iPko52HqauiEp1c7CtqKnE4Mo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wjnf7swcrrxLWudGUqF+P9B/nJbj72EVjqUrxaV4Dq+8K9vGrmKe6A9sNSNh9WSB5 cugeNnMVabsO9KU0cSAp++tZYEVHlw8OHFmddGwS7sw1HezC9sLjCiUn6pOljHtuNn NTIFF1mKRmzfC7dBsR0CQ2tf0+fl9NHpL0nzPNlI= Date: Fri, 3 Jul 2020 22:40:39 +0530 From: Vinod Koul To: Laurent Pinchart Cc: dmaengine@vger.kernel.org, Michal Simek , Hyun Kwon , Tejas Upadhyay , Satish Kumar Nagireddy , Peter Ujfalusi Subject: Re: [PATCH v5 3/6] dmaengine: Add support for repeating transactions Message-ID: <20200703171039.GO273932@vkoul-mobl> References: <20200528025228.31638-1-laurent.pinchart@ideasonboard.com> <20200528025228.31638-4-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528025228.31638-4-laurent.pinchart@ideasonboard.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Laurent, On 28-05-20, 05:52, Laurent Pinchart wrote: > @@ -176,6 +178,18 @@ struct dma_interleaved_template { > * @DMA_PREP_CMD: tell the driver that the data passed to DMA API is command > * data and the descriptor should be in different format from normal > * data descriptors. > + * @DMA_PREP_REPEAT: tell the driver that the transaction shall be automatically > + * repeated when it ends if no other transaction has been issued on the same > + * channel. If other transactions have been issued, this transaction completes > + * normally. This flag is only applicable to interleaved transactions and is > + * ignored for all other transaction types. 1. Let us not restrict this to only interleave (hint we can in future replace cyclic API) 2. DMA_PREP_REPEAT telling the transaction shall be automatically repeated is okay. No issues with that > + * @DMA_PREP_LOAD_EOT: tell the driver that the transaction shall replaced any s/replaced/replace > + * active repeated (as indicated by DMA_PREP_REPEAT) transaction when the > + * repeated transaction terminate. Not setting this flag when the previously > + * queued transaction is marked with DMA_PREP_REPEAT will cause the new > + * transaction to never be processed and stay in the issued queue forever. > + * The flag is ignored if the previous transaction is not a repeated > + * transaction. I am happy with this bit, I think we dont need to specify something like DMA_PREP_LOAD_NEXT given the explanation here, so adding DMA_PREP_LOAD_EOT would mean that. Can we add a corresponding EOB as well to complete this -- ~Vinod