From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 925F1C433E0 for ; Fri, 3 Jul 2020 22:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B0BD208C7 for ; Fri, 3 Jul 2020 22:17:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/toDlrR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbgGCWRr (ORCPT ); Fri, 3 Jul 2020 18:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726188AbgGCWRr (ORCPT ); Fri, 3 Jul 2020 18:17:47 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0D98C061794; Fri, 3 Jul 2020 15:17:46 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id a9so3938883pjh.5; Fri, 03 Jul 2020 15:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sejNlP1ktqM/yqhWQBlfvEYEbrTSoZNaZ4fFsOcMXyo=; b=M/toDlrRcsBGClLXYYdtDWkvG3zMdTI3iAiO+yGwHaD7RuH8ssfG3JkLAjRNJ3GOgL emfRB5ok5rhARi30EPkLIJcne0S6+vyf89L+daajIxm+3jV32o1nm7IMWZ/2BXs17A+p ppSQXeUl+n57RSdqkEiPjuzk+ER8PF5bE8YfGaknJwHPyseEYDYisKCkHmRlQDZOnsGL 8K8+SmPmDePzNISqaV0VptSe623mvWiiMHkXcNeuetOL1zOFL0SZe5EzlKSLuy1Dls1m hyKXBzq0ZbT6WFWRlmi0TVHcdRVB8zcnl2+L7kP7RXrRg8E8mti3kbXcTke3CVrClKei QYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sejNlP1ktqM/yqhWQBlfvEYEbrTSoZNaZ4fFsOcMXyo=; b=rIJKZtU6M1VQR4+ENI/8M+nELVzQo5CdtptW6zihiRlw1s3jToKiRjvYCfhT0o6N0d QYVuRfDWCMFXoApawpWQpKeEnhuSgky3YX1Qc3rZANJ2UMwwObZPD1oNlD52xOfA+XkJ dW3+lcmXTTULrCUK0pLj0IptEP7dhRwwL4gQU25QEw/Xb7igapM/fy1xgE8XB/xFhCDw S4JsuxsRYqSPHksZHpOZbcyK5MA50TUj4hT9epehv6GQSGXCmicsNenMx1NNgFxi16YK 08Z1B3bwc2P3HyQEY6bO/WjIuI0Kwz53eCon9ajnatFZMO34eAPrkbNDK2/aoeMDiQQ+ 9aOQ== X-Gm-Message-State: AOAM5330dq6pDoRykj5Dr3PnX8Um7XKX6DPhMdqgNmhq3p75r4pESdPU 9GDKZeQQhLq6tSLHLmksV8zVk6nWOYQ= X-Google-Smtp-Source: ABdhPJwd/f3TDfBVQj4VriwSYuAQ/lXojI58EaxlEBXVyYKB7TscoLWXYlzy0uHffDXMh89/mAefyQ== X-Received: by 2002:a17:90a:718b:: with SMTP id i11mr37047631pjk.150.1593814665429; Fri, 03 Jul 2020 15:17:45 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k2sm12728448pgm.11.2020.07.03.15.17.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Jul 2020 15:17:45 -0700 (PDT) Date: Fri, 3 Jul 2020 15:17:44 -0700 From: Guenter Roeck To: Evgeny Novikov Cc: Jean Delvare , Joel Stanley , Andrew Jeffery , linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow Message-ID: <20200703221744.GA34644@roeck-us.net> References: <20200703111518.9644-1-novikov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200703111518.9644-1-novikov@ispras.ru> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, Jul 03, 2020 at 02:15:18PM +0300, Evgeny Novikov wrote: > aspeed_create_fan() reads a pwm_port value using of_property_read_u32(). > If pwm_port will be more than ARRAY_SIZE(pwm_port_params), there will be > a buffer overflow in > aspeed_create_pwm_port()->aspeed_set_pwm_port_enable(). The patch fixes > the potential buffer overflow. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Applied. Thanks, Guenter > --- > drivers/hwmon/aspeed-pwm-tacho.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c > index 33fb54845bf6..3d8239fd66ed 100644 > --- a/drivers/hwmon/aspeed-pwm-tacho.c > +++ b/drivers/hwmon/aspeed-pwm-tacho.c > @@ -851,6 +851,8 @@ static int aspeed_create_fan(struct device *dev, > ret = of_property_read_u32(child, "reg", &pwm_port); > if (ret) > return ret; > + if (pwm_port >= ARRAY_SIZE(pwm_port_params)) > + return -EINVAL; > aspeed_create_pwm_port(priv, (u8)pwm_port); > > ret = of_property_count_u8_elems(child, "cooling-levels"); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113ABC433DF for ; Fri, 3 Jul 2020 22:19:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFB422145D for ; Fri, 3 Jul 2020 22:18:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1CyGANWk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/toDlrR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFB422145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MIbtV7MJ/Od2jrzHcicnoaZDJzuOd7Hd9RcXdC2DMqQ=; b=1CyGANWkm6u9pVpIYWyrfBQmw bduId+IkpIw11Y9r+NJyobl/odjch3gGuzfz5fw+A63Gsk6umUvdZIUP/AK87/obOazAOew1xjq11 llfSN0moRgrLE6fEN/3qL8V7Ju2weA3vVzJI9F0F3no1yuNs5botvXlXdSQ4MdYjXulmqxo+ke0Cc iOP/INXobjO5si74LZJP1CZzUoFFPRnr6TCxR7ii6JDNwugG2+ZYRQfjE7t1rh1JvT9gZtzAS7p0C Ix/j3u0mFPkB/F8KVH9qQXsAoa2AnsjUUWHHh4QFlTQ4PXnLi/L0UHAGVim7d7U1oZ6UW96Mc/v7o A7cRVZNkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrU0E-0001Fr-Qd; Fri, 03 Jul 2020 22:17:50 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrU0C-0001F0-IX for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 22:17:49 +0000 Received: by mail-pl1-x644.google.com with SMTP id s14so13067173plq.6 for ; Fri, 03 Jul 2020 15:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sejNlP1ktqM/yqhWQBlfvEYEbrTSoZNaZ4fFsOcMXyo=; b=M/toDlrRcsBGClLXYYdtDWkvG3zMdTI3iAiO+yGwHaD7RuH8ssfG3JkLAjRNJ3GOgL emfRB5ok5rhARi30EPkLIJcne0S6+vyf89L+daajIxm+3jV32o1nm7IMWZ/2BXs17A+p ppSQXeUl+n57RSdqkEiPjuzk+ER8PF5bE8YfGaknJwHPyseEYDYisKCkHmRlQDZOnsGL 8K8+SmPmDePzNISqaV0VptSe623mvWiiMHkXcNeuetOL1zOFL0SZe5EzlKSLuy1Dls1m hyKXBzq0ZbT6WFWRlmi0TVHcdRVB8zcnl2+L7kP7RXrRg8E8mti3kbXcTke3CVrClKei QYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sejNlP1ktqM/yqhWQBlfvEYEbrTSoZNaZ4fFsOcMXyo=; b=jsIX1IU+u/L+ZSWT55I4aRg5/Ar7CrlzVz41oVv6ixJwVSL78ibLiZrmji/q19KDyG mAQZA4sGLgBhKMcgVmyJtDTT+sKWYLCzbi1eMI7u0s+pWLxRvJuKgmGng2diNf+F3sYS lUQSn8rcNBZHSm8ps0PK9WK3Sb/KKHP6HzXtrI9+eflLljroNoflqnBUUnsifuPLhQRZ 6bLyDN5cTGwoSjOkrHa1j+6bPrzaCZjX9OsY0ZGlQX7Z3DMy7eXJ1LuZibGg1a9LG0es BTA2PF/N/22yuPsb3+SH/IkP5cScSG4x252HkaqDC8gpkhxPncg25VqSd28Dy9Fspvno cK5Q== X-Gm-Message-State: AOAM530J6bYp7PPHu8CF0/SP0wstCMcJSuQQziQbCM+9yEzpkiRSlOTU K0kjIotRIN+epSGf0/vuQSg= X-Google-Smtp-Source: ABdhPJwd/f3TDfBVQj4VriwSYuAQ/lXojI58EaxlEBXVyYKB7TscoLWXYlzy0uHffDXMh89/mAefyQ== X-Received: by 2002:a17:90a:718b:: with SMTP id i11mr37047631pjk.150.1593814665429; Fri, 03 Jul 2020 15:17:45 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k2sm12728448pgm.11.2020.07.03.15.17.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Jul 2020 15:17:45 -0700 (PDT) Date: Fri, 3 Jul 2020 15:17:44 -0700 From: Guenter Roeck To: Evgeny Novikov Subject: Re: [PATCH] hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow Message-ID: <20200703221744.GA34644@roeck-us.net> References: <20200703111518.9644-1-novikov@ispras.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200703111518.9644-1-novikov@ispras.ru> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_181748_637934_448CB1EF X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, ldv-project@linuxtesting.org, Jean Delvare , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , linux-kernel@vger.kernel.org, Joel Stanley , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 03, 2020 at 02:15:18PM +0300, Evgeny Novikov wrote: > aspeed_create_fan() reads a pwm_port value using of_property_read_u32(). > If pwm_port will be more than ARRAY_SIZE(pwm_port_params), there will be > a buffer overflow in > aspeed_create_pwm_port()->aspeed_set_pwm_port_enable(). The patch fixes > the potential buffer overflow. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Applied. Thanks, Guenter > --- > drivers/hwmon/aspeed-pwm-tacho.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c > index 33fb54845bf6..3d8239fd66ed 100644 > --- a/drivers/hwmon/aspeed-pwm-tacho.c > +++ b/drivers/hwmon/aspeed-pwm-tacho.c > @@ -851,6 +851,8 @@ static int aspeed_create_fan(struct device *dev, > ret = of_property_read_u32(child, "reg", &pwm_port); > if (ret) > return ret; > + if (pwm_port >= ARRAY_SIZE(pwm_port_params)) > + return -EINVAL; > aspeed_create_pwm_port(priv, (u8)pwm_port); > > ret = of_property_count_u8_elems(child, "cooling-levels"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel