All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH] iio: adis16480: Use irq types instead of flags
Date: Sat, 4 Jul 2020 17:43:11 +0100	[thread overview]
Message-ID: <20200704174311.1da73b83@archlinux> (raw)
In-Reply-To: <20200701120702.365-1-nuno.sa@analog.com>

On Wed, 1 Jul 2020 14:07:02 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> The value retrieved by `irqd_get_trigger_type()` is not an irq flag.
> While the values are the same, the meaning is different.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to poke at it.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/adis16480.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index 5163749f568e..1eb4f98076f1 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -1102,12 +1102,12 @@ static int adis16480_config_irq_pin(struct device_node *of_node,
>  	/*
>  	 * Get the interrupt line behaviour. The data ready polarity can be
>  	 * configured as positive or negative, corresponding to
> -	 * IRQF_TRIGGER_RISING or IRQF_TRIGGER_FALLING respectively.
> +	 * IRQ_TYPE_EDGE_RISING or IRQ_TYPE_EDGE_FALLING respectively.
>  	 */
>  	irq_type = irqd_get_trigger_type(desc);
> -	if (irq_type == IRQF_TRIGGER_RISING) { /* Default */
> +	if (irq_type == IRQ_TYPE_EDGE_RISING) { /* Default */
>  		val |= ADIS16480_DRDY_POL(1);
> -	} else if (irq_type == IRQF_TRIGGER_FALLING) {
> +	} else if (irq_type == IRQ_TYPE_EDGE_FALLING) {
>  		val |= ADIS16480_DRDY_POL(0);
>  	} else {
>  		dev_err(&st->adis.spi->dev,


      reply	other threads:[~2020-07-04 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 12:07 [PATCH] iio: adis16480: Use irq types instead of flags Nuno Sá
2020-07-04 16:43 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200704174311.1da73b83@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.