From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB6FC433E0 for ; Mon, 6 Jul 2020 05:50:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BF35206E6 for ; Mon, 6 Jul 2020 05:50:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0eZxjIOl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MDCyk5Yq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BF35206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y+NUcZwRG8lEZDAbcb37xN2YT2r/IQtSFQZOZsh33Ns=; b=0eZxjIOleEo1NqcDVUnjzPoWN IgGVxk22hDQkOsQMj7RRr0GiUJMy83N2/m4ETvolBop3G1O3asHhFjzwvtr4oSMUTZNDN1iDolvWg WizTcwdwt5R275TsB6FBeCGKX5rYKlgCU27xtHCtQM8CizU3lLJGtJY3j9LklLtU/jM7hldfj2d7s Dt66RwNT35X7NIs9h1bX5MAtXYzRH4fWTU0eRm6nqJHUG0nYaufDiQL7+PaVi4nwIwz2h7GoX45qX A9GU6X4MB3bFfaPZitjjYgqo/FX4RNQoNu/Um+pmOPukW0KbjvyQEa24t3fgPcNmHD+trJSkDMRwm 0bTTJs/Ew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsJzG-0003c4-21; Mon, 06 Jul 2020 05:48:19 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsJz8-0003ZI-El for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 05:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594014490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QpIMne7SJiTcVxKbD28trTYpKVnK2HH1XZoyUkaBEXQ=; b=MDCyk5Yq55JVL1WcM+RZ7gdlUAOdS+t6h48hGarOoMY76Ca8O2AjNWXLysbP7JLl4T46n9 rFRf4PGvbc15OLgDZczlyV0ow53O/I2dBDg9YeABDcJdTEXUyiXEOAHzKa+NcJXi1LIViM 67L1aj8h3H6NuBpFUHdqv795PgPedsE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-jmZQctS-Pi-VNNsh66Udzw-1; Mon, 06 Jul 2020 01:48:06 -0400 X-MC-Unique: jmZQctS-Pi-VNNsh66Udzw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1C24800D5C; Mon, 6 Jul 2020 05:48:04 +0000 (UTC) Received: from localhost.localdomain.com (vpn2-54-159.bne.redhat.com [10.64.54.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF022C0DBA; Mon, 6 Jul 2020 05:48:02 +0000 (UTC) From: Gavin Shan To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/14] drivers/firmware/sdei: Drop redundant error message in sdei_probe() Date: Mon, 6 Jul 2020 15:47:24 +1000 Message-Id: <20200706054732.99387-7-gshan@redhat.com> In-Reply-To: <20200706054732.99387-1-gshan@redhat.com> References: <20200706054732.99387-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=gshan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_014810_585450_5404E1AD X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, will@kernel.org, james.morse@arm.com, shan.gavin@gmail.com, catalin.marinas@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This drops the redundant error message in sdei_probe() because the situation can be indicated by the error number from next error message. The function scoped variables are reorder according to their importance by the way. Signed-off-by: Gavin Shan --- drivers/firmware/arm_sdei.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index ca0e3f5eb907..28bc712ba71d 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -935,17 +935,15 @@ int sdei_unregister_ghes(struct ghes *ghes) static int sdei_probe(struct platform_device *pdev) { - int err; - u64 ver = 0; int conduit; + u64 ver = 0; + int err; conduit = acpi_psci_use_hvc() ? SMCCC_CONDUIT_HVC : SMCCC_CONDUIT_SMC; sdei_firmware_call = acpi_psci_use_hvc() ? &sdei_smccc_hvc : &sdei_smccc_smc; err = sdei_api_get_version(&ver); - if (err == -EOPNOTSUPP) - pr_err("advertised but not implemented in platform firmware\n"); if (err) { pr_err("Failed to get SDEI version: %d\n", err); sdei_mark_interface_broken(); -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel