From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4288DC433DF for ; Mon, 6 Jul 2020 13:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E2C920720 for ; Mon, 6 Jul 2020 13:35:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OmZFfKsZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729559AbgGFNfy (ORCPT ); Mon, 6 Jul 2020 09:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729301AbgGFNeB (ORCPT ); Mon, 6 Jul 2020 09:34:01 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C408C061794 for ; Mon, 6 Jul 2020 06:34:01 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id j18so39372154wmi.3 for ; Mon, 06 Jul 2020 06:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=OmZFfKsZE3nw2Rx7QazBJNlNeA+U8z1Z2PcNhcqjoK68z1sVetkUL2vJdCbMgfCx+z GQ5OdTbXa+xGGweQRAIjQY+yIMbO16Ik2oUI+cRDjkln/G96vTY+Sv3Hmg9wjeMj9Moe wjup2WRBceFy+RvHDn6sGC88K+miXgtBtFdiQiKW7ax7JwncaSGkDlPgFdll46+6/YiB c2Hvox1thv7IHBF2cFtkUXRSO0tVbQdaKgKzefw5AxbQcMOI86AnSy5xCXNu/8SdAEfj tMQN++j0iRkOEy/9hGk3KCKGViLlrFbGp+lhcUlgAE3JBu5bqpBfe9atSyQizMIJsTA+ txEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=pXNzFbTM73od0U8JDOiCI2JVUq4DGDyWg/bEq0iNQER9J7cE7zYsRlBpvU3N0HBi0z /ZBqcLIwcyONlRorEaDSOoPaPe5ZCXB1cwWdL9k48+eKNTrEdcU7UdmpPqE1gq9MQEb2 XV9wBNnORpPSMW21F69XvS9r446nXCCb5BuxUp3g5qobQ7Ugm+e6JDTWsJfLMv2N8goJ 5Ltcn6nbCO+BFHGo6BF3OJG6Yx1IpJaOlazSa+XdysQhZySgOlK7uLVqEtw+vbnBKeq4 +nIFp7slfDOmcXexzSfztCe9TO1KfCkR2lzZrcFo2+rgaoea0rG/3Oo9C19XuklHE0yA Crpg== X-Gm-Message-State: AOAM531zeQf/5gCVAfsRs5ChyJfPeHj4BO/S946PeM3Su0lpUEbhKRt1 zit5n1P+ekWs4vXqUdKrMj2qIw== X-Google-Smtp-Source: ABdhPJzHeQs23/qyFcnX4TERiDrg/KCZCBqe16Wspkyc46J1cIxb5+c8wXVxLRMwjJxdzWxMdM1HWA== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416268wmh.121.1594042440115; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Yoshihiro Shimoda Subject: [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Date: Mon, 6 Jul 2020 14:33:22 +0100 Message-Id: <20200706133341.476881-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks like it's been this way since the driver's inception in 2007. Fixes the following W=1 kernel build warning(s): drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’: drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] 478 | u16 tmp; | ^~~ Cc: Yoshihiro Shimoda Signed-off-by: Lee Jones --- drivers/usb/host/r8a66597-hcd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index 0c03ac6b02137..63719cdf6a4e6 100644 --- a/drivers/usb/host/r8a66597-hcd.c +++ b/drivers/usb/host/r8a66597-hcd.c @@ -475,16 +475,14 @@ static void pipe_stop(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) static void clear_all_buffer(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) { - u16 tmp; - if (!pipe || pipe->info.pipenum == 0) return; pipe_stop(r8a66597, pipe); r8a66597_bset(r8a66597, ACLRM, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); r8a66597_bclr(r8a66597, ACLRM, pipe->pipectr); } -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D20AC433E0 for ; Mon, 6 Jul 2020 13:37:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18377206F5 for ; Mon, 6 Jul 2020 13:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zmoSzK+G"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OmZFfKsZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18377206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gn+jStk1qZg8t1ve/6xSWhZw7kXq+gPg5VsMT0YGmX0=; b=zmoSzK+GwezZkXzp+CTZ3J/Eg g5I6cgW2lp7koD+HHRowuvcU6YIEiY8D2knaqoFE7bjbpa2YpjGqFm85z6FYSYaQdNuyPEKOkDZ0s g0e/Kg5aBexfumABl65IMdccR7B6W4VxKFJ3o3TNkuHI5rSeIV7GOQ9Q7AVihaqSGr5sK4W26FpQs 6LAkx3sPyjLxf2D4WdFEqR/ZV13koseGF9LWGfzJrvXh9Fkvj1V2rkaXdoShQtFrtZPj/TI0Tsc5b 5LJ8EpoqcWnT1hFpgGZ5lSdwboCiM6PFaV4xx44Bs9PxEpW6OcZVrZeHOr+M3W7UFA7ozOazrVAil xE1xxI/9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRHS-0000c9-4V; Mon, 06 Jul 2020 13:35:34 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFx-0008Ei-5S for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:04 +0000 Received: by mail-wm1-x343.google.com with SMTP id o8so39367323wmh.4 for ; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=OmZFfKsZE3nw2Rx7QazBJNlNeA+U8z1Z2PcNhcqjoK68z1sVetkUL2vJdCbMgfCx+z GQ5OdTbXa+xGGweQRAIjQY+yIMbO16Ik2oUI+cRDjkln/G96vTY+Sv3Hmg9wjeMj9Moe wjup2WRBceFy+RvHDn6sGC88K+miXgtBtFdiQiKW7ax7JwncaSGkDlPgFdll46+6/YiB c2Hvox1thv7IHBF2cFtkUXRSO0tVbQdaKgKzefw5AxbQcMOI86AnSy5xCXNu/8SdAEfj tMQN++j0iRkOEy/9hGk3KCKGViLlrFbGp+lhcUlgAE3JBu5bqpBfe9atSyQizMIJsTA+ txEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=ochUlcE0geJU0l8j7gQOl6b8xSPcHhz/11noLyhZ+1D77laRbGMbfLGfXYUibEtNbu 6gnKXjI92O76hX3s8SMUfqIxkrs75RHY7sxtTbjm1o8ZFRUrHzTje0uimAZTmm9q6jJm 6fgkJVXwPJak7xQ8Xeri+tpNprDcP0ETX8+GCkFnHWeEqT+PLmpvZs43YVWtAssRK2PK Uzz2KQFzokE029RoKqwKgbGdIaEISC3zyiiQBAbv6iUVHe/hkCRiwLirzBuE2qvDaLbf XcS7WEINXhWoBTRMDVzaB/4acfAyjpaOpiHjW6PBzuyaBWKsCh6g3gcuPIT6v+5/rWhl cBcw== X-Gm-Message-State: AOAM530zrPh5OWlm2CRj/nRl7owKaxaHa8XgqLJhVTtd58Z61cTPsFIX Xx7pJeeBlWWOLcSHwhtXX7rHhQ== X-Google-Smtp-Source: ABdhPJzHeQs23/qyFcnX4TERiDrg/KCZCBqe16Wspkyc46J1cIxb5+c8wXVxLRMwjJxdzWxMdM1HWA== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416268wmh.121.1594042440115; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Date: Mon, 6 Jul 2020 14:33:22 +0100 Message-Id: <20200706133341.476881-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093401_277794_E77DEBA0 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshihiro Shimoda , linux-usb@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TG9va3MgbGlrZSBpdCdzIGJlZW4gdGhpcyB3YXkgc2luY2UgdGhlIGRyaXZlcidzIGluY2VwdGlv biBpbiAyMDA3LgoKRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmco cyk6CgogZHJpdmVycy91c2IvaG9zdC9yOGE2NjU5Ny1oY2QuYzogSW4gZnVuY3Rpb24g4oCYY2xl YXJfYWxsX2J1ZmZlcuKAmToKIGRyaXZlcnMvdXNiL2hvc3QvcjhhNjY1OTctaGNkLmM6NDc4OjY6 IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHRtcOKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1i dXQtc2V0LXZhcmlhYmxlXQogNDc4IHwgdTE2IHRtcDsKIHwgXn5+CgpDYzogWW9zaGloaXJvIFNo aW1vZGEgPHlvc2hpaGlyby5zaGltb2RhLnVoQHJlbmVzYXMuY29tPgpTaWduZWQtb2ZmLWJ5OiBM ZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgotLS0KIGRyaXZlcnMvdXNiL2hvc3Qvcjhh NjY1OTctaGNkLmMgfCA4ICsrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2hvc3QvcjhhNjY1OTct aGNkLmMgYi9kcml2ZXJzL3VzYi9ob3N0L3I4YTY2NTk3LWhjZC5jCmluZGV4IDBjMDNhYzZiMDIx MzcuLjYzNzE5Y2RmNmE0ZTYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL2hvc3QvcjhhNjY1OTct aGNkLmMKKysrIGIvZHJpdmVycy91c2IvaG9zdC9yOGE2NjU5Ny1oY2QuYwpAQCAtNDc1LDE2ICs0 NzUsMTQgQEAgc3RhdGljIHZvaWQgcGlwZV9zdG9wKHN0cnVjdCByOGE2NjU5NyAqcjhhNjY1OTcs IHN0cnVjdCByOGE2NjU5N19waXBlICpwaXBlKQogc3RhdGljIHZvaWQgY2xlYXJfYWxsX2J1ZmZl cihzdHJ1Y3QgcjhhNjY1OTcgKnI4YTY2NTk3LAogCQkJICAgICBzdHJ1Y3QgcjhhNjY1OTdfcGlw ZSAqcGlwZSkKIHsKLQl1MTYgdG1wOwotCiAJaWYgKCFwaXBlIHx8IHBpcGUtPmluZm8ucGlwZW51 bSA9PSAwKQogCQlyZXR1cm47CiAKIAlwaXBlX3N0b3AocjhhNjY1OTcsIHBpcGUpOwogCXI4YTY2 NTk3X2JzZXQocjhhNjY1OTcsIEFDTFJNLCBwaXBlLT5waXBlY3RyKTsKLQl0bXAgPSByOGE2NjU5 N19yZWFkKHI4YTY2NTk3LCBwaXBlLT5waXBlY3RyKTsKLQl0bXAgPSByOGE2NjU5N19yZWFkKHI4 YTY2NTk3LCBwaXBlLT5waXBlY3RyKTsKLQl0bXAgPSByOGE2NjU5N19yZWFkKHI4YTY2NTk3LCBw aXBlLT5waXBlY3RyKTsKKwlyOGE2NjU5N19yZWFkKHI4YTY2NTk3LCBwaXBlLT5waXBlY3RyKTsK KwlyOGE2NjU5N19yZWFkKHI4YTY2NTk3LCBwaXBlLT5waXBlY3RyKTsKKwlyOGE2NjU5N19yZWFk KHI4YTY2NTk3LCBwaXBlLT5waXBlY3RyKTsKIAlyOGE2NjU5N19iY2xyKHI4YTY2NTk3LCBBQ0xS TSwgcGlwZS0+cGlwZWN0cik7CiB9CiAKLS0gCjIuMjUuMQoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK