From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D44C433E0 for ; Mon, 6 Jul 2020 13:35:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF46B206F5 for ; Mon, 6 Jul 2020 13:35:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWvdvBnN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729351AbgGFNeP (ORCPT ); Mon, 6 Jul 2020 09:34:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729330AbgGFNeJ (ORCPT ); Mon, 6 Jul 2020 09:34:09 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB43EC08C5DF for ; Mon, 6 Jul 2020 06:34:08 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g75so39363845wme.5 for ; Mon, 06 Jul 2020 06:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=zWvdvBnN7uGI3YJYG8xAKLYiRJh1mm0+0r6YAQ/ht+c+2n5/aaoZ24CrC6+hTOq75q UZgksZ/ftaNvfFjflqPGT6LMkwCqQ9dhF/YRFHAvqu+DdxqoYp7Ex3s1nB1x0kw/i8Wy 2EWBhwE38eGBFN2TO5wcJ4Q22ru3uU3QZ8WgSOUDl0W5yggF2tD93sA22eOBatapWahz hIdy7n8K4yNPhE7VlJWZ1XdjDn1HYu1O7Ot1DZPO9MIdEvoyXtF65q5zuvF5LY1rfRHI zO4HmtSixQQmvk/yfC0Oeo3PAQMsM6lPTWYiYiuQvARvCD45XF9IVh8ATkXIOd6W0kfn nG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=gguwB3ky4YztPm9LfjICzGmyOPGWbnkYNRLuhItWjfSq/jF6WYopD5rbVNMoOwqj0x Tx2zVHLLQk/Ak5imTyRv2pvlkeyjncdTI87sl0kvgwmKmrcTBQimkQ4R2BXSWra8Yvx1 3QP3ME0zPin9q/q2kqecvQuIALKYnpSTXr+c6BGCQjMhgM5NIbUbPwsO/zOZgeFVTgU4 kEbi02cLw2BAdpeB2P6/wGGAUxjoMpcgc+C/oXoihIk8pl2tWblLmlUcM9Gb5Jl7L5DM Q9Nxl5WHsmuTHavhlo0y2Xh4rtA+Hyg+uk/r+XV22FphdROJx4tYmAW2WbNFyowVzbAA dWrg== X-Gm-Message-State: AOAM531P7/mmIxvaANB2jRVMVX9ge51UbZqyfqZqmjfvXIiyqLHx/Kkx woiz139DcBtEbfZIMH5v5KwfSw== X-Google-Smtp-Source: ABdhPJweO4LHH0YuesEFBL8qRBzNi8brrKp2TuduBLyEDI7/Vj9+MgTEjdpThiWYval39YIjbESx5Q== X-Received: by 2002:a1c:8117:: with SMTP id c23mr47262716wmd.157.1594042447424; Mon, 06 Jul 2020 06:34:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:06 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Bryan Wu Subject: [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:28 +0100 Message-Id: <20200706133341.476881-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup' drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup' Cc: Felipe Balbi Cc: Bryan Wu Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c index 5393e5c37a4ba..60ae8b2d3f6a2 100644 --- a/drivers/usb/gadget/function/u_uac1_legacy.c +++ b/drivers/usb/gadget/function/u_uac1_legacy.c @@ -23,7 +23,7 @@ /*-------------------------------------------------------------------------*/ -/** +/* * Some ALSA internal helper functions */ static int snd_interval_refine_set(struct snd_interval *i, unsigned int val) @@ -86,7 +86,7 @@ static int _snd_pcm_hw_param_set(struct snd_pcm_hw_params *params, } /*-------------------------------------------------------------------------*/ -/** +/* * Set default hardware params */ static int playback_default_hw_params(struct gaudio_snd_dev *snd) @@ -146,7 +146,7 @@ static int playback_default_hw_params(struct gaudio_snd_dev *snd) return 0; } -/** +/* * Playback audio buffer data by ALSA PCM device */ size_t u_audio_playback(struct gaudio *card, void *buf, size_t count) @@ -189,7 +189,7 @@ int u_audio_get_playback_rate(struct gaudio *card) return card->playback.rate; } -/** +/* * Open ALSA PCM and control device files * Initial the PCM or control device */ @@ -250,7 +250,7 @@ static int gaudio_open_snd_dev(struct gaudio *card) return 0; } -/** +/* * Close ALSA PCM and control device files */ static int gaudio_close_snd_dev(struct gaudio *gau) @@ -275,7 +275,7 @@ static int gaudio_close_snd_dev(struct gaudio *gau) return 0; } -/** +/* * gaudio_setup - setup ALSA interface and preparing for USB transfer * * This sets up PCM, mixer or MIDI ALSA devices fore USB gadget using. @@ -294,7 +294,7 @@ int gaudio_setup(struct gaudio *card) } -/** +/* * gaudio_cleanup - remove ALSA device interface * * This is called to free all resources allocated by @gaudio_setup(). -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE54C433E0 for ; Mon, 6 Jul 2020 13:39:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 018D0206F5 for ; Mon, 6 Jul 2020 13:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dkVc5A86"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWvdvBnN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 018D0206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PHqqlzRo1XR+mH3DX3YSuZAv0Wxk1ojQC7nc4laHQIM=; b=dkVc5A86tk/cTOYIolW9CZ40/ XPVlEaIXwv8Q8r6v4fG56pLDbgzZU3sWcWbWOVqt/rmIkblYt4BCEIGnwb/OrIMZZRqEqu6ghub6e MhEj8vFXk1NuX5oOtvzHnrqxVdZKKV0/YkCDCgfSMZQ3auwy4YqCI1BCVeluFiYw+VixbKrJGZJqA KL0qEwSQPAUEat0lumE4M+GcbUGACfhXWbDcs2mmDQv1jU2kRoyxGvifnkLc0oDMpjr8zljVW73DI sTIaa2EDDomSyoa/LUM2lnUDi+wcR5Qpc7nckiZ4MqAV3OZcIFN4D0tU3io7yQQXokmGs3N+4ouyy 6QVD39v9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRJU-0001zO-NL; Mon, 06 Jul 2020 13:37:40 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG4-0008Hr-C6 for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:13 +0000 Received: by mail-wm1-x344.google.com with SMTP id q15so39371185wmj.2 for ; Mon, 06 Jul 2020 06:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=zWvdvBnN7uGI3YJYG8xAKLYiRJh1mm0+0r6YAQ/ht+c+2n5/aaoZ24CrC6+hTOq75q UZgksZ/ftaNvfFjflqPGT6LMkwCqQ9dhF/YRFHAvqu+DdxqoYp7Ex3s1nB1x0kw/i8Wy 2EWBhwE38eGBFN2TO5wcJ4Q22ru3uU3QZ8WgSOUDl0W5yggF2tD93sA22eOBatapWahz hIdy7n8K4yNPhE7VlJWZ1XdjDn1HYu1O7Ot1DZPO9MIdEvoyXtF65q5zuvF5LY1rfRHI zO4HmtSixQQmvk/yfC0Oeo3PAQMsM6lPTWYiYiuQvARvCD45XF9IVh8ATkXIOd6W0kfn nG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=TE13jUdCjCj22fz5JJnWeAIfZjf3I9G3lPD/OKuo2kEa8V9/mm0GDa4f5UmvFLBx4P p6RQNwsgo2fL+PxlgfQ1GtO7A5s76FP0hsQ2TFMBtEwrzK6TY82biqGKgUReQmmS3Pww 0KpZ9nUQ1l8gZFhbaqLPTZ402PxLzbb0BM6++MZUcawKayIC/F079HUhxbLZjYfKazSK Etbz0XU/Dqy/Bx3XeaLdUUhbriP19x3zm/LN23zwWett+nN7aP3+N6nsxqN2q+W7R+q6 bn+7+RkI5Ag6155WDfw7sme19ftg8pKDvirbmiPFk5DD6erbLi0uudYFfcqZDOdl3TBu xaKQ== X-Gm-Message-State: AOAM531xJacbSK/jeSTW27xYxtCL8IYzQfz857e/ry9jPTT8r4etzYjR AGDTdxDLW44h9PWd2ZVwtQvcbQ== X-Google-Smtp-Source: ABdhPJweO4LHH0YuesEFBL8qRBzNi8brrKp2TuduBLyEDI7/Vj9+MgTEjdpThiWYval39YIjbESx5Q== X-Received: by 2002:a1c:8117:: with SMTP id c23mr47262716wmd.157.1594042447424; Mon, 06 Jul 2020 06:34:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:06 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:28 +0100 Message-Id: <20200706133341.476881-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093408_512622_B365C811 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Bryan Wu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup' drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup' Cc: Felipe Balbi Cc: Bryan Wu Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c index 5393e5c37a4ba..60ae8b2d3f6a2 100644 --- a/drivers/usb/gadget/function/u_uac1_legacy.c +++ b/drivers/usb/gadget/function/u_uac1_legacy.c @@ -23,7 +23,7 @@ /*-------------------------------------------------------------------------*/ -/** +/* * Some ALSA internal helper functions */ static int snd_interval_refine_set(struct snd_interval *i, unsigned int val) @@ -86,7 +86,7 @@ static int _snd_pcm_hw_param_set(struct snd_pcm_hw_params *params, } /*-------------------------------------------------------------------------*/ -/** +/* * Set default hardware params */ static int playback_default_hw_params(struct gaudio_snd_dev *snd) @@ -146,7 +146,7 @@ static int playback_default_hw_params(struct gaudio_snd_dev *snd) return 0; } -/** +/* * Playback audio buffer data by ALSA PCM device */ size_t u_audio_playback(struct gaudio *card, void *buf, size_t count) @@ -189,7 +189,7 @@ int u_audio_get_playback_rate(struct gaudio *card) return card->playback.rate; } -/** +/* * Open ALSA PCM and control device files * Initial the PCM or control device */ @@ -250,7 +250,7 @@ static int gaudio_open_snd_dev(struct gaudio *card) return 0; } -/** +/* * Close ALSA PCM and control device files */ static int gaudio_close_snd_dev(struct gaudio *gau) @@ -275,7 +275,7 @@ static int gaudio_close_snd_dev(struct gaudio *gau) return 0; } -/** +/* * gaudio_setup - setup ALSA interface and preparing for USB transfer * * This sets up PCM, mixer or MIDI ALSA devices fore USB gadget using. @@ -294,7 +294,7 @@ int gaudio_setup(struct gaudio *card) } -/** +/* * gaudio_cleanup - remove ALSA device interface * * This is called to free all resources allocated by @gaudio_setup(). -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel