From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C793C433E0 for ; Mon, 6 Jul 2020 13:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE2A220702 for ; Mon, 6 Jul 2020 13:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xDhKb4d1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729374AbgGFNeV (ORCPT ); Mon, 6 Jul 2020 09:34:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729347AbgGFNeO (ORCPT ); Mon, 6 Jul 2020 09:34:14 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D2CAC061755 for ; Mon, 6 Jul 2020 06:34:13 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id w3so29668343wmi.4 for ; Mon, 06 Jul 2020 06:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=xDhKb4d1kq4g63PE6Kw+d0pJTKLnw/IIJQRWCvGGBRKLAySHr3nXCYdnP0FF+KYdgl vilMW0c0k6s1Ego/Dne9r8otV3SFOpks3w1DdJX6EPTI97pwdrKlIb2UKkbKdM3aDVlj oSrJ9yzAacAEyGyCdl7WGdOS1ZgDlhAHAlm1LeHkd9CpJeixRsVwXY0hZ/8oKIB1aA7R tQf8xNsPpdj7GOKICfWv8NpWcwtVpUjJFXZFlcmBUynkOisE2Sqp7YJSGA42CjzUdB7j d48tqL2Z+IA4acMLvxU18EamPKiWgdTtUL2LpLPFNEyrurJ1mT7m8OpdBkl5rzIdpn3b 0snA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=msfdj+b6SfcS15KbkaG8uNxbQ2CuCDa2zCFvnSBr+u3kG50QanyfDqiRVwPpIQnjuh dVw5H0jUnygnMihxA89Wnsp9ZM6HNP6gf8iU0PdWCb+67fAKqB59ycMBLEetzx03DGfZ Ydf96rjeiKmxnKdq2Wn0VSiAuz/Emx8KRCxnXVU/hIIpLg9jfWhEgSTV+yuCoc+77uJX I42av2Kn+Yzq2f8KAhE9tPJIBsadifP7f40HFlT8YkfL3UUYhDB6T+0frI6Mjh1TZSbQ zQmEzaAEh+ZCp55oVQAJIwkD7tf7PoDI6icMoKsErhG1wGpc4XjKNibOdwm98kUvKMQ/ 8/Uw== X-Gm-Message-State: AOAM530OtbpW12pjSnXiuxYsMaKIbV2yeQmO9W18GcjnZE8MVfTb/MZx GkRUdzXNOUprOtWsYhQ50YcfmvvxVP0= X-Google-Smtp-Source: ABdhPJz+ya1juxEYdu8hRa5da9rRY9b7wU9z75P/hBna1EEO/zxK6KolWddZ+pI9eP30hH8G324USg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112738wma.4.1594042452163; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:11 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Jassi Brar , Christophe JAILLET Subject: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Date: Mon, 6 Jul 2020 14:33:32 +0100 Message-Id: <20200706133341.476881-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’: drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable] 626 | u8 addr; | ^~~~ Cc: Felipe Balbi Cc: Jassi Brar Cc: Christophe JAILLET Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/max3420_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/max3420_udc.c b/drivers/usb/gadget/udc/max3420_udc.c index 23f33946d80c4..52884bae4af11 100644 --- a/drivers/usb/gadget/udc/max3420_udc.c +++ b/drivers/usb/gadget/udc/max3420_udc.c @@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc) static void max3420_handle_setup(struct max3420_udc *udc) { struct usb_ctrlrequest setup; - u8 addr; spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8); @@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc) USB_TYPE_STANDARD | USB_RECIP_DEVICE)) { break; } - addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue); return; case USB_REQ_CLEAR_FEATURE: -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664E5C433E0 for ; Mon, 6 Jul 2020 13:41:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AB90206F5 for ; Mon, 6 Jul 2020 13:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ne46kQBH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xDhKb4d1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AB90206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=spyirFgNvYuHXnk8iiAC//r2Qvc/0yy7DMZT8orcGc4=; b=Ne46kQBHj38z6eLwhJICnGHV7 R4RTliGwG5Upv1xN4ZcaYnPTSeNBkAgm6GjsBCunRm2zgEUO2gcgEapjNlwkrJ+MTUHBq4Jqohf9r pTiQfCFJTcN3FmXdAAKS7IigbYt8immPkyt3fRkIztq0hEm4UyR6fuTfBXJ98aUfbsJ/GNRYskMD1 PhwZAGaQciUu1XoTlMr00PjRuOgeWw150+D8pGTJ9T6i3A5Sanr51BI3MAPLYOlyijff7z1hBTZi6 BLwFxaHEFyK8ZPB6MxBEgW23M9VuCGYJNVQEHcvA5Ncll0sh3jjw2NxZ8h14q45X3jlGUskDTr0as MHZPZvvnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRKD-0002bM-Va; Mon, 06 Jul 2020 13:38:26 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRG9-0008KP-4k for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:34:17 +0000 Received: by mail-wm1-x341.google.com with SMTP id g75so39364146wme.5 for ; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=xDhKb4d1kq4g63PE6Kw+d0pJTKLnw/IIJQRWCvGGBRKLAySHr3nXCYdnP0FF+KYdgl vilMW0c0k6s1Ego/Dne9r8otV3SFOpks3w1DdJX6EPTI97pwdrKlIb2UKkbKdM3aDVlj oSrJ9yzAacAEyGyCdl7WGdOS1ZgDlhAHAlm1LeHkd9CpJeixRsVwXY0hZ/8oKIB1aA7R tQf8xNsPpdj7GOKICfWv8NpWcwtVpUjJFXZFlcmBUynkOisE2Sqp7YJSGA42CjzUdB7j d48tqL2Z+IA4acMLvxU18EamPKiWgdTtUL2LpLPFNEyrurJ1mT7m8OpdBkl5rzIdpn3b 0snA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=Vt5v2K583/cQ9arBK+rsPiNQmlu5WJ2YUCVjs5GMAqvR7bmePKlHGNFwGOZcWMHyVe 6bkAhdAcJpb7rsAPWjdYNxMQXrgWKY5WdRYe03YuQEHC39LMUG0KeBBq6DwHRii6QdqN VlFHIRA7gQ16HMgybgkju5L0JML/0TKhEcjb6nTTeQplaXE7+wEWYwzhdeUPCLlHu2oo oIe0OYp9YmsVBuyMVh3Fk8fXp7UTg5Oum+JasFXXy7LnqKtvUb90jZllZLeNNkHc93aE VhS37OZLlk81vcWwPgk8rehvMojTV9N/JVrZO+aoDVQNPjVfCJbPX+erNKVFmK5E4pCs Dpzw== X-Gm-Message-State: AOAM530DXAh75+gNtpM0uj8YCdaVXFI0darUbknL4LJhGhE3LTSveum2 H9kEAiwGQ1tfyOL71lCU1KtVdw== X-Google-Smtp-Source: ABdhPJz+ya1juxEYdu8hRa5da9rRY9b7wU9z75P/hBna1EEO/zxK6KolWddZ+pI9eP30hH8G324USg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112738wma.4.1594042452163; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:11 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Date: Mon, 6 Jul 2020 14:33:32 +0100 Message-Id: <20200706133341.476881-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093414_703627_C546E0C9 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jassi Brar , Christophe JAILLET , Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6CgogZHJpdmVy cy91c2IvZ2FkZ2V0L3VkYy9tYXgzNDIwX3VkYy5jOiBJbiBmdW5jdGlvbiDigJhtYXgzNDIwX2hh bmRsZV9zZXR1cOKAmToKIGRyaXZlcnMvdXNiL2dhZGdldC91ZGMvbWF4MzQyMF91ZGMuYzo2MjY6 NTogd2FybmluZzogdmFyaWFibGUg4oCYYWRkcuKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNl ZC1idXQtc2V0LXZhcmlhYmxlXQogNjI2IHwgdTggYWRkcjsKIHwgXn5+fgoKQ2M6IEZlbGlwZSBC YWxiaSA8YmFsYmlAa2VybmVsLm9yZz4KQ2M6IEphc3NpIEJyYXIgPGphc3dpbmRlci5zaW5naEBs aW5hcm8ub3JnPgpDYzogQ2hyaXN0b3BoZSBKQUlMTEVUIDxjaHJpc3RvcGhlLmphaWxsZXRAd2Fu YWRvby5mcj4KU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4K LS0tCiBkcml2ZXJzL3VzYi9nYWRnZXQvdWRjL21heDM0MjBfdWRjLmMgfCAzICstLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdXNiL2dhZGdldC91ZGMvbWF4MzQyMF91ZGMuYyBiL2RyaXZlcnMvdXNiL2dhZGdldC91 ZGMvbWF4MzQyMF91ZGMuYwppbmRleCAyM2YzMzk0NmQ4MGM0Li41Mjg4NGJhZTRhZjExIDEwMDY0 NAotLS0gYS9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL21heDM0MjBfdWRjLmMKKysrIGIvZHJpdmVy cy91c2IvZ2FkZ2V0L3VkYy9tYXgzNDIwX3VkYy5jCkBAIC02MjMsNyArNjIzLDYgQEAgc3RhdGlj IHZvaWQgbWF4MzQyMF9zZXRfY2xlYXJfZmVhdHVyZShzdHJ1Y3QgbWF4MzQyMF91ZGMgKnVkYykK IHN0YXRpYyB2b2lkIG1heDM0MjBfaGFuZGxlX3NldHVwKHN0cnVjdCBtYXgzNDIwX3VkYyAqdWRj KQogewogCXN0cnVjdCB1c2JfY3RybHJlcXVlc3Qgc2V0dXA7Ci0JdTggYWRkcjsKIAogCXNwaV9y ZF9idWYodWRjLCBNQVgzNDIwX1JFR19TVURGSUZPLCAodm9pZCAqKSZzZXR1cCwgOCk7CiAKQEAg LTY0Nyw3ICs2NDYsNyBAQCBzdGF0aWMgdm9pZCBtYXgzNDIwX2hhbmRsZV9zZXR1cChzdHJ1Y3Qg bWF4MzQyMF91ZGMgKnVkYykKIAkJCQlVU0JfVFlQRV9TVEFOREFSRCB8IFVTQl9SRUNJUF9ERVZJ Q0UpKSB7CiAJCQlicmVhazsKIAkJfQotCQlhZGRyID0gc3BpX3JkOF9hY2sodWRjLCBNQVgzNDIw X1JFR19GTkFERFIsIDEpOworCQlzcGlfcmQ4X2Fjayh1ZGMsIE1BWDM0MjBfUkVHX0ZOQUREUiwg MSk7CiAJCWRldl9kYmcodWRjLT5kZXYsICJBc3NpZ25lZCBBZGRyZXNzPSVkXG4iLCB1ZGMtPnNl dHVwLndWYWx1ZSk7CiAJCXJldHVybjsKIAljYXNlIFVTQl9SRVFfQ0xFQVJfRkVBVFVSRToKLS0g CjIuMjUuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK