From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B909C433DF for ; Mon, 6 Jul 2020 14:20:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD64E2070B for ; Mon, 6 Jul 2020 14:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ed6Jrprb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbgGFOUz (ORCPT ); Mon, 6 Jul 2020 10:20:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729140AbgGFOUz (ORCPT ); Mon, 6 Jul 2020 10:20:55 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1968AC061794 for ; Mon, 6 Jul 2020 07:20:55 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f18so42382113wml.3 for ; Mon, 06 Jul 2020 07:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/SQQ7AOqnp0abV0mTui8yYrs1UAgtqLR05qcleZcwQE=; b=Ed6JrprbDjk8AXD6SCOI9yh0CysVyAtZO2nt/f6l1uLVAF7tPqo9QHp4648VE6/P0J iJd3+qHMbx5g2R1VjGTps0BZqc1+nkfAtJ/DC0I/fty8HyNAXW3hQewEgWXpZQsoLOZd FNf6j1vFI9bDcSZ19YcgSjidaauF0qGEx+UPTOMQVosbA7mKScWrXlbSiIyC8j4b2kTz jQxjB+VuO/AByLPP+2/rnzTx6HTicNZY68TyLXs/k9slS+eZTpkmcJvLRvAKx+JyDmwI PdzTFhyFHuxZvHNiDL4SdAdv6hIll/6VmdF8GZqofG4QIjSUW5v789VNT8yUZRQAyw7i 4C+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/SQQ7AOqnp0abV0mTui8yYrs1UAgtqLR05qcleZcwQE=; b=tEK2atE8nZKLgflxpt5v9jpshdIFdMd/OBilzJWzHMYCa5JrXYxqJ/ZeIKq6493hZb 69P1GXL/wzVf0R4QvUQLzxcWK6g+1TNCtJAM3nEFGZNYRDxOzAyiZFlxio/uVPv59r7X wTp//JgHKAqkLdn5fi4eAtGcIJlwBxbm9rBbv87msBavMyiqXGndzzLrMcUD11mhPShH 7Ujw9scdwYLHazZUGDm2Ercvfj2k8FOYNGfBFKMrLEPqVcG2VwKO8OWML8/GAAgIIXyo lCZG9I17kZrJXZEpbLImP2qaUYEdj35CapVRrH/rLcsskwY/zdatBvFeEq8KXCu9pP3M Wr/g== X-Gm-Message-State: AOAM531ozJh/Dyz9THt90SlaeV4CJla9SQyHhpQmfkOh6VkDg1DL1g27 s3u6YHYs7cHiSY5Xv8AilySVcg== X-Google-Smtp-Source: ABdhPJxttEL31vKF295CqiyvKNlNLZN2K0H1vn3bWACeSCGgEgewna0f80KeGgsIGvd6NVLZTGM+Fw== X-Received: by 2002:a1c:1fd1:: with SMTP id f200mr48281159wmf.162.1594045253749; Mon, 06 Jul 2020 07:20:53 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id x7sm24950797wrr.72.2020.07.06.07.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 07:20:53 -0700 (PDT) Date: Mon, 6 Jul 2020 15:20:51 +0100 From: Lee Jones To: Hans de Goede Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Guenter Roeck , Heikki Krogerus Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Message-ID: <20200706142051.GA3500@dell> References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jul 2020, Hans de Goede wrote: > Hi, > > On 7/6/20 3:33 PM, Lee Jones wrote: > > Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config > > configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' > > last year. No need to keep it around. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] > > 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = { > > | ^~~~~~~~~~~~~~~~ > > > > Cc: Guenter Roeck > > Cc: Heikki Krogerus > > Cc: Hans de Goede > > Signed-off-by: Lee Jones > > This is necessary for adding Display port over Type-C support > on devices using the tcpm code, rather then firmware, to do > the Type-C alt-mode negotiation. > > I have a local patch in my tree which adds support for this. > > But Heikki did not like my approach, so that patch > (which needs the bits you are removing) never landed > upstream: > > https://patchwork.kernel.org/patch/11199517/ > > Which is somewhat old now. Yes, that's a just a little old now. If it drags on for much longer, perhaps consider taking it out for the time being and adding it back when you start to make use of it again? > Heikki said he would look into an approach to this more to > his liking. Heikki an progress on this area? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F0DC433DF for ; Mon, 6 Jul 2020 14:22:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3AAA2070B for ; Mon, 6 Jul 2020 14:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2dfugOWc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ed6Jrprb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3AAA2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0SEWk2WTqw8PrQbHt16j7u4HFODP+XNKE+XymjO3FRY=; b=2dfugOWc/v9bBz46Rs88RByL+ 5JGSlgmQPJ3EWkmyBkj8PxNkTLsnoKsezEGod7tfeTa2bbB+4NHl8gvbO9XLnszClKSt7nNLnWNwI 5Z8R538OoKRTvVh6pQD0iK8qzjno4fwr/plau6NDqoM6GRShrbd/RkB63RUatFl+ziBLUvuq5pJ1D I5DDVlDJaNMjihaLxsMMfqyhOrW47RbNkfui201CRNTQUt+IuPuc3VGH0gnyCt32FTcA3+t2VetYV Z04z5Ui1yGWqNuLmMh+BAOSoMt6QTXcWjp4vB7ymAvHqfT+RnZYVVvhFOQ2F6BBjV7LOh0KvZ+4ci Ywqi5ZLQg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRzO-0003JF-N3; Mon, 06 Jul 2020 14:20:58 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRzK-0003Hv-Vu for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 14:20:56 +0000 Received: by mail-wm1-x343.google.com with SMTP id o8so39579916wmh.4 for ; Mon, 06 Jul 2020 07:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/SQQ7AOqnp0abV0mTui8yYrs1UAgtqLR05qcleZcwQE=; b=Ed6JrprbDjk8AXD6SCOI9yh0CysVyAtZO2nt/f6l1uLVAF7tPqo9QHp4648VE6/P0J iJd3+qHMbx5g2R1VjGTps0BZqc1+nkfAtJ/DC0I/fty8HyNAXW3hQewEgWXpZQsoLOZd FNf6j1vFI9bDcSZ19YcgSjidaauF0qGEx+UPTOMQVosbA7mKScWrXlbSiIyC8j4b2kTz jQxjB+VuO/AByLPP+2/rnzTx6HTicNZY68TyLXs/k9slS+eZTpkmcJvLRvAKx+JyDmwI PdzTFhyFHuxZvHNiDL4SdAdv6hIll/6VmdF8GZqofG4QIjSUW5v789VNT8yUZRQAyw7i 4C+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/SQQ7AOqnp0abV0mTui8yYrs1UAgtqLR05qcleZcwQE=; b=PmDiwBHYhUMppAWITndExqz0AZXrgo5Z7wXIffcLlVcpLXBL9s6qzy04btIHfSY/+j J1SuBHp6obPvsHy5VfecqvRIxGkluqAEgCLHyQtYBk/4BgDbCYF0XMAe1Es6mefKdFBU YUubbOS/ENlIrWkv08ExZLPYD3oqz4cAyR4JqYL94/iqjM9T10ty1KyPGjccQtLlZ4hd fgKZ3sE1Udfc/ea6UVXMF6jpypgoT8AwI1DnjnK9j1jQGCCksOdRsRSdsMfO9hiQvX75 tgomCFkvauuyQymXe23dPI0tVd+UACS9SH+pHoJHDfSDlHR80Dxm5FxFdcjstvlXlQdu O0mQ== X-Gm-Message-State: AOAM533GSbWvACSK2+ElOwDnvjrhDYZxp1HXb/PMi5IOmL/fFNdJ740Z JWTks5rlBpXRTkeolkBhLXiK4g== X-Google-Smtp-Source: ABdhPJxttEL31vKF295CqiyvKNlNLZN2K0H1vn3bWACeSCGgEgewna0f80KeGgsIGvd6NVLZTGM+Fw== X-Received: by 2002:a1c:1fd1:: with SMTP id f200mr48281159wmf.162.1594045253749; Mon, 06 Jul 2020 07:20:53 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id x7sm24950797wrr.72.2020.07.06.07.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 07:20:53 -0700 (PDT) Date: Mon, 6 Jul 2020 15:20:51 +0100 From: Lee Jones To: Hans de Goede Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Message-ID: <20200706142051.GA3500@dell> References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_102055_356333_04E385B4 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNiBKdWwgMjAyMCwgSGFucyBkZSBHb2VkZSB3cm90ZToKCj4gSGksCj4gCj4gT24g Ny82LzIwIDM6MzMgUE0sIExlZSBKb25lcyB3cm90ZToKPiA+IExvb2tzIGFzIHRob3VnaCBhMDc5 OTczZjQ2MmEzICgidXNiOiB0eXBlYzogdGNwbTogUmVtb3ZlIHRjcGNfY29uZmlnCj4gPiBjb25m aWd1cmF0aW9uIG1lY2hhbmlzbSIpIHB1bGxlZCBvdXQgdGhlIG9ubHkgdXNlIG9mICd0Y3BtX2Fs dG1vZGVfb3BzJwo+ID4gbGFzdCB5ZWFyLiAgTm8gbmVlZCB0byBrZWVwIGl0IGFyb3VuZC4KPiA+ IAo+ID4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4g PiAKPiA+ICAgZHJpdmVycy91c2IvdHlwZWMvdGNwbS90Y3BtLmM6MTU1MTozOTogd2FybmluZzog 4oCYdGNwbV9hbHRtb2RlX29wc+KAmSBkZWZpbmVkIGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtY29u c3QtdmFyaWFibGU9XQo+ID4gICAxNTUxIHwgc3RhdGljIGNvbnN0IHN0cnVjdCB0eXBlY19hbHRt b2RlX29wcyB0Y3BtX2FsdG1vZGVfb3BzID0gewo+ID4gICB8IF5+fn5+fn5+fn5+fn5+fn4KPiA+ IAo+ID4gQ2M6IEd1ZW50ZXIgUm9lY2sgPGxpbnV4QHJvZWNrLXVzLm5ldD4KPiA+IENjOiBIZWlr a2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogSGFu cyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBK b25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gCj4gVGhpcyBpcyBuZWNlc3NhcnkgZm9yIGFk ZGluZyBEaXNwbGF5IHBvcnQgb3ZlciBUeXBlLUMgc3VwcG9ydAo+IG9uIGRldmljZXMgdXNpbmcg dGhlIHRjcG0gY29kZSwgcmF0aGVyIHRoZW4gZmlybXdhcmUsIHRvIGRvCj4gdGhlIFR5cGUtQyBh bHQtbW9kZSBuZWdvdGlhdGlvbi4KPiAKPiBJIGhhdmUgYSBsb2NhbCBwYXRjaCBpbiBteSB0cmVl IHdoaWNoIGFkZHMgc3VwcG9ydCBmb3IgdGhpcy4KPiAKPiBCdXQgSGVpa2tpIGRpZCBub3QgbGlr ZSBteSBhcHByb2FjaCwgc28gdGhhdCBwYXRjaAo+ICh3aGljaCBuZWVkcyB0aGUgYml0cyB5b3Ug YXJlIHJlbW92aW5nKSBuZXZlciBsYW5kZWQKPiB1cHN0cmVhbToKPiAKPiBodHRwczovL3BhdGNo d29yay5rZXJuZWwub3JnL3BhdGNoLzExMTk5NTE3Lwo+IAo+IFdoaWNoIGlzIHNvbWV3aGF0IG9s ZCBub3cuCgpZZXMsIHRoYXQncyBhIGp1c3QgYSBsaXR0bGUgb2xkIG5vdy4KCklmIGl0IGRyYWdz IG9uIGZvciBtdWNoIGxvbmdlciwgcGVyaGFwcyBjb25zaWRlciB0YWtpbmcgaXQgb3V0IGZvciB0 aGUKdGltZSBiZWluZyBhbmQgYWRkaW5nIGl0IGJhY2sgd2hlbiB5b3Ugc3RhcnQgdG8gbWFrZSB1 c2Ugb2YgaXQgYWdhaW4/Cgo+IEhlaWtraSBzYWlkIGhlIHdvdWxkIGxvb2sgaW50byBhbiBhcHBy b2FjaCB0byB0aGlzIG1vcmUgdG8KPiBoaXMgbGlraW5nLiBIZWlra2kgYW4gcHJvZ3Jlc3Mgb24g dGhpcyBhcmVhPwoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExl YWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdh cmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK