From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA04C433E0 for ; Mon, 6 Jul 2020 17:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0289020672 for ; Mon, 6 Jul 2020 17:57:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OK6kB8Q0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729759AbgGFR5l (ORCPT ); Mon, 6 Jul 2020 13:57:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729732AbgGFR5h (ORCPT ); Mon, 6 Jul 2020 13:57:37 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1515C061794 for ; Mon, 6 Jul 2020 10:57:36 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z13so42121911wrw.5 for ; Mon, 06 Jul 2020 10:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oTojjIFZzclanf7cLLuaYi/sgvjqGLuwhbXDv27Czb8=; b=OK6kB8Q0qPe86xIOUaHuGwfdS2zOPVnI1nFVI5idSlyGCaQ0kwkLr5OQ3iqaCDrVgp bSOqJkCjp0ec0QS590uLshH3kIWpHf1xbHU4eFZSHTSz2iazne518HLTBvJhqDK56dUJ VfvvqQ499iFKyO7u5d9hnovYGKCEt81Di/gCvWZ/6DEke38vxLl9lqh8sFCeusLjL1Ml 2qR161f3NJOvDObqFI6szLGqFQi4ZzNG3O+MRRM8N5BRRw06NsO/2NWwp4otwehlAyaq GjgvDbYRQdLgMd7gAaG1L8Juu1JYUeppORL67+udHl59TzHLYTVJB6lnzxfeszfPKiFn 3hag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oTojjIFZzclanf7cLLuaYi/sgvjqGLuwhbXDv27Czb8=; b=aJbAI+gJPsXjo4dM+rGojd4K0a4IRncSlrHIeu2B5azhZZCk2mKQSqL8VAI4rst3Sg b+OVhPCFPjtd8GsNUOGtDAfImo0iRo8muKR43HSUQtOSxwOOpLO7hf+Sd6s7BUmsQBeI /9hnptU47mNvWXYMEEJhpA6nMDJ2c49QYvi0Th47AyDcSKwp/3O84me8JSdMTiWdAC/W kShkotdHS/0eBoUC2/cAwOpEJUgcZ/f8XBo2VyO29jrN/YSldV0eGYrs6LbxuqbBT1hT ApPWvfPRjXGZXMehN7pGspRiBwUMKgPjQ8XOBVfZSaM4PHHfXrnIKn0R44+zaLtpv3YI s/mw== X-Gm-Message-State: AOAM532xd1dXs/hZsyp0AY6HvLZySShh2ONYd2qyHSIfkkTj/ig3hj9H ehbUFp14XC+sPGTbMJPQl8AjvQ== X-Google-Smtp-Source: ABdhPJxS0ATrWjLo9sj+XUyy8koys1QP+PJvoeoFNUvPJiTVFA4tFZil89Y+Fn6a3oT6x5JiwFKCRQ== X-Received: by 2002:adf:b198:: with SMTP id q24mr19941076wra.335.1594058255478; Mon, 06 Jul 2020 10:57:35 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id r8sm24689046wrp.40.2020.07.06.10.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 10:57:34 -0700 (PDT) Date: Mon, 6 Jul 2020 18:57:33 +0100 From: Lee Jones To: "Eric W. Biederman" Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Sumit Garg , Daniel Thompson , Douglas Anderson , Petr Mladek , Yinghai Lu , Jason Wessel Subject: Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Message-ID: <20200706175733.GB3500@dell> References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-26-lee.jones@linaro.org> <87imf0mvk7.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87imf0mvk7.fsf@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jul 2020, Eric W. Biederman wrote: > Lee Jones writes: > > > 'ret' hasn't been checked since the driver's inception in 2009. > > Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port > early console, v4") in July of 2008. I'm only going back as far as the inception of ehci-dbgp.c. > Acked-by: "Eric W. Biederman" Great, thanks. > > Fixes the following W=1 kernel build warning(s): > > > > drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: > > drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > 915 | int chunk, ret; > > | ^~~ > > > > Cc: Sumit Garg > > Cc: Daniel Thompson > > Cc: Douglas Anderson > > Cc: Petr Mladek > > Cc: "Eric W. Biederman" > > Cc: Yinghai Lu > > Cc: Jason Wessel > > Signed-off-by: Lee Jones > > --- > > drivers/usb/early/ehci-dbgp.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E36BC433E0 for ; Mon, 6 Jul 2020 17:59:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D20220672 for ; Mon, 6 Jul 2020 17:59:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LA7dxr6Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OK6kB8Q0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D20220672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4sN2QJYCPhjkV2ZEH3rH2/eXQ1IZ+2AKEo/6d0bLMPU=; b=LA7dxr6Z0TGA3rVyzl92TloAJ s61bUqZDteTP2sw6yFfmwso2FnD1a84Ghtt6IPkPopsvquPjjf3tWrE49RQBZbprSTtkXjTJVgC1o hLZC/NIwoR7PLdVuycsZG4w6V7bKaLPQ1ybE+M4WOpnhdXALjrTsyU51s4mK0Z5V+mvOd/xPTtea/ KgILTxBu0GfnPrpkrBF4D+gqC89zV0cN44pzSO62m7vdtLIMoLqeqfhaKNfpO2H80Yvc8ZStz2G1T jb1YWVgSRzqsM8QMigTnrD0rQ/1OhpjHueNognGww+lB1E2MnwPW0O8Mvf2o0qU8Jy7/mBSQ0x3bV dNNVlaZrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsVN7-0006wQ-7x; Mon, 06 Jul 2020 17:57:41 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsVN2-0006u3-Ez for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 17:57:38 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so42075605wrw.12 for ; Mon, 06 Jul 2020 10:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oTojjIFZzclanf7cLLuaYi/sgvjqGLuwhbXDv27Czb8=; b=OK6kB8Q0qPe86xIOUaHuGwfdS2zOPVnI1nFVI5idSlyGCaQ0kwkLr5OQ3iqaCDrVgp bSOqJkCjp0ec0QS590uLshH3kIWpHf1xbHU4eFZSHTSz2iazne518HLTBvJhqDK56dUJ VfvvqQ499iFKyO7u5d9hnovYGKCEt81Di/gCvWZ/6DEke38vxLl9lqh8sFCeusLjL1Ml 2qR161f3NJOvDObqFI6szLGqFQi4ZzNG3O+MRRM8N5BRRw06NsO/2NWwp4otwehlAyaq GjgvDbYRQdLgMd7gAaG1L8Juu1JYUeppORL67+udHl59TzHLYTVJB6lnzxfeszfPKiFn 3hag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oTojjIFZzclanf7cLLuaYi/sgvjqGLuwhbXDv27Czb8=; b=ViY0F4C16TiEAzsCfPkNUytvTvJQlhYFJ9aUVTSC/T5SDBItEzyN+J2VQsH7940TUC n7L6FKAs4DkcvVbFHtH91wZbqeZplqDtd+9t0RneXDSGfFu10ls9OAyRukRMR/8ZS/XD Xpxfbx8ZmCD47LQ90zY6VWY/jkiLdm+5HsX97/t8DoGtdCzYfikrhsP01Ke0MJg6kVbf XGPulpoTeZrzVQeOQRa5F9Spb5hYkN657Jg2splwZW7XpgwvRO3V8W9swVRZl9t+biL5 /StTWqH7qRVMWcY6NMI7m4/KSTgSIqVWIqbt8rz7wyBvXfF2Kh9P34U9QiXHxNRQGlST wJWw== X-Gm-Message-State: AOAM531GUqfQD7aLrM+VADF5GRrGmqrSjUrg4q1VvrEvgt5PmUZegomR 6BRcE74mVptqpZ9upNvHtmn63g== X-Google-Smtp-Source: ABdhPJxS0ATrWjLo9sj+XUyy8koys1QP+PJvoeoFNUvPJiTVFA4tFZil89Y+Fn6a3oT6x5JiwFKCRQ== X-Received: by 2002:adf:b198:: with SMTP id q24mr19941076wra.335.1594058255478; Mon, 06 Jul 2020 10:57:35 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id r8sm24689046wrp.40.2020.07.06.10.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 10:57:34 -0700 (PDT) Date: Mon, 6 Jul 2020 18:57:33 +0100 From: Lee Jones To: "Eric W. Biederman" Subject: Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Message-ID: <20200706175733.GB3500@dell> References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-26-lee.jones@linaro.org> <87imf0mvk7.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87imf0mvk7.fsf@x220.int.ebiederm.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_135736_830148_82354224 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Daniel Thompson , Petr Mladek , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , Yinghai Lu , Jason Wessel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNiBKdWwgMjAyMCwgRXJpYyBXLiBCaWVkZXJtYW4gd3JvdGU6Cgo+IExlZSBKb25l cyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdyaXRlczoKPiAKPiA+ICdyZXQnIGhhc24ndCAgYmVl biBjaGVja2VkIHNpbmNlIHRoZSBkcml2ZXIncyBpbmNlcHRpb24gaW4gMjAwOS4KPiAKPiBNaW5v ciBxdWliYmxlIHRoZSBpbmNlcHRpb24gd2FzIGluIDVjMDU5MTdlN2ZlMyAoIng4NjogdXNiIGRl YnVnIHBvcnQKPiBlYXJseSBjb25zb2xlLCB2NCIpIGluIEp1bHkgb2YgMjAwOC4KCkknbSBvbmx5 IGdvaW5nIGJhY2sgYXMgZmFyIGFzIHRoZSBpbmNlcHRpb24gb2YgZWhjaS1kYmdwLmMuCgo+IEFj a2VkLWJ5OiAiRXJpYyBXLiBCaWVkZXJtYW4iIDxlYmllZGVybUB4bWlzc2lvbi5jb20+CgpHcmVh dCwgdGhhbmtzLgoKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJu aW5nKHMpOgo+ID4KPiA+ICBkcml2ZXJzL3VzYi9lYXJseS9laGNpLWRiZ3AuYzogSW4gZnVuY3Rp b24g4oCYZWFybHlfZGJncF93cml0ZeKAmToKPiA+ICBkcml2ZXJzL3VzYi9lYXJseS9laGNpLWRi Z3AuYzo5MTU6MTM6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJldOKAmSBzZXQgYnV0IG5vdCB1c2Vk IFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ID4gIDkxNSB8IGludCBjaHVuaywgcmV0Owo+ ID4gIHwgXn5+Cj4gPgo+ID4gQ2M6IFN1bWl0IEdhcmcgPHN1bWl0LmdhcmdAbGluYXJvLm9yZz4K PiA+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgo+ID4g Q2M6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5kZXJzQGNocm9taXVtLm9yZz4KPiA+IENjOiBQZXRy IE1sYWRlayA8cG1sYWRla0BzdXNlLmNvbT4KPiA+IENjOiAiRXJpYyBXLiBCaWVkZXJtYW4iIDxl YmllZGVybUB4bWlzc2lvbi5jb20+Cj4gPiBDYzogWWluZ2hhaSBMdSA8eWhsdS5rZXJuZWxAZ21h aWwuY29tPgo+ID4gQ2M6IEphc29uIFdlc3NlbCA8amFzb24ud2Vzc2VsQHdpbmRyaXZlci5jb20+ Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4g LS0tCj4gPiAgZHJpdmVycy91c2IvZWFybHkvZWhjaS1kYmdwLmMgfCA2ICsrKy0tLQo+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgotLSAKTGVlIEpv bmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNl cwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93 IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=