All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, Benoit Parrot <bparrot@ti.com>
Subject: [PATCH v2 035/108] media: ti-vpe: cal: Inline cal_data_get_num_csi2_phy() in its caller
Date: Mon,  6 Jul 2020 21:35:56 +0300	[thread overview]
Message-ID: <20200706183709.12238-36-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20200706183709.12238-1-laurent.pinchart@ideasonboard.com>

The cal_data_get_num_csi2_phy() function simply returns
cal->data->num_csi2_phy, and is not consistently used across the driver,
as most accesses to cal->data->num_csi2_phy are open-coded. We could fix
those open-coded accesses to use cal_data_get_num_csi2_phy(), but that
wouldn't bring much in terms of readability, so inline
cal_data_get_num_csi2_phy() in its only caller instead, and drop the
function.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/platform/ti-vpe/cal.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
index 57d2feabc2e8..5b89d03d1f62 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -494,11 +494,6 @@ static void cal_quickdump_regs(struct cal_dev *cal)
 	}
 }
 
-static u32 cal_data_get_num_csi2_phy(struct cal_dev *cal)
-{
-	return cal->data->num_csi2_phy;
-}
-
 /* ------------------------------------------------------------------
  *	CAMERARX Management
  * ------------------------------------------------------------------
@@ -2328,7 +2323,7 @@ static int cal_probe(struct platform_device *pdev)
 	if (IS_ERR(cal->phy[0]))
 		return PTR_ERR(cal->phy[0]);
 
-	if (cal_data_get_num_csi2_phy(cal) > 1) {
+	if (cal->data->num_csi2_phy > 1) {
 		cal->phy[1] = cal_camerarx_create(cal, 1);
 		if (IS_ERR(cal->phy[1]))
 			return PTR_ERR(cal->phy[1]);
@@ -2340,7 +2335,7 @@ static int cal_probe(struct platform_device *pdev)
 	cal->ctx[1] = NULL;
 
 	cal->ctx[0] = cal_create_instance(cal, 0);
-	if (cal_data_get_num_csi2_phy(cal) > 1)
+	if (cal->data->num_csi2_phy > 1)
 		cal->ctx[1] = cal_create_instance(cal, 1);
 	if (!cal->ctx[0] && !cal->ctx[1]) {
 		cal_err(cal, "Neither port is configured, no point in staying up\n");
-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2020-07-06 18:38 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 18:35 [PATCH v2 000/108] media: ti-vpe: cal: Add media controller support Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 001/108] media: ti-vpe: cal: Sort headers alphabetically Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 002/108] media: ti-vpe: cal: Avoid function forward declaration Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 003/108] media: ti-vpe: cal: Decouple CSI2 port and CPORT Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 004/108] media: ti-vpe: cal: Index CSI-2 port starting at 0 Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 005/108] media: ti-vpe: cal: Index IRQ registersstarting " Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 006/108] media: ti-vpe: cal: Merge all status variables in IRQ handler Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 007/108] media: ti-vpe: cal: Inline CAL_VERSION macro in its only user Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 008/108] media: ti-vpe: cal: Turn reg_(read|write)_field() into inline functions Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 009/108] media: ti-vpe: cal: Make cal_formats array const Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 010/108] media: ti-vpe: cal: Remove needless variable initialization Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 011/108] media: ti-vpe: cal: Remove needless casts Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 012/108] media: ti-vpe: cal: Turn boolean variable into bool Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 013/108] media: ti-vpe: cal: Make loop indices unsigned where applicable Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 014/108] media: ti-vpe: cal: Embed base_fields array in struct cal_csi2_phy Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 015/108] media: ti-vpe: cal: Don't modify cal_csi2_phy base_fields Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 016/108] media: ti-vpe: cal: Store PHY regmap fields in struct cc_data Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 017/108] media: ti-vpe: cal: Rename cal_csi2_phy base_fields to fields Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 018/108] media: ti-vpe: cal: Make structure fields unsigned where applicable Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 019/108] media: ti-vpe: cal: Constify platform data Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 020/108] media: ti-vpe: cal: Remove static const cal_regmap_config template Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 021/108] media: ti-vpe: cal: Remove unused structure fields Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 022/108] media: ti-vpe: cal: Remove flags field from struct cal_dev Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 023/108] media: ti-vpe: cal: Move function to avoid forward declaration Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 024/108] media: ti-vpe: cal: Rename cc_data to cal_camerarx Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 025/108] media: ti-vpe: cal: Rename cal_csi2_phy to cal_camerarx_data Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 026/108] media: ti-vpe: cal: Name all cal_dev pointers consistently Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 027/108] media: ti-vpe: cal: Name all cal_camerarx " Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 028/108] media: ti-vpe: cal: Remove internal phy structure from cal_camerarx Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 029/108] media: ti-vpe: cal: Store instance ID and cal pointer in cal_camerarx Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 030/108] media: ti-vpe: cal: Use dev_* print macros Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 031/108] media: ti-vpe: cal: Add print macros for the cal_camerarx instances Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 032/108] media: ti-vpe: cal: Store sensor-related data in cal_camerarx Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 033/108] media: ti-vpe: cal: Create consistent naming for CAMERARX functions Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 034/108] media: ti-vpe: cal: Group CAMERARX-related functions together Laurent Pinchart
2020-07-06 18:35 ` Laurent Pinchart [this message]
2020-07-06 18:35 ` [PATCH v2 036/108] media: ti-vpe: cal: Create consistent naming for context functions Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 037/108] media: ti-vpe: cal: Reorganize remaining code in sections Laurent Pinchart
2020-07-06 18:35 ` [PATCH v2 038/108] media: ti-vpe: cal: Rename cal_ctx.csi2_port to cal_ctx.index Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 039/108] media: ti-vpe: cal: Use correct device name for bus_info Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 040/108] media: ti-vpe: cal: Get struct device without going through v4l2_device Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 041/108] media: ti-vpe: cal: Use ctx_info() instead of v4l2_info() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 042/108] media: ti-vpe: cal: Use a loop to create CAMERARX and context instances Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 043/108] media: ti-vpe: cal: Drop struct cal_dev v4l2_dev field Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 044/108] media: ti-vpe: cal: Split CAMERARX syscon regmap retrieval to a function Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 045/108] media: ti-vpe: cal: Use syscon_regmap_lookup_by_phandle_args() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 046/108] media: ti-vpe: cal: Inline cal_get_camerarx_regmap() in caller Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 047/108] media: ti-vpe: cal: Add comments to cal_probe() to delimitate sections Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 048/108] media: ti-vpe: cal: Rename cal_create_instance() to cal_ctx_create() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 049/108] media: ti-vpe: cal: Hardcode virtual channel to 0 Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 050/108] media: ti-vpe: cal: Use of_graph_get_endpoint_by_regs() to parse OF Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 051/108] media: ti-vpe: cal: Fix usage of v4l2_fwnode_endpoint_parse() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 052/108] media: ti-vpe: cal: Decouple control handler from v4l2_device Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 053/108] media: ti-vpe: cal: Move v4l2_device from cal_ctx to cal_dev Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 054/108] media: ti-vpe: cal: Split video device initialization and registration Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 055/108] media: ti-vpe: cal: Add context V4L2 cleanup and unregister functions Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 056/108] media: ti-vpe: cal: Unregister video device before cleanup Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 057/108] media: ti-vpe: cal: Add cal_camerarx_destroy() to cleanup CAMERARX Laurent Pinchart
2020-07-10 11:24   ` Hans Verkuil
2020-07-10 11:51     ` Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 058/108] media: ti-vpe: cal: Move DT parsing to CAMERARX Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 059/108] media: ti-vpe: cal: Use ARRAY_SIZE to replace numerical value Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 060/108] media: ti-vpe: cal: Move all sensor-related init to .bound() notifier Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 061/108] media: ti-vpe: cal: Allow multiple contexts per subdev notifier Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 062/108] media: ti-vpe: cal: Move async notifiers from contexts to cal_dev Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 063/108] media: ti-vpe: cal: Replace context with phy in async notifier entries Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 064/108] media: ti-vpe: cal: Operate on phy instances in cal_quickdump_regs() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 065/108] media: ti-vpe: cal: Decouple context and phy cleanup at remove time Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 066/108] media: ti-vpe: cal: Move CAL_NUM_CSI2_PORTS from cal_regs.h to cal.c Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 067/108] media: ti-vpe: cal: Remove isvcirqset() and isportirqset() macros Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 068/108] media: ti-vpe: cal: Replace number of ports numerical value by macro Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 069/108] media: ti-vpe: cal: Split media initialization and cleanup to functions Laurent Pinchart
2020-07-10 11:26   ` Hans Verkuil
2020-07-10 11:53     ` Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 070/108] media: ti-vpe: cal: Read hardware revision earlier during probe Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 071/108] media: ti-vpe: cal: Print revision and hwinfo in a more readable format Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 072/108] media: ti-vpe: cal: Store struct device in cal_dev Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 073/108] media: ti-vpe: cal: Register a media device Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 074/108] media: ti-vpe: cal: Init formats in cal_ctx_v4l2_register() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 075/108] media: ti-vpe: cal: Allocate cal_ctx active_fmt array dynamically Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 076/108] media: ti-vpe: cal: Inline cal_camerarx_max_lanes() in its only caller Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 077/108] media: ti-vpe: cal: Reorder camerarx functions to prepare refactoring Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 078/108] media: ti-vpe: cal: Refactor camerarx start and stop Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 079/108] media: ti-vpe: cal: Don't store external rate in cal_camerarx Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 080/108] media: ti-vpe: cal: Remove unneeded phy->sensor NULL check Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 081/108] media: ti-vpe: cal: Use 'unsigned int' type instead of 'unsigned' Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 082/108] media: ti-vpe: cal: Split video node handling to cal-video.c Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 083/108] media: ti-vpe: cal: Move CAL I/O accessors to cal.h Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 084/108] media: ti-vpe: cal: Split CAMERARX handling to cal-camerarx.c Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 085/108] media: ti-vpe: cal: Create subdev for CAMERARX Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 086/108] media: ti-vpe: cal: Drop cal_ctx m_fmt field Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 087/108] media: ti-vpe: cal: Move format handling to cal.c and expose helpers Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 088/108] media: ti-vpe: cal: Rename MAX_(WIDTH|HEIGHT)_* macros with CAL_ prefix Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 089/108] media: ti-vpe: cal: Replace hardcoded BIT() value with macro Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 090/108] media: ti-vpe: cal: Iterate over correct number of CAMERARX instances Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 091/108] media: ti-vpe: cal: Implement subdev ops for CAMERARX Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 092/108] media: ti-vpe: cal: Use CAMERARX subdev s_stream op in video device code Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 093/108] media: ti-vpe: cal: Don't pass format to cal_ctx_wr_dma_config() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 094/108] media: ti-vpe: cal: Rename struct cal_fmt to cal_format_info Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 095/108] media: ti-vpe: cal: Refactor interrupt enable/disable Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 096/108] media: ti-vpe: cal: Fold PPI enable in CAMERARX .s_stream() Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 097/108] media: ti-vpe: cal: Stop write DMA without disabling PPI Laurent Pinchart
2020-07-06 18:36 ` [PATCH v2 098/108] media: ti-vpe: cal: Use spin_lock_irq() when starting or stopping stream Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 099/108] media: ti-vpe: cal: Share buffer release code between start and stop Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 100/108] media: ti-vpe: cal: Drop V4L2_CAP_READWRITE Laurent Pinchart
2020-07-10 11:29   ` Hans Verkuil
2020-07-06 18:37 ` [PATCH v2 101/108] media: ti-vpe: cal: Drop unneeded check in cal_calc_format_size() Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 102/108] media: ti-vpe: cal: Remove DMA queue empty check at start streaming time Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 103/108] media: ti-vpe: cal: Use list_first_entry() Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 104/108] media: ti-vpe: cal: Group all DMA queue fields in struct cal_dmaqueue Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 105/108] media: ti-vpe: cal: Set cal_dmaqueue.pending to NULL when no pending buffer Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 106/108] media: ti-vpe: cal: Store buffer DMA address in dma_addr_t Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 107/108] media: ti-vpe: cal: Simplify the context API Laurent Pinchart
2020-07-06 18:37 ` [PATCH v2 108/108] media: ti-vpe: cal: Implement media controller centric API Laurent Pinchart
2020-11-03 11:02   ` Hans Verkuil
2020-12-06 23:24     ` Laurent Pinchart
2020-12-07  9:27       ` Hans Verkuil
2020-12-07 23:55         ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706183709.12238-36-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bparrot@ti.com \
    --cc=linux-media@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.