All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	Anna-Maria Gleixner <anna-maria@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>
Subject: [PATCH 3/9] timer: Optimize _next_timer_interrupt() level iteration
Date: Tue,  7 Jul 2020 03:32:47 +0200	[thread overview]
Message-ID: <20200707013253.26770-4-frederic@kernel.org> (raw)
In-Reply-To: <20200707013253.26770-1-frederic@kernel.org>

If a level has a timer that expires before we reach the next level,
there is no need to iterate further.

The next level is reached when the 3 lower bits of the current level are
cleared. If the next event happens before/during that, the next levels
won't give us an earlier expiration.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: Juri Lelli <juri.lelli@redhat.com>
---
 kernel/time/timer.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index ae1259f67486..acf7cb8c09f8 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1523,6 +1523,7 @@ static unsigned long __next_timer_interrupt(struct timer_base *base)
 	clk = base->clk;
 	for (lvl = 0; lvl < LVL_DEPTH; lvl++, offset += LVL_SIZE) {
 		int pos = next_pending_bucket(base, offset, clk & LVL_MASK);
+		unsigned long lvl_clk = clk & LVL_CLK_MASK;
 
 		if (pos >= 0) {
 			unsigned long tmp = clk + (unsigned long) pos;
@@ -1530,6 +1531,13 @@ static unsigned long __next_timer_interrupt(struct timer_base *base)
 			tmp <<= LVL_SHIFT(lvl);
 			if (time_before(tmp, next))
 				next = tmp;
+
+			/*
+			 * If the next expiration happens before we reach
+			 * the next level, no need to check further.
+			 */
+			if (pos <= ((LVL_CLK_DIV - lvl_clk) & LVL_CLK_MASK))
+				break;
 		}
 		/*
 		 * Clock for the next level. If the current level clock lower
@@ -1567,7 +1575,7 @@ static unsigned long __next_timer_interrupt(struct timer_base *base)
 		 * So the simple check whether the lower bits of the current
 		 * level are 0 or not is sufficient for all cases.
 		 */
-		adj = clk & LVL_CLK_MASK ? 1 : 0;
+		adj = lvl_clk ? 1 : 0;
 		clk >>= LVL_CLK_SHIFT;
 		clk += adj;
 	}
-- 
2.26.2


  parent reply	other threads:[~2020-07-07  1:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  1:32 [PATCH 0/9] timer: Reduce timers softirq v2 Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 1/9] timer: Move trigger_dyntick_cpu() to enqueue_timer() Frederic Weisbecker
2020-07-09 12:17   ` Anna-Maria Behnsen
2020-07-15 13:20     ` Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 2/9] timer: Add comments about calc_index() ceiling work Frederic Weisbecker
2020-07-14  9:13   ` Thomas Gleixner
2020-07-17 12:55     ` Frederic Weisbecker
2020-07-07  1:32 ` Frederic Weisbecker [this message]
2020-07-07  1:32 ` [PATCH 4/9] timers: Always keep track of next expiry Frederic Weisbecker
2020-07-14  8:49   ` Anna-Maria Behnsen
2020-07-17 12:51     ` Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 5/9] timer: Reuse next expiry cache after nohz exit Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 6/9] timer: Expand clk forward logic beyond nohz Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 7/9] timer: Spare timer softirq until next expiry Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 8/9] timer: Remove must_forward_clk Frederic Weisbecker
2020-07-07  1:32 ` [PATCH 9/9] timer: Lower base clock forwarding threshold Frederic Weisbecker
2020-07-09  7:02 ` [PATCH 0/9] timer: Reduce timers softirq v2 Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707013253.26770-4-frederic@kernel.org \
    --to=frederic@kernel.org \
    --cc=anna-maria@linutronix.de \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.