* [PATCH] Revert "riscv: sifive: fu540: Add gpio-restart support"
@ 2020-07-06 22:00 Tom Rini
2020-07-07 14:12 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2020-07-06 22:00 UTC (permalink / raw)
To: u-boot
As part of merging the next branch in to master, the sifive_fu540 will
fail to link:
riscv64-linux-ld.bfd: lib/built-in.o: in function `panic_finish':
lib/panic.c:28: undefined reference to `do_reset'
make[2]: *** [spl/u-boot-spl] Error 1
make[1]: *** [spl/u-boot-spl] Error 2
make: *** [sub-make] Error 2
And while the "fix the build" option of enabling CONFIG_SPL_SYSRESET may
solve the issue, it is unclear that it is the correct path exactly. For
the moment, I am reverting this commit and take a "revert the revert"
and proper fix as soon as it's available.
This reverts commit cdae446461191714d692190da1ad4344398adc57.
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Anup Patel <anup.patel@wdc.com>
Cc: Atish Patra <atish.patra@wdc.com>
Cc: Bin Meng <bin.meng@windriver.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
board/sifive/fu540/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig
index 6f6568196561..86193d7668be 100644
--- a/board/sifive/fu540/Kconfig
+++ b/board/sifive/fu540/Kconfig
@@ -65,7 +65,5 @@ config BOARD_SPECIFIC_OPTIONS # dummy
imply SMP
imply MISC
imply SIFIVE_OTP
- imply SYSRESET
- imply SYSRESET_GPIO
endif
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Revert "riscv: sifive: fu540: Add gpio-restart support"
2020-07-06 22:00 [PATCH] Revert "riscv: sifive: fu540: Add gpio-restart support" Tom Rini
@ 2020-07-07 14:12 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2020-07-07 14:12 UTC (permalink / raw)
To: u-boot
On Mon, Jul 06, 2020 at 06:00:51PM -0400, Tom Rini wrote:
> As part of merging the next branch in to master, the sifive_fu540 will
> fail to link:
> riscv64-linux-ld.bfd: lib/built-in.o: in function `panic_finish':
> lib/panic.c:28: undefined reference to `do_reset'
> make[2]: *** [spl/u-boot-spl] Error 1
> make[1]: *** [spl/u-boot-spl] Error 2
> make: *** [sub-make] Error 2
>
> And while the "fix the build" option of enabling CONFIG_SPL_SYSRESET may
> solve the issue, it is unclear that it is the correct path exactly. For
> the moment, I am reverting this commit and take a "revert the revert"
> and proper fix as soon as it's available.
>
> This reverts commit cdae446461191714d692190da1ad4344398adc57.
>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Anup Patel <anup.patel@wdc.com>
> Cc: Atish Patra <atish.patra@wdc.com>
> Cc: Bin Meng <bin.meng@windriver.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200707/f5a7ec27/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-07 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 22:00 [PATCH] Revert "riscv: sifive: fu540: Add gpio-restart support" Tom Rini
2020-07-07 14:12 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.