From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37773C433E0 for ; Wed, 8 Jul 2020 23:35:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02D7C20708 for ; Wed, 8 Jul 2020 23:35:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ar4yKdtP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02D7C20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtJam-0006i5-7r for qemu-devel@archiver.kernel.org; Wed, 08 Jul 2020 19:35:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtJZw-0005QQ-TQ for qemu-devel@nongnu.org; Wed, 08 Jul 2020 19:34:17 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:51585 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtJZv-0001zi-9C for qemu-devel@nongnu.org; Wed, 08 Jul 2020 19:34:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594251254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tlJbzLvoodNd4QVfzJeVHAh0c6191qma2ChIuUH7XoU=; b=Ar4yKdtPNM68QQ6h2bE4FejA2+veVIUowLTbBLWOF3Cqbhn8ENGCcSWp+nhtmXVQgV8O6o Z10MMib/ojxWTFr17A2zrn2Zqjjn0AZk6IRc15h4KmidchF5UaDSYZ6vp36zwQb7yaDkmv jnFmMoKg0vUnMiI0uYehMFV+Io3/iIE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-Q_NYCgwyMGOcdLM4HBltSQ-1; Wed, 08 Jul 2020 03:29:50 -0400 X-MC-Unique: Q_NYCgwyMGOcdLM4HBltSQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1EBD87950D; Wed, 8 Jul 2020 07:29:48 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-200.ams2.redhat.com [10.36.112.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95CB610021B3; Wed, 8 Jul 2020 07:29:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9E86A31F09; Wed, 8 Jul 2020 09:29:47 +0200 (CEST) Date: Wed, 8 Jul 2020 09:29:47 +0200 From: Gerd Hoffmann To: Paul Zimmerman Subject: Re: Failure prints during format or mounting a usb storage device Message-ID: <20200708072947.7hynrm53622tp3ha@sirius.home.kraxel.org> References: <2d312ec0-d280-c0e3-2b1e-ff9c70c3168f@gmail.com> <20200707075740.dkc76ceb7wytdoem@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 17:25:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Pavan Boddu , Peter Maydell , "qemu-devel@nongnu.org" , Vikram Garhwal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > > Why does 7ad3d51ebb8a522ffcad391c4bef281245739dde look at short-not-ok? > > Because the patch changes dev-storage to terminate the transfer if a > short packet is received, so I figured 'short-not-ok' should affect > that behavior. I don't think so. dev-storage should not need to look at short-not-ok. > I guess instead I could add another flag that only hcd-dwc2 sets. Does > that sound OK to you? Sounds like that'll be another workaround. dev-storage should not need to know what kind of host adapter is used ... A usb-storage transfer looks like this: (1) out transfer with the command (USB_MSDM_CBW) (2) data transfer, might be: - out (USB_MSDM_DATAOUT) for writes, or - in (USB_MSDM_DATAIN) for reads, or - nothing. depending on the scsi command. (3) in transfer with the status (USB_MSDM_CSW). (1) and (3) usually fit into a single usb packet. (2) can be multiple usb packets. The critical case seem to be reads, i.e. we have in transfers for both (2) and (3), and the transition from USB_MSDM_DATAIN state to USB_MSDM_CSW state. What is the sequence of usb packets submitted by the guest to hcd-dwc2 for reads? Where exactly does it expect a short transfer? take care, Gerd