From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4733C433E0 for ; Wed, 8 Jul 2020 10:55:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78D37206E9 for ; Wed, 8 Jul 2020 10:55:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gBQTnyl5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728664AbgGHKzK (ORCPT ); Wed, 8 Jul 2020 06:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgGHKzJ (ORCPT ); Wed, 8 Jul 2020 06:55:09 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8E87C08C5DC; Wed, 8 Jul 2020 03:55:09 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id m9so9549135pfh.0; Wed, 08 Jul 2020 03:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PBn0kG772UiRofP2vcjNJnGOHseI8tNLjt18LXfHgfM=; b=gBQTnyl5XQbz7QLwruwhpPZNpRDxt5cQZprhMlwkkb2tOSEoozJD6JurK8F/aIYp9r 0FCfhI+IyHfRuVNgfb7PulpmQizTMiuNcV72ITUVpbmneuavA3eOKelwFFIuVQ4MtP0D 0mdJNjRYy2ffNeNrCDrkHb0HwpyDx5xFYRj4TtQq/SI86iGLC93JfQs3dXR47omSWz0z WIzrJeGMdrURNQGDykSPdqVTGrGtUwxURq2j2p7/gibqwEMroAlDBXFu4MUwKF5oA62b mAqiyML/Tt3/nf63VpPqtBNil2XFSCdaA7ZnIx6sH6dvXUPpqbKT+//PUMCnCnr7wdey yXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PBn0kG772UiRofP2vcjNJnGOHseI8tNLjt18LXfHgfM=; b=p5CzGAG4jO+APHHIoT9qlXYE46mBKcWYFL/TEQc7vJmFQcvbZL63wjSSZRPPE45UgI K8dBg5X6m8AI5AFScw6k0ZoMce1kyHqMx8GVIpU9gqnTA3lsuXr2R7nJJqTr0imsJoYm tfTUlVqsR1Ii60Pzn1TadP5lPWO+jJtY6PiGHI9VuSJsvfPKdmB2Uw42aOVZd0YiNdo0 kGfxt/ETjhxSlYCuCFpmTW82g9xNK1HdgsE1+rp+Jet5r6iBSyb4jUrdF/D0jSfB9d4G eG3qi/mKyZg/T+B0iMwis4lsux7jCeVThoq+qfo7XEAr5/HD7QUbD0y7+TayRGvpCGGw 61WA== X-Gm-Message-State: AOAM532yFbDDFXtwkZQ73SRb1Ou+0sHUnhxlwh4u1OT/7m+6vQ7aOrSM OyPP2nYYxUM47oIZXwz5GSQ= X-Google-Smtp-Source: ABdhPJxDRRhChhbBwU6WplFG6NNjrSI88JLFqCzRTJ86Tmq94sqixN+4KdDzOUX2GRmEYYB8FFbCQw== X-Received: by 2002:a63:5461:: with SMTP id e33mr38807251pgm.321.1594205709230; Wed, 08 Jul 2020 03:55:09 -0700 (PDT) Received: from hoboy (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id f131sm3828328pgc.14.2020.07.08.03.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 03:55:08 -0700 (PDT) Date: Wed, 8 Jul 2020 03:55:06 -0700 From: Richard Cochran To: Sergey Organov Cc: Vladimir Oltean , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Jakub Kicinski , andrew@lunn.ch Subject: Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping Message-ID: <20200708105506.GB9080@hoboy> References: <20200706142616.25192-1-sorganov@gmail.com> <20200706142616.25192-2-sorganov@gmail.com> <20200706150814.kba7dh2dsz4mpiuc@skbuf> <87zh8cu0rs.fsf@osv.gnss.ru> <20200706154728.lfywhchrtaeeda4g@skbuf> <87zh8cqyrp.fsf@osv.gnss.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zh8cqyrp.fsf@osv.gnss.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 09:33:30PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > On Mon, Jul 06, 2020 at 06:21:59PM +0300, Sergey Organov wrote: > > Both are finicky in their own ways. There is no real way for the user to > > select which PHC they want to use. The assumption is that you'd always > > want to use the outermost one, and that things in the kernel side always > > collaborate towards that end. +1 In addition, for PHY time stamping you must enable the costly CONFIG_NETWORK_PHY_TIMESTAMPING option at compile time, and so the user most definitely wants the "outer" function. > Makes sense, -- thanks for clarification! Indeed, if somebody connected > that external thingy, chances are high it was made for a purpose. Yes, exactly. Thanks, Richard