From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9F0C433E0 for ; Wed, 8 Jul 2020 13:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD6DC20774 for ; Wed, 8 Jul 2020 13:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594214921; bh=+EXzLaIGuNzcggJX4dbRDub2DW6Hh2v4eTzeQDydLkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QOGyQ/DCdHIc0OLPungM6VICacRazuV8Ki4cKVGwLJ5Hfp04xCI6ql4OA4yARO9Zr YIXJDbcoLjmWqUX2EbMd5gwNo8YUJ/Yawu+n4OpSdGKxsWYsr9W5w0FoV+g8Sw1DMN hioTl9V9HTy1EOVO71FdQqx9eyiop/e7BSyG4pOM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729508AbgGHN2b (ORCPT ); Wed, 8 Jul 2020 09:28:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:35512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728364AbgGHN22 (ORCPT ); Wed, 8 Jul 2020 09:28:28 -0400 Received: from localhost.localdomain (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6807D20720; Wed, 8 Jul 2020 13:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594214908; bh=+EXzLaIGuNzcggJX4dbRDub2DW6Hh2v4eTzeQDydLkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dI3QpP3Bm0o/hSuSs8yvBest+gUB+6Qu+wI6usDJeDMhGsxGiQ+nF8aHL+PeyPWYh qeNjehxwUX60U/yvlrDN4nyPXySsVGNUBiz8z4RSfAl4NCfGI6B8DijRcgfn8Kck0d xWd1VeorilBau7z4F2KPfLNdS3DxJel3OukP3HT0= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, Vinod Koul , Loc Ho Subject: [PATCH 3/6] phy: xgene: remove unsigned integer comparison with less than zero Date: Wed, 8 Jul 2020 18:58:06 +0530 Message-Id: <20200708132809.265967-3-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200708132809.265967-1-vkoul@kernel.org> References: <20200708132809.265967-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get warning with W=1 build: drivers/phy/phy-xgene.c: In function ‘xgene_phy_xlate’: drivers/phy/phy-xgene.c:1618:20: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 1618 | if (args->args[0] < MODE_SATA || args->args[0] >= MODE_MAX) | args is uint32_t so can never be less than zero, so remove this check Cc: Loc Ho Signed-off-by: Vinod Koul --- drivers/phy/phy-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-xgene.c b/drivers/phy/phy-xgene.c index 7a33ec12f71b..b88922e7de1d 100644 --- a/drivers/phy/phy-xgene.c +++ b/drivers/phy/phy-xgene.c @@ -1615,7 +1615,7 @@ static struct phy *xgene_phy_xlate(struct device *dev, if (args->args_count <= 0) return ERR_PTR(-EINVAL); - if (args->args[0] < MODE_SATA || args->args[0] >= MODE_MAX) + if (args->args[0] >= MODE_MAX) return ERR_PTR(-EINVAL); ctx->mode = args->args[0]; -- 2.26.2