All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Bulekov <alxndr@bu.edu>
To: qemu-devel@nongnu.org
Cc: liq3ea@163.com, philmd@redhat.com, Alexander Bulekov <alxndr@bu.edu>
Subject: [PATCH-for-5.1 1/2] configure: do not clobber CFLAGS with --enable-fuzzing
Date: Wed,  8 Jul 2020 16:01:03 -0400	[thread overview]
Message-ID: <20200708200104.21978-2-alxndr@bu.edu> (raw)
In-Reply-To: <20200708200104.21978-1-alxndr@bu.edu>

When configuring with --enable-fuzzing, we overwrote the CFLAGS
added by all the preceding checks. Instead of overwriting CFLAGS, append
the ones we need.

Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing")
Reported-by: Li Qiang <liq3ea@163.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index ee6c3c6792..078ebaa9f3 100755
--- a/configure
+++ b/configure
@@ -7898,7 +7898,7 @@ if test "$fuzzing" = "yes" ; then
   if test "$have_fuzzer" = "yes"; then
     FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
     FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
-    CFLAGS=" -fsanitize=address,fuzzer-no-link"
+    CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link"
   else
     error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"
     exit 1
-- 
2.26.2



  reply	other threads:[~2020-07-08 20:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 20:01 [PATCH-for-5.1 0/2] fuzz: broken build fixes Alexander Bulekov
2020-07-08 20:01 ` Alexander Bulekov [this message]
2020-07-08 23:49   ` [PATCH-for-5.1 1/2] configure: do not clobber CFLAGS with --enable-fuzzing Li Qiang
2020-07-09  5:01   ` Philippe Mathieu-Daudé
2020-07-08 20:01 ` [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork Alexander Bulekov
2020-07-09  5:03   ` Philippe Mathieu-Daudé
2020-07-09  5:09     ` Philippe Mathieu-Daudé
2020-07-09  5:15       ` Thomas Huth
2020-07-09 13:15         ` Philippe Mathieu-Daudé
2020-07-09  5:18   ` Thomas Huth
2020-07-09 13:38     ` Alexander Bulekov
2020-07-09 13:57       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708200104.21978-2-alxndr@bu.edu \
    --to=alxndr@bu.edu \
    --cc=liq3ea@163.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.