From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127CEC433E0 for ; Wed, 8 Jul 2020 20:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DED6F206DF for ; Wed, 8 Jul 2020 20:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgGHUYP (ORCPT ); Wed, 8 Jul 2020 16:24:15 -0400 Received: from foss.arm.com ([217.140.110.172]:35762 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgGHUYP (ORCPT ); Wed, 8 Jul 2020 16:24:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C6E21FB; Wed, 8 Jul 2020 13:24:14 -0700 (PDT) Received: from bogus (unknown [10.37.8.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 32C033F66E; Wed, 8 Jul 2020 13:24:12 -0700 (PDT) Date: Wed, 8 Jul 2020 21:24:00 +0100 From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Stephen Boyd Cc: linux-kernel@vger.kernel.org, Michael Turquette , Dien Pham , Sudeep Holla Subject: Re: [PATCH 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Message-ID: <20200708202349.GA31671@bogus> References: <20200708110725.18017-1-sudeep.holla@arm.com> <20200708110725.18017-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200708110725.18017-2-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2020 at 12:07:25PM +0100, Sudeep Holla wrote: > Currently we are not initializing the scmi clock with discrete rates > correctly. We fetch the min_rate and max_rate value only for clocks with > ranges and ignore the ones with discrete rates. This will lead to wrong > initialization of rate range when clock supports discrete rate. > > Fix this by using the first and the last rate in the sorted list of the > discrete clock rates while registering the clock. > > Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") > Reported-by: Dien Pham > Signed-off-by: Sudeep Holla > --- > drivers/clk/clk-scmi.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > Hi Stephen, > > If you fine, I can take this via ARM SoC along with the change in firmware > driver. But it is fine if you want to merge this independently as it should > be fine. Let me know either way. > > Regards, > Sudeep > > diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > index c491f5de0f3f..ea65b7bf1408 100644 > --- a/drivers/clk/clk-scmi.c > +++ b/drivers/clk/clk-scmi.c > @@ -103,6 +103,8 @@ static const struct clk_ops scmi_clk_ops = { > static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) > { > int ret; > + unsigned long min_rate, max_rate; > + > struct clk_init_data init = { > .flags = CLK_GET_RATE_NOCACHE, > .num_parents = 0, > @@ -112,9 +114,23 @@ static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) > > sclk->hw.init = &init; > ret = devm_clk_hw_register(dev, &sclk->hw); > - if (!ret) > - clk_hw_set_rate_range(&sclk->hw, sclk->info->range.min_rate, > - sclk->info->range.max_rate); > + if (ret) > + return ret; > + > + if (sclk->info->rate_discrete) { > + int num_rates = sclk->info->list.num_rates; > + > + if (num_rates <= 0) > + return -EINVAL; > + > + min_rate = sclk->info->list.rates[0] I seem to have sent a version with ; missing above though I fixed but sent the old stale version as I had written a note to you 🙁 -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C12EC433E0 for ; Wed, 8 Jul 2020 20:26:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B22820720 for ; Wed, 8 Jul 2020 20:26:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GZ6Qz0Bg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B22820720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0uy2OodgBnIGi2riQeHQLqBRJaMNi8Lgi3lmR0Tq5ug=; b=GZ6Qz0BgN7YeW2w+umddqMkop 5lxs20YNmYZJi6K1azXsWoMYfZUgkiwjRUhicg4CYytTazmmjjex1wpikdiTTFf1afJrf6UucBwKJ 5RI9x3Dj7GNtv11Hyca65yFezXAKWG6SOLE0vtc4Sp97XnISlkHzAC8ev5lrRPAyADOaMwBOlXpY9 7nwpPPXZ5texCMJ/dkf5TacWNzisheeF8AkIZX+KsJ0/mGzsbIXltmCTd5mQGbDZ1Vqjk28cy9JZu DejP3JdEL1Hl/2xdOXZDvUrxnnS8cyExV5AsikEQPskaTXzKHTXqzhkyZSNSh7P3foDJ4DNnDla0X gxE92g1Ew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtGcF-00078b-E8; Wed, 08 Jul 2020 20:24:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtGcC-000789-PK for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 20:24:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C6E21FB; Wed, 8 Jul 2020 13:24:14 -0700 (PDT) Received: from bogus (unknown [10.37.8.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 32C033F66E; Wed, 8 Jul 2020 13:24:12 -0700 (PDT) Date: Wed, 8 Jul 2020 21:24:00 +0100 From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Message-ID: <20200708202349.GA31671@bogus> References: <20200708110725.18017-1-sudeep.holla@arm.com> <20200708110725.18017-2-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200708110725.18017-2-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_162424_881678_D19F40AF X-CRM114-Status: GOOD ( 24.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , Sudeep Holla , linux-kernel@vger.kernel.org, Dien Pham Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMDgsIDIwMjAgYXQgMTI6MDc6MjVQTSArMDEwMCwgU3VkZWVwIEhvbGxhIHdy b3RlOgo+IEN1cnJlbnRseSB3ZSBhcmUgbm90IGluaXRpYWxpemluZyB0aGUgc2NtaSBjbG9jayB3 aXRoIGRpc2NyZXRlIHJhdGVzCj4gY29ycmVjdGx5LiBXZSBmZXRjaCB0aGUgbWluX3JhdGUgYW5k IG1heF9yYXRlIHZhbHVlIG9ubHkgZm9yIGNsb2NrcyB3aXRoCj4gcmFuZ2VzIGFuZCBpZ25vcmUg dGhlIG9uZXMgd2l0aCBkaXNjcmV0ZSByYXRlcy4gVGhpcyB3aWxsIGxlYWQgdG8gd3JvbmcKPiBp bml0aWFsaXphdGlvbiBvZiByYXRlIHJhbmdlIHdoZW4gY2xvY2sgc3VwcG9ydHMgZGlzY3JldGUg cmF0ZS4KPiAKPiBGaXggdGhpcyBieSB1c2luZyB0aGUgZmlyc3QgYW5kIHRoZSBsYXN0IHJhdGUg aW4gdGhlIHNvcnRlZCBsaXN0IG9mIHRoZQo+IGRpc2NyZXRlIGNsb2NrIHJhdGVzIHdoaWxlIHJl Z2lzdGVyaW5nIHRoZSBjbG9jay4KPiAKPiBGaXhlczogNmQ2YTFkODJlYWVmNyAoImNsazogYWRk IHN1cHBvcnQgZm9yIGNsb2NrcyBwcm92aWRlZCBieSBTQ01JIikKPiBSZXBvcnRlZC1ieTogRGll biBQaGFtIDxkaWVuLnBoYW0ucnlAcmVuZXNhcy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU3VkZWVw IEhvbGxhIDxzdWRlZXAuaG9sbGFAYXJtLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9jbGsvY2xrLXNj bWkuYyB8IDIyICsrKysrKysrKysrKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gSGkgU3RlcGhlbiwKPiAKPiBJZiB5b3Ug ZmluZSwgSSBjYW4gdGFrZSB0aGlzIHZpYSBBUk0gU29DIGFsb25nIHdpdGggdGhlIGNoYW5nZSBp biBmaXJtd2FyZQo+IGRyaXZlci4gQnV0IGl0IGlzIGZpbmUgaWYgeW91IHdhbnQgdG8gbWVyZ2Ug dGhpcyBpbmRlcGVuZGVudGx5IGFzIGl0IHNob3VsZAo+IGJlIGZpbmUuIExldCBtZSBrbm93IGVp dGhlciB3YXkuCj4gCj4gUmVnYXJkcywKPiBTdWRlZXAKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9jbGsvY2xrLXNjbWkuYyBiL2RyaXZlcnMvY2xrL2Nsay1zY21pLmMKPiBpbmRleCBjNDkxZjVk ZTBmM2YuLmVhNjViN2JmMTQwOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2Nsay9jbGstc2NtaS5j Cj4gKysrIGIvZHJpdmVycy9jbGsvY2xrLXNjbWkuYwo+IEBAIC0xMDMsNiArMTAzLDggQEAgc3Rh dGljIGNvbnN0IHN0cnVjdCBjbGtfb3BzIHNjbWlfY2xrX29wcyA9IHsKPiAgc3RhdGljIGludCBz Y21pX2Nsa19vcHNfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBzY21pX2NsayAqc2Ns aykKPiAgewo+ICAJaW50IHJldDsKPiArCXVuc2lnbmVkIGxvbmcgbWluX3JhdGUsIG1heF9yYXRl Owo+ICsKPiAgCXN0cnVjdCBjbGtfaW5pdF9kYXRhIGluaXQgPSB7Cj4gIAkJLmZsYWdzID0gQ0xL X0dFVF9SQVRFX05PQ0FDSEUsCj4gIAkJLm51bV9wYXJlbnRzID0gMCwKPiBAQCAtMTEyLDkgKzEx NCwyMyBAQCBzdGF0aWMgaW50IHNjbWlfY2xrX29wc19pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwg c3RydWN0IHNjbWlfY2xrICpzY2xrKQo+IAo+ICAJc2Nsay0+aHcuaW5pdCA9ICZpbml0Owo+ICAJ cmV0ID0gZGV2bV9jbGtfaHdfcmVnaXN0ZXIoZGV2LCAmc2Nsay0+aHcpOwo+IC0JaWYgKCFyZXQp Cj4gLQkJY2xrX2h3X3NldF9yYXRlX3JhbmdlKCZzY2xrLT5odywgc2Nsay0+aW5mby0+cmFuZ2Uu bWluX3JhdGUsCj4gLQkJCQkgICAgICBzY2xrLT5pbmZvLT5yYW5nZS5tYXhfcmF0ZSk7Cj4gKwlp ZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJaWYgKHNjbGstPmluZm8tPnJhdGVfZGlz Y3JldGUpIHsKPiArCQlpbnQgbnVtX3JhdGVzID0gc2Nsay0+aW5mby0+bGlzdC5udW1fcmF0ZXM7 Cj4gKwo+ICsJCWlmIChudW1fcmF0ZXMgPD0gMCkKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ ICsJCW1pbl9yYXRlID0gc2Nsay0+aW5mby0+bGlzdC5yYXRlc1swXQoKSSBzZWVtIHRvIGhhdmUg c2VudCBhIHZlcnNpb24gd2l0aCA7IG1pc3NpbmcgYWJvdmUgdGhvdWdoIEkgZml4ZWQgYnV0CnNl bnQgdGhlIG9sZCBzdGFsZSB2ZXJzaW9uIGFzIEkgaGFkIHdyaXR0ZW4gYSBub3RlIHRvIHlvdSDw n5mBIAoKLS0gClJlZ2FyZHMsClN1ZGVlcAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=