From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Dave Jiang <dave.jiang@intel.com>, Jon Mason <jdmason@kudzu.us>,
Allen Hubbe <allenbh@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andrew Morton <akpm@linux-foundation.org>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-par
Subject: Re: [PATCH v3 1/4] iomap: Constify ioreadX() iomem argument (as in generic implementation)
Date: Thu, 9 Jul 2020 09:32:49 +0200 [thread overview]
Message-ID: <20200709073249.GA6335__4444.22534653626$1594280009$gmane$org@kozik-lap> (raw)
In-Reply-To: <20200709072837.5869-2-krzk@kernel.org>
On Thu, Jul 09, 2020 at 09:28:34AM +0200, Krzysztof Kozlowski wrote:
> The ioreadX() and ioreadX_rep() helpers have inconsistent interface. On
> some architectures void *__iomem address argument is a pointer to const,
> on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I forgot to put here one more Ack, for PowerPC:
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
https://lore.kernel.org/lkml/87ftedj0zz.fsf@mpe.ellerman.id.au/
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-07-09 7:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 7:28 [PATCH v3 0/4] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` [PATCH v3 1/4] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:32 ` Krzysztof Kozlowski [this message]
2020-07-09 7:32 ` Krzysztof Kozlowski
2020-07-09 7:32 ` Krzysztof Kozlowski
2020-07-09 7:32 ` Krzysztof Kozlowski
2020-07-09 7:32 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` [PATCH v3 2/4] rtl818x: " Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` [PATCH v3 3/4] ntb: intel: " Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` [PATCH v3 4/4] virtio: pci: " Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
2020-07-09 7:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20200709073249.GA6335__4444.22534653626$1594280009$gmane$org@kozik-lap' \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=dalias@libc.org \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=geert+renesas@glider.be \
--cc=ink@jurassic.park.msu.ru \
--cc=jasowang@redhat.com \
--cc=jdmason@kudzu.us \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.