From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A157C433DF for ; Thu, 9 Jul 2020 08:42:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 715AE20672 for ; Thu, 9 Jul 2020 08:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbgGIImo (ORCPT ); Thu, 9 Jul 2020 04:42:44 -0400 Received: from foss.arm.com ([217.140.110.172]:43368 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbgGIImn (ORCPT ); Thu, 9 Jul 2020 04:42:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 770A231B; Thu, 9 Jul 2020 01:42:43 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74AED3F887; Thu, 9 Jul 2020 01:42:42 -0700 (PDT) Date: Thu, 9 Jul 2020 09:42:36 +0100 From: Lorenzo Pieralisi To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, sudeep.holla@arm.com, kernel-hardening@lists.openwall.com Subject: Re: [PATCH v3 0/2] arm64/acpi: restrict AML opregion memory access Message-ID: <20200709084236.GA18009@e121166-lin.cambridge.arm.com> References: <20200626155832.2323789-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626155832.2323789-1-ardb@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jun 26, 2020 at 05:58:30PM +0200, Ard Biesheuvel wrote: > v2: > - do a more elaborate check on the region, against the EFI memory map > > v3: > - split into two patches > - fallback to __ioremap() for ACPI reclaim memory, in case it is not covered > by the linear mapping (e.g., when booting a kdump kernel) > > Ard Biesheuvel (2): > arm64/acpi: disallow AML memory opregions to access kernel memory > arm64/acpi: disallow writeable AML opregion mapping for EFI code > regions > > arch/arm64/include/asm/acpi.h | 15 +--- > arch/arm64/kernel/acpi.c | 75 ++++++++++++++++++++ > 2 files changed, 76 insertions(+), 14 deletions(-) Thanks Ard for fixing this, for the series: Acked-by: Lorenzo Pieralisi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB7BC433DF for ; Thu, 9 Jul 2020 08:44:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5703D20672 for ; Thu, 9 Jul 2020 08:44:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yd595WZx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5703D20672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vKgFzISTm5Z2JuLLLO8TP0QxJftYnNb4OgkupsbWkuk=; b=Yd595WZxAyOb9Rvx3MSPDuT6Z HvrzB24CgE06H1z8++Ei9kSPpe40fy1wfJlEov0M7jL/YoGRzv5nPAVKOGaedFFSyg4dUKrZnBZE4 9+Ruf3oFmQ2ww82BTdUsEXbd8vwLpL8SwCdVYrzjVUX2sjFUlhg5/pU31QYuYmDMe9UWtMMVjrwzk NiQW8ANX2dX8h52vnUxvPa1quA4gcRGRuH3r8YlEUSfMsZK3p+C5ioa9AhXSsuTGmmVGXLOiVCTIv PPnGuXI4FQarFNckjMsRhioNCPEYXqX3Cf2H6fsHu5KiMiMrNqrHwRZKofHXjGkfQmxvP1LSqVKXj SWZEG5naw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtS8o-0004m7-9B; Thu, 09 Jul 2020 08:42:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtS8i-0004jU-Eq for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 08:42:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 770A231B; Thu, 9 Jul 2020 01:42:43 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74AED3F887; Thu, 9 Jul 2020 01:42:42 -0700 (PDT) Date: Thu, 9 Jul 2020 09:42:36 +0100 From: Lorenzo Pieralisi To: Ard Biesheuvel Subject: Re: [PATCH v3 0/2] arm64/acpi: restrict AML opregion memory access Message-ID: <20200709084236.GA18009@e121166-lin.cambridge.arm.com> References: <20200626155832.2323789-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626155832.2323789-1-ardb@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_044244_606836_A02582F2 X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-hardening@lists.openwall.com, catalin.marinas@arm.com, linux-acpi@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 05:58:30PM +0200, Ard Biesheuvel wrote: > v2: > - do a more elaborate check on the region, against the EFI memory map > > v3: > - split into two patches > - fallback to __ioremap() for ACPI reclaim memory, in case it is not covered > by the linear mapping (e.g., when booting a kdump kernel) > > Ard Biesheuvel (2): > arm64/acpi: disallow AML memory opregions to access kernel memory > arm64/acpi: disallow writeable AML opregion mapping for EFI code > regions > > arch/arm64/include/asm/acpi.h | 15 +--- > arch/arm64/kernel/acpi.c | 75 ++++++++++++++++++++ > 2 files changed, 76 insertions(+), 14 deletions(-) Thanks Ard for fixing this, for the series: Acked-by: Lorenzo Pieralisi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel