From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Cc: dmaengine@vger.kernel.org, vkoul@kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, chuanhua.lei@linux.intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
malliamireddy009@gmail.com
Subject: Re: [PATCH v4 2/2] Add Intel LGM soc DMA support.
Date: Thu, 9 Jul 2020 14:09:14 +0300 [thread overview]
Message-ID: <20200709110914.GW3703480@smile.fi.intel.com> (raw)
In-Reply-To: <6be9b9cfbf6708fe371f280cb94cbdc9c04bdccb.1594273437.git.mallikarjunax.reddy@linux.intel.com>
On Thu, Jul 09, 2020 at 02:01:06PM +0800, Amireddy Mallikarjuna reddy wrote:
> Add DMA controller driver for Lightning Mountain(LGM) family of SoCs.
>
> The main function of the DMA controller is the transfer of data from/to any
> DPlus compliant peripheral to/from the memory. A memory to memory copy
> capability can also be configured.
>
> This ldma driver is used for configure the device and channnels for data
> and control paths.
> +#include "../virt-dma.h"
I didn't find any evidence this driver utilizes virt-dma API in full.
For example, there is a virt_dma_desc structure and descriptor management around it.
Why don't you use it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-09 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 6:01 [PATCH v4 0/2] Add Intel LGM soc DMA support Amireddy Mallikarjuna reddy
2020-07-09 6:01 ` [PATCH v4 1/2] dt-bindings: dma: Add bindings for intel LGM SOC Amireddy Mallikarjuna reddy
2020-07-09 7:54 ` Langer, Thomas
2020-07-13 3:39 ` Reddy, MallikarjunaX
2020-07-13 17:22 ` Rob Herring
2020-07-21 2:53 ` Reddy, MallikarjunaX
2020-07-09 6:01 ` [PATCH v4 2/2] Add Intel LGM soc DMA support Amireddy Mallikarjuna reddy
2020-07-09 11:09 ` Andy Shevchenko [this message]
2020-07-13 8:41 ` Reddy, MallikarjunaX
2020-07-13 9:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709110914.GW3703480@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malliamireddy009@gmail.com \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.