From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: remove dead bdi congestion leftovers Date: Thu, 9 Jul 2020 16:01:45 +0200 Message-ID: <20200709140145.GA3068@lst.de> References: <20200701090622.3354860-1-hch@lst.de> <20200709053233.GA3243@lst.de> <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <82e2785d-2091-1986-0014-3b7cea7cd0d8-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jens Axboe Cc: Christoph Hellwig , Tejun Heo , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-raid.ids On Thu, Jul 09, 2020 at 07:58:58AM -0600, Jens Axboe wrote: > On 7/8/20 11:32 PM, Christoph Hellwig wrote: > > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: > >> On 7/1/20 3:06 AM, Christoph Hellwig wrote: > >>> Hi Jens, > >>> > >>> we have a lot of bdi congestion related code that is left around without > >>> any use. This series removes it in preparation of sorting out the bdi > >>> lifetime rules properly. > >> > >> Please run series like this through a full compilation, for both this one > >> and the previous series I had to fix up issues like this: > >> > >> drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’: > >> drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable] > >> 1233 | struct gendisk *g = dc->disk.disk; > >> | ^ > >> drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’: > >> drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable] > >> 1320 | struct gendisk *g = d->disk; > >> | ^ > >> > >> Did the same here, applied it. > > > > And just like the previous one I did, and the compiler did not complain. > > There must be something about certain gcc versions not warning about > > variables that are initialized but not otherwise used. > > Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit > these cases for me, not sure why gcc-10 doesn't. And the ones quoted > above are about as trivial as they can get. gcc-9.3 from Debian -testing. And yes, I'm really surprised it didn't find those. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE27EC433E0 for ; Thu, 9 Jul 2020 14:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DD7D20708 for ; Thu, 9 Jul 2020 14:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbgGIOBu (ORCPT ); Thu, 9 Jul 2020 10:01:50 -0400 Received: from verein.lst.de ([213.95.11.211]:39578 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbgGIOBt (ORCPT ); Thu, 9 Jul 2020 10:01:49 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 03E3D68AEF; Thu, 9 Jul 2020 16:01:46 +0200 (CEST) Date: Thu, 9 Jul 2020 16:01:45 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Tejun Heo , dm-devel@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: remove dead bdi congestion leftovers Message-ID: <20200709140145.GA3068@lst.de> References: <20200701090622.3354860-1-hch@lst.de> <20200709053233.GA3243@lst.de> <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jul 09, 2020 at 07:58:58AM -0600, Jens Axboe wrote: > On 7/8/20 11:32 PM, Christoph Hellwig wrote: > > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: > >> On 7/1/20 3:06 AM, Christoph Hellwig wrote: > >>> Hi Jens, > >>> > >>> we have a lot of bdi congestion related code that is left around without > >>> any use. This series removes it in preparation of sorting out the bdi > >>> lifetime rules properly. > >> > >> Please run series like this through a full compilation, for both this one > >> and the previous series I had to fix up issues like this: > >> > >> drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’: > >> drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable] > >> 1233 | struct gendisk *g = dc->disk.disk; > >> | ^ > >> drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’: > >> drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable] > >> 1320 | struct gendisk *g = d->disk; > >> | ^ > >> > >> Did the same here, applied it. > > > > And just like the previous one I did, and the compiler did not complain. > > There must be something about certain gcc versions not warning about > > variables that are initialized but not otherwise used. > > Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit > these cases for me, not sure why gcc-10 doesn't. And the ones quoted > above are about as trivial as they can get. gcc-9.3 from Debian -testing. And yes, I'm really surprised it didn't find those.