From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: viresh.kumar@linaro.org, sboyd@kernel.org,
georgi.djakov@linaro.org, agross@kernel.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, saravanak@google.com,
dianders@chromium.org, vincent.guittot@linaro.org,
amit.kucheria@linaro.org, robdclark@chromium.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables
Date: Thu, 9 Jul 2020 07:45:34 -0700 [thread overview]
Message-ID: <20200709144534.GA1881320@builder.lan> (raw)
In-Reply-To: <20200702204643.25785-1-sibis@codeaurora.org>
On Thu 02 Jul 13:46 PDT 2020, Sibi Sankar wrote:
> Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
and applied.
Thanks,
Bjorn
> ---
>
> v2:
> * Drop interconnect tags
> * Add all possible cpu opps from supported frequency list
>
> v1: https://patchwork.kernel.org/patch/11527589/
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 285 +++++++++++++++++++++++++++
> 1 file changed, 285 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 8eb5a31346d28..9a7e27ede7186 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -12,6 +12,7 @@
> #include <dt-bindings/clock/qcom,lpass-sdm845.h>
> #include <dt-bindings/clock/qcom,rpmh.h>
> #include <dt-bindings/clock/qcom,videocc-sdm845.h>
> +#include <dt-bindings/interconnect/qcom,osm-l3.h>
> #include <dt-bindings/interconnect/qcom,sdm845.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/phy/phy-qcom-qusb2.h>
> @@ -198,6 +199,9 @@ &LITTLE_CPU_SLEEP_1
> capacity-dmips-mhz = <607>;
> dynamic-power-coefficient = <100>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_0>;
> L2_0: l2-cache {
> @@ -220,6 +224,9 @@ &LITTLE_CPU_SLEEP_1
> capacity-dmips-mhz = <607>;
> dynamic-power-coefficient = <100>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_100>;
> L2_100: l2-cache {
> @@ -239,6 +246,9 @@ &LITTLE_CPU_SLEEP_1
> capacity-dmips-mhz = <607>;
> dynamic-power-coefficient = <100>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_200>;
> L2_200: l2-cache {
> @@ -258,6 +268,9 @@ &LITTLE_CPU_SLEEP_1
> capacity-dmips-mhz = <607>;
> dynamic-power-coefficient = <100>;
> qcom,freq-domain = <&cpufreq_hw 0>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_300>;
> L2_300: l2-cache {
> @@ -277,6 +290,9 @@ &BIG_CPU_SLEEP_1
> &CLUSTER_SLEEP_0>;
> dynamic-power-coefficient = <396>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> + operating-points-v2 = <&cpu4_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_400>;
> L2_400: l2-cache {
> @@ -296,6 +312,9 @@ &BIG_CPU_SLEEP_1
> &CLUSTER_SLEEP_0>;
> dynamic-power-coefficient = <396>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> + operating-points-v2 = <&cpu4_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_500>;
> L2_500: l2-cache {
> @@ -315,6 +334,9 @@ &BIG_CPU_SLEEP_1
> &CLUSTER_SLEEP_0>;
> dynamic-power-coefficient = <396>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> + operating-points-v2 = <&cpu4_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_600>;
> L2_600: l2-cache {
> @@ -334,6 +356,9 @@ &BIG_CPU_SLEEP_1
> &CLUSTER_SLEEP_0>;
> dynamic-power-coefficient = <396>;
> qcom,freq-domain = <&cpufreq_hw 1>;
> + operating-points-v2 = <&cpu4_opp_table>;
> + interconnects = <&gladiator_noc MASTER_APPSS_PROC &mem_noc SLAVE_EBI1>,
> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
> #cooling-cells = <2>;
> next-level-cache = <&L2_700>;
> L2_700: l2-cache {
> @@ -433,6 +458,266 @@ CLUSTER_SLEEP_0: cluster-sleep-0 {
> };
> };
>
> + cpu0_opp_table: cpu0_opp_table {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + cpu0_opp1: opp-300000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + opp-peak-kBps = <800000 4800000>;
> + };
> +
> + cpu0_opp2: opp-403200000 {
> + opp-hz = /bits/ 64 <403200000>;
> + opp-peak-kBps = <800000 4800000>;
> + };
> +
> + cpu0_opp3: opp-480000000 {
> + opp-hz = /bits/ 64 <480000000>;
> + opp-peak-kBps = <800000 6451200>;
> + };
> +
> + cpu0_opp4: opp-576000000 {
> + opp-hz = /bits/ 64 <576000000>;
> + opp-peak-kBps = <800000 6451200>;
> + };
> +
> + cpu0_opp5: opp-652800000 {
> + opp-hz = /bits/ 64 <652800000>;
> + opp-peak-kBps = <800000 7680000>;
> + };
> +
> + cpu0_opp6: opp-748800000 {
> + opp-hz = /bits/ 64 <748800000>;
> + opp-peak-kBps = <1804000 9216000>;
> + };
> +
> + cpu0_opp7: opp-825600000 {
> + opp-hz = /bits/ 64 <825600000>;
> + opp-peak-kBps = <1804000 9216000>;
> + };
> +
> + cpu0_opp8: opp-902400000 {
> + opp-hz = /bits/ 64 <902400000>;
> + opp-peak-kBps = <1804000 10444800>;
> + };
> +
> + cpu0_opp9: opp-979200000 {
> + opp-hz = /bits/ 64 <979200000>;
> + opp-peak-kBps = <1804000 11980800>;
> + };
> +
> + cpu0_opp10: opp-1056000000 {
> + opp-hz = /bits/ 64 <1056000000>;
> + opp-peak-kBps = <1804000 11980800>;
> + };
> +
> + cpu0_opp11: opp-1132800000 {
> + opp-hz = /bits/ 64 <1132800000>;
> + opp-peak-kBps = <2188000 13516800>;
> + };
> +
> + cpu0_opp12: opp-1228800000 {
> + opp-hz = /bits/ 64 <1228800000>;
> + opp-peak-kBps = <2188000 15052800>;
> + };
> +
> + cpu0_opp13: opp-1324800000 {
> + opp-hz = /bits/ 64 <1324800000>;
> + opp-peak-kBps = <2188000 16588800>;
> + };
> +
> + cpu0_opp14: opp-1420800000 {
> + opp-hz = /bits/ 64 <1420800000>;
> + opp-peak-kBps = <3072000 18124800>;
> + };
> +
> + cpu0_opp15: opp-1516800000 {
> + opp-hz = /bits/ 64 <1516800000>;
> + opp-peak-kBps = <3072000 19353600>;
> + };
> +
> + cpu0_opp16: opp-1612800000 {
> + opp-hz = /bits/ 64 <1612800000>;
> + opp-peak-kBps = <4068000 19353600>;
> + };
> +
> + cpu0_opp17: opp-1689600000 {
> + opp-hz = /bits/ 64 <1689600000>;
> + opp-peak-kBps = <4068000 20889600>;
> + };
> +
> + cpu0_opp18: opp-1766400000 {
> + opp-hz = /bits/ 64 <1766400000>;
> + opp-peak-kBps = <4068000 22425600>;
> + };
> + };
> +
> + cpu4_opp_table: cpu4_opp_table {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + cpu4_opp1: opp-300000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + opp-peak-kBps = <800000 4800000>;
> + };
> +
> + cpu4_opp2: opp-403200000 {
> + opp-hz = /bits/ 64 <403200000>;
> + opp-peak-kBps = <800000 4800000>;
> + };
> +
> + cpu4_opp3: opp-480000000 {
> + opp-hz = /bits/ 64 <480000000>;
> + opp-peak-kBps = <1804000 4800000>;
> + };
> +
> + cpu4_opp4: opp-576000000 {
> + opp-hz = /bits/ 64 <576000000>;
> + opp-peak-kBps = <1804000 4800000>;
> + };
> +
> + cpu4_opp5: opp-652800000 {
> + opp-hz = /bits/ 64 <652800000>;
> + opp-peak-kBps = <1804000 4800000>;
> + };
> +
> + cpu4_opp6: opp-748800000 {
> + opp-hz = /bits/ 64 <748800000>;
> + opp-peak-kBps = <1804000 4800000>;
> + };
> +
> + cpu4_opp7: opp-825600000 {
> + opp-hz = /bits/ 64 <825600000>;
> + opp-peak-kBps = <2188000 9216000>;
> + };
> +
> + cpu4_opp8: opp-902400000 {
> + opp-hz = /bits/ 64 <902400000>;
> + opp-peak-kBps = <2188000 9216000>;
> + };
> +
> + cpu4_opp9: opp-979200000 {
> + opp-hz = /bits/ 64 <979200000>;
> + opp-peak-kBps = <2188000 9216000>;
> + };
> +
> + cpu4_opp10: opp-1056000000 {
> + opp-hz = /bits/ 64 <1056000000>;
> + opp-peak-kBps = <3072000 9216000>;
> + };
> +
> + cpu4_opp11: opp-1132800000 {
> + opp-hz = /bits/ 64 <1132800000>;
> + opp-peak-kBps = <3072000 11980800>;
> + };
> +
> + cpu4_opp12: opp-1209600000 {
> + opp-hz = /bits/ 64 <1209600000>;
> + opp-peak-kBps = <4068000 11980800>;
> + };
> +
> + cpu4_opp13: opp-1286400000 {
> + opp-hz = /bits/ 64 <1286400000>;
> + opp-peak-kBps = <4068000 11980800>;
> + };
> +
> + cpu4_opp14: opp-1363200000 {
> + opp-hz = /bits/ 64 <1363200000>;
> + opp-peak-kBps = <4068000 15052800>;
> + };
> +
> + cpu4_opp15: opp-1459200000 {
> + opp-hz = /bits/ 64 <1459200000>;
> + opp-peak-kBps = <4068000 15052800>;
> + };
> +
> + cpu4_opp16: opp-1536000000 {
> + opp-hz = /bits/ 64 <1536000000>;
> + opp-peak-kBps = <5412000 15052800>;
> + };
> +
> + cpu4_opp17: opp-1612800000 {
> + opp-hz = /bits/ 64 <1612800000>;
> + opp-peak-kBps = <5412000 15052800>;
> + };
> +
> + cpu4_opp18: opp-1689600000 {
> + opp-hz = /bits/ 64 <1689600000>;
> + opp-peak-kBps = <5412000 19353600>;
> + };
> +
> + cpu4_opp19: opp-1766400000 {
> + opp-hz = /bits/ 64 <1766400000>;
> + opp-peak-kBps = <6220000 19353600>;
> + };
> +
> + cpu4_opp20: opp-1843200000 {
> + opp-hz = /bits/ 64 <1843200000>;
> + opp-peak-kBps = <6220000 19353600>;
> + };
> +
> + cpu4_opp21: opp-1920000000 {
> + opp-hz = /bits/ 64 <1920000000>;
> + opp-peak-kBps = <7216000 19353600>;
> + };
> +
> + cpu4_opp22: opp-1996800000 {
> + opp-hz = /bits/ 64 <1996800000>;
> + opp-peak-kBps = <7216000 20889600>;
> + };
> +
> + cpu4_opp23: opp-2092800000 {
> + opp-hz = /bits/ 64 <2092800000>;
> + opp-peak-kBps = <7216000 20889600>;
> + };
> +
> + cpu4_opp24: opp-2169600000 {
> + opp-hz = /bits/ 64 <2169600000>;
> + opp-peak-kBps = <7216000 20889600>;
> + };
> +
> + cpu4_opp25: opp-2246400000 {
> + opp-hz = /bits/ 64 <2246400000>;
> + opp-peak-kBps = <7216000 20889600>;
> + };
> +
> + cpu4_opp26: opp-2323200000 {
> + opp-hz = /bits/ 64 <2323200000>;
> + opp-peak-kBps = <7216000 20889600>;
> + };
> +
> + cpu4_opp27: opp-2400000000 {
> + opp-hz = /bits/ 64 <2400000000>;
> + opp-peak-kBps = <7216000 22425600>;
> + };
> +
> + cpu4_opp28: opp-2476800000 {
> + opp-hz = /bits/ 64 <2476800000>;
> + opp-peak-kBps = <7216000 22425600>;
> + };
> +
> + cpu4_opp29: opp-2553600000 {
> + opp-hz = /bits/ 64 <2553600000>;
> + opp-peak-kBps = <7216000 22425600>;
> + };
> +
> + cpu4_opp30: opp-2649600000 {
> + opp-hz = /bits/ 64 <2649600000>;
> + opp-peak-kBps = <7216000 22425600>;
> + };
> +
> + cpu4_opp31: opp-2745600000 {
> + opp-hz = /bits/ 64 <2745600000>;
> + opp-peak-kBps = <7216000 25497600>;
> + };
> +
> + cpu4_opp32: opp-2803200000 {
> + opp-hz = /bits/ 64 <2803200000>;
> + opp-peak-kBps = <7216000 25497600>;
> + };
> + };
> +
> pmu {
> compatible = "arm,armv8-pmuv3";
> interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2020-07-09 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 20:46 [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables Sibi Sankar
2020-07-09 2:22 ` Steev Klimaszewski
2020-07-09 14:29 ` Bjorn Andersson
2020-07-09 14:43 ` Sibi Sankar
2020-07-09 14:45 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709144534.GA1881320@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.