From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7C5C433DF for ; Thu, 9 Jul 2020 16:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72BFD2077D for ; Thu, 9 Jul 2020 16:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727950AbgGIQio (ORCPT ); Thu, 9 Jul 2020 12:38:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:45244 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgGIQio (ORCPT ); Thu, 9 Jul 2020 12:38:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 32976AE0A; Thu, 9 Jul 2020 16:38:43 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id E0CD4DAB7F; Thu, 9 Jul 2020 18:38:23 +0200 (CEST) Date: Thu, 9 Jul 2020 18:38:23 +0200 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, Josef Bacik Subject: Re: [PATCH v3 3/3] btrfs: qgroup: remove the ASYNC_COMMIT mechanism in favor of qgroup reserve retry-after-EDQUOT Message-ID: <20200709163823.GC15161@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org, Josef Bacik References: <20200708062447.81341-1-wqu@suse.com> <20200708062447.81341-4-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708062447.81341-4-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Jul 08, 2020 at 02:24:47PM +0800, Qu Wenruo wrote: > commit a514d63882c3 ("btrfs: qgroup: Commit transaction in advance to > reduce early EDQUOT") tries to reduce the early EDQUOT problems by > checking the qgroup free against threshold and try to wake up commit > kthread to free some space. > > The problem of that mechanism is, it can only free qgroup per-trans > metadata space, can't do anything to data, nor prealloc qgroup space. > > Now since we have the ability to flush qgroup space, and implements > retry-after-EDQUOT behavior, such mechanism is completely replaced. > > So this patch will cleanup such mechanism in favor of > retry-after-EDQUOT. > > Signed-off-by: Qu Wenruo > Reviewed-by: Josef Bacik That one looks good to me.