From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFCC8C433DF for ; Thu, 9 Jul 2020 22:23:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98E072070E for ; Thu, 9 Jul 2020 22:23:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GdS/cgrN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98E072070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtexG-0005jm-Tp for qemu-devel@archiver.kernel.org; Thu, 09 Jul 2020 18:23:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtewV-0004qj-K4 for qemu-devel@nongnu.org; Thu, 09 Jul 2020 18:22:59 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:35188 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtewU-0005Oy-5f for qemu-devel@nongnu.org; Thu, 09 Jul 2020 18:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594333377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sottn+eLfH62dBpxrTZtJ+/8M9q4rutb2HCAm7UBtQw=; b=GdS/cgrNWkE6RA2vOsx8NyKc2uUqJUHjM01ZZZd1uT45mUS89mlIqb7JNQhkm+1quoWHN3 MvOAE31CVJf3TZwfounasJcRsi90MeC6DDd0jc+Gj0HtPJh1OnyNOjacFEa4Jgweh1cBqe C1aLndK4se3JiNTJP+YA1SX6ln38Esg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-LLxkGCnpNgieMhUX7_qhrA-1; Thu, 09 Jul 2020 18:22:53 -0400 X-MC-Unique: LLxkGCnpNgieMhUX7_qhrA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48F4E18FF660; Thu, 9 Jul 2020 22:22:52 +0000 (UTC) Received: from localhost (ovpn-116-140.rdu2.redhat.com [10.10.116.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9223A27DE60; Thu, 9 Jul 2020 22:22:50 +0000 (UTC) Date: Thu, 9 Jul 2020 18:22:49 -0400 From: Eduardo Habkost To: Chenyi Qiang Subject: Re: [PATCH v5 3/4] target/i386: add the missing features for Icelake-Server CPU model Message-ID: <20200709222249.GP780932@habkost.net> References: <20200619073114.24303-1-chenyi.qiang@intel.com> <20200619073114.24303-4-chenyi.qiang@intel.com> MIME-Version: 1.0 In-Reply-To: <20200619073114.24303-4-chenyi.qiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=ehabkost@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/09 11:25:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Robert Hoo , Xiaoyao Li , qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 19, 2020 at 03:31:13PM +0800, Chenyi Qiang wrote: > Add the missing features(sha-ni, avx512ifma, rdpid, fsrm) in the > Icelake-Server CPU model. > > Signed-off-by: Chenyi Qiang Reviewed-by: Eduardo Habkost > --- > target/i386/cpu.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 1f3d8db842..3c81ca543f 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -3508,6 +3508,16 @@ static X86CPUDefinition builtin_x86_defs[] = { > { /* end of list */ } > }, > }, > + { > + .version = 4, > + .props = (PropValue[]) { > + { "sha-ni", "on" }, > + { "avx512ifma", "on" }, > + { "rdpid", "on" }, > + { "fsrm", "on" }, > + { /* end of list */ } > + }, > + }, > { /* end of list */ } > } > }, > -- > 2.17.1 > > -- Eduardo