All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org, linux@roeck-us.net
Subject: Re: [PATCH net] cgroup: Fix sock_cgroup_data on big-endian.
Date: Fri, 10 Jul 2020 14:44:59 -0700 (PDT)	[thread overview]
Message-ID: <20200710.144459.1317276747917429038.davem@davemloft.net> (raw)
In-Reply-To: <20200710135424.609af50a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 10 Jul 2020 13:54:24 -0700

> On Fri, 10 Jul 2020 13:47:47 -0700 (PDT) David Miller wrote:
>> From: Jakub Kicinski <kuba@kernel.org>
>> Date: Thu, 9 Jul 2020 17:03:20 -0700
>> 
>> > On Thu, 09 Jul 2020 16:32:35 -0700 (PDT) David Miller wrote:  
>> >> From: Cong Wang <xiyou.wangcong@gmail.com>
>> >> 
>> >> In order for no_refcnt and is_data to be the lowest order two
>> >> bits in the 'val' we have to pad out the bitfield of the u8.
>> >> 
>> >> Fixes: ad0f75e5f57c ("cgroup: fix cgroup_sk_alloc() for sk_clone_lock()")
>> >> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> >> Signed-off-by: David S. Miller <davem@davemloft.net>  
>> > 
>> > FWIW Cong's listed in From: but there's no sign-off from him so the
>> > signoff checking script may get upset about this one.  
>> 
>> I wonder how I should handle that situation though?  I want to give
>> Cong credit for the change, and not take full credit for it myself.
> 
> Cong, would you mind responding with a Sign-off for the patch?

That's not useful for two reasons:

1) This commit is in my tree and the commit message is immutable.

2) I needed to apply this patch because I didn't have time to wait for
   a turn-around from Cong or anyone else.  That's the situation where
   I'm asking "what should I do in this situation?"  I don't have the
   luxury of waiting for the author to reply and add a signoff because
   I'm trying to get a pull request out to Linus with the fix or
   similar.

Is it more clear now? :-)

      reply	other threads:[~2020-07-10 21:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 23:32 [PATCH net] cgroup: Fix sock_cgroup_data on big-endian David Miller
2020-07-10  0:01 ` Cong Wang
2020-07-10  0:03 ` Jakub Kicinski
2020-07-10 20:47   ` David Miller
2020-07-10 20:54     ` Jakub Kicinski
2020-07-10 21:44       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200710.144459.1317276747917429038.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.